linux-toradex.git/drivers/phy, branch toradex_vf_4.1-next

phy: twl4030-usb: Fix unbalanced pm_runtime_enable on module reload

2016-03-04T15:25:40+00:00

[ Upstream commit 58a66dba1beac2121d931cda4682ae4d40816af5 ]

If we reload phy-twl4030-usb, we get a warning about unbalanced
pm_runtime_enable. Let's fix the issue and also fix idling of the
device on unload before we attempt to shut it down.

If we don't properly idle the PHY before shutting it down on removal,
the twl4030 ends up consuming about 62mW of extra power compared to
running idle with the module loaded.

Cc: stable@vger.kernel.org
Cc: Bin Liu 
Cc: Felipe Balbi 
Cc: Kishon Vijay Abraham I 
Cc: NeilBrown 
Signed-off-by: Tony Lindgren 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Sasha Levin

phy: twl4030-usb: Relase usb phy on unload

2016-03-04T15:25:40+00:00

[ Upstream commit b241d31ef2f6a289d33dcaa004714b26e06f476f ]

Otherwise rmmod omap2430; rmmod phy-twl4030-usb; modprobe omap2430
will try to use a non-existing phy and oops:

Unable to handle kernel paging request at virtual address b6f7c1f0
...
[] (devm_usb_get_phy_by_node) from []
(omap2430_musb_init+0x44/0x2b4 [omap2430])
[] (omap2430_musb_init [omap2430]) from []
(musb_init_controller+0x194/0x878 [musb_hdrc])

Cc: stable@vger.kernel.org
Cc: Bin Liu 
Cc: Felipe Balbi 
Cc: Kishon Vijay Abraham I 
Cc: NeilBrown 
Signed-off-by: Tony Lindgren 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Sasha Levin

phy: core: fix wrong err handle for phy_power_on

2016-03-04T15:25:40+00:00

[ Upstream commit b82fcabe212a11698fd4b3e604d2f81d929d22f6 ]

If phy_pm_runtime_get_sync failed but we already
enable regulator, current code return directly without
doing regulator_disable. This patch fix this problem
and cleanup err handle of phy_power_on to be more readable.

Fixes: 3be88125d85d ("phy: core: Support regulator ...")
Cc:  # v3.18+
Cc: Roger Quadros 
Cc: Axel Lin 
Signed-off-by: Shawn Lin 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Sasha Levin

phy: twl4030-usb: make runtime pm more reliable.

2015-08-17T03:52:13+00:00

commit 56301df6bcaaed31e77b8c500ca1b437f46a3158 upstream.

A construct like:

        if (pm_runtime_suspended(twl->dev))
               pm_runtime_get_sync(twl->dev);

is against the spirit of the runtime_pm interface as it
makes the internal refcounting useless.

In this case it is also racy, particularly as 'put_autosuspend'
is used to drop a reference.
When that happens a timer is started and the device is
runtime-suspended after the timeout.
If the above code runs in this window, the device will not be
found to be suspended so no pm_runtime reference is taken.
When the timer expires the device will be suspended, which is
against the intention of the code.

So be more direct is taking and dropping references.
If twl->linkstat is VBUS_VALID or ID_GROUND, then hold a
pm_runtime reference, otherwise don't.
Define "cable_present()" to test for this condition.

Tested-by: Tony Lindgren 
Signed-off-by: NeilBrown 
Signed-off-by: Kishon Vijay Abraham I 
Cc: Alexander Holler 
Signed-off-by: Greg Kroah-Hartman

phy: berlin-usb: fix divider for BG2CD

2015-08-03T16:29:05+00:00

commit 96696a9df935d15fd2e89603454c20a692ec232a upstream.

The marvell,berlin2cd-usb-phy compatible incorrectly sets the PLL
divider to BG2's value instead of BG2CD/BG2Q's. Change it to the right
value.

Signed-off-by: Thomas Hebb 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Greg Kroah-Hartman

phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function.

2015-08-03T16:29:05+00:00

commit 4724e27114c4a7eceeee07db227a17fcab6f165c upstream.

The USB phy should initialize with power-off, and will be powered on
by the USB system when a cable connection is detected.

Having this pm_runtime_get_sync() during probe causes the phy to
*always* be powered on.
Removing it returns to sensible power management.

Fixes: 96be39ab34b77c6f6f5cd6ae03aac6c6449ee5c4
Signed-off-by: NeilBrown 
Signed-off-by: Kishon Vijay Abraham I 
Signed-off-by: Greg Kroah-Hartman

phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

2015-05-12T15:27:19+00:00

According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
bit location is bit 8, not bits 1 and 0. It also says that the register
address offset of UGSTS is 0x88, not 0x90.
So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.

Signed-off-by: Yoshihiro Shimoda 
Signed-off-by: Kishon Vijay Abraham I

phy: omap-usb2: invoke pm_runtime_disable on error path

2015-05-12T15:27:19+00:00

if devm_clk_get for wkupclk fails, there will be an unbalanced
pm_runtime_enable. Fix it here.

Reported-by: Benoit Parrot 
Cc: Roger Quadros 
Signed-off-by: Kishon Vijay Abraham I

phy: fix Kconfig dependencies

2015-05-12T15:27:18+00:00

DM816x PHY uses usb_phy_* methods and because
of that, it must select USB_PHY, however, because
the drivers in question (DM816x, TWL4030 and
OMAP_USB2) sit outside of drivers/usb/ directory,
meaning they can be built even if USB_SUPPORT=n.

This patches fixes the dependencies by adding
USB_SUPPORT as a dependency and making all drivers
select USB_PHY (which cannot be selected through
menuconfig).

Note that this fixes some linking breakages when
building with randconfig.

Cc: Tony Lindgren 
Cc: Kishon Vijay Abraham I 
Acked-by: Tony Lindgren 
Signed-off-by: Felipe Balbi 
Signed-off-by: Kishon Vijay Abraham I

phy: qcom-ufs: Switch dependency to ARCH_QCOM

2015-05-12T15:22:13+00:00

This phy only exists on platforms under ARCH_QCOM, not ARCH_MSM.

Cc: Yaniv Gardi 
Cc: Dov Levenglick 
Cc: Christoph Hellwig 
Cc: David Brown 
Cc: Bryan Huntsman 
Cc: Daniel Walker 
Signed-off-by: Stephen Boyd 
Reviewed-by: Yaniv Gardi 
Signed-off-by: Kishon Vijay Abraham I