linux-toradex.git/drivers/pinctrl/mediatek/pinctrl-moore.c, branch v5.0

pinctrl: mediatek: clean up indentation issues, add missing tab

2018-11-09T08:54:54+00:00

Trivial fix to clean up indentation issues, add one level of
indentation on two if statements.

Signed-off-by: Colin Ian King 
Signed-off-by: Linus Walleij

pinctrl: mediatek: fix check on EINT_NA comparison

2018-09-26T07:43:01+00:00

Currently, the check on desc->eint.eint_n == EINT_NA is always false
because this is comparing a u16 to -1 which can never be true.  Fix
this by casting EINT_NA to u16.

Detected by CoverityScan, CID#1473610 ("Operands don't affect result")

Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c")
Signed-off-by: Colin Ian King 
Signed-off-by: Linus Walleij

pinctrl: mediatek: moore: fix return value check in mtk_moore_pinctrl_probe()

2018-09-21T16:08:18+00:00

In case of error, the function devm_kmalloc_array() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: b7d7f9eeca55 ("pinctrl: mediatek: extend struct mtk_pin_desc which per-pin driver depends on")
Signed-off-by: Wei Yongjun 
Acked-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mtk: Fix up GPIO includes

2018-09-18T23:38:27+00:00

Include only  since this is a driver,
not a consumer.

Cc: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: extend eint build to pinctrl-mtk-common-v2.c

2018-09-18T21:53:37+00:00

Almost all MediaTek SoCs apply the exact same logic to build eint, so move
the common functions into pinctrl-mtk-common-v2.c to allow each new pinctrl
driver to reuse them. Also, add a protection checker on hw->soc->eint_hw to
avoid invalid memory access when there's certain SoC not to define its
eint_hw properly in the code flow.

Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: extend struct mtk_pin_desc which per-pin driver depends on

2018-09-18T21:53:22+00:00

Because the pincrl-mtk-common.c is an implementation for per-pin binding,
its pin descriptor includes more information than pinctrl-mtk-common-v2
so far can support. So, we complement these data before writing a driver
using pincrl-mtk-common-v2.c for per-pin binding. By the way, the size of
struct mtk_pin_desc would be larger than struct pinctrl_pin_desc can hold,
so it's necessary to have a copy before the pins information is being
registered into the core.

Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: add multiple register bases support to pinctrl-mtk-common-v2.c

2018-09-18T21:53:12+00:00

Certain SoC own multiple register base for accessing each pin groups,
it's easy to be done with extend struct mtk_pin_field_calc to support
the kind of SoC such as MT8183.

Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: use pin descriptor all in pinctrl-mtk-common-v2.c

2018-09-18T21:53:07+00:00

all use pin descriptor instead in pinctrl-mtk-common-v2.c for the
consistency and extensibility.

Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: add ies register support to pinctrl-mtk-common-v2.c

2018-09-18T21:53:00+00:00

Certain SoCs have to program an extra IES register to configure input
enabled mode so that we add it in the existing path as an option.

Signed-off-by: Ryder.Lee 
Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij

pinctrl: mediatek: add advanced pull related support to pinctrl-mtk-common-v2.c

2018-09-18T21:52:57+00:00

There are some specific pins (i.e. MMC/SD) need specific registers to
turn on/off the 10K & 50k(75K) resistors when pull up/down.

Therefore, this patch adds the custom prarmeters so that the user could
control it through device tree.

Signed-off-by: Ryder.Lee 
Signed-off-by: Sean Wang 
Signed-off-by: Linus Walleij