linux-toradex.git/drivers/pinctrl/pinctrl-rockchip.c, branch v3.14.12

pinctrl: rockchip: missing unlock on error in rockchip_set_pull()

2013-11-25T08:08:18+00:00

We need to unlock here before returning -EINVAL.

Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')

Signed-off-by: Dan Carpenter 
Acked-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: testing the wrong variable

2013-11-25T08:08:18+00:00

There is a copy and paste bug so we test "info->reg_base" instead of
"info->reg_pull".

Signed-off-by: Dan Carpenter 
Acked-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: emulate both edge triggered interrupts

2013-10-16T13:33:55+00:00

The gpio interrupt controller on Rockchip socs can do edge triggers only
for single edges but not both. Nevertheless a lot of gpio users rely on
the availability of both-edge triggered interrupts - i.e. gpio-keys.

Therefore implement a solution similar to pinctrl-coh901 re-setting the
triggering edge depending on the gpio value in the interrupt demuxer.

Signed-off-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: add rk3188 specifics

2013-10-16T13:33:54+00:00

Besides the pull registers sitting in a separate place, the rk3188 also
has the peculiarity that the pull registers of the first bank are split
and the first half is sitting in the register space of the pmu.

Therefore this adds a special bank-type for the first bank, to handle
the two register sources.

Signed-off-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: remove redundant check

2013-10-16T13:33:53+00:00

The check limiting bias options to supported ones is already
done thru rockchip_pinconf_pull_valid. Therefore this check is
redundant and can be removed.

Signed-off-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: add support for multiple bank types

2013-10-16T13:33:53+00:00

There are Rockchip SoCs, namely the rk3188, that combine a set of
regular banks with banks that need special handling for some settings.

Therefore add the possibility for the driver to handle more than one
bank type.

Signed-off-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: separate different sub-types more

2013-10-16T13:33:52+00:00

Further investigation of the different Rockchip SoCs showed that
the differences especially in the pull settings are quite deep.
As further patches will show, the register layout for the pulls of
the rk3188 is quite strange. Also it is to assume, that later
Rockchip SoCs may introduce even more quirks in this regard, making
it hard to support all of those using the current generic pull_*
variables.

Therefore move the driver to hold the type of controller in an enum
and do the handling according to it in the necessary places. Also
instead of calculating the register in the get and set pull functions
move it to a type-specific callback.

Signed-off-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: rockchip: Implement .request() and .free() callbacks

2013-08-29T07:11:00+00:00

Implement .request() and .free() callbacks on the GPIO chips to
inform pinctrl when a GPIO is requested or freed.

Signed-off-by: Axel Lin 
Tested-by: Heiko Stuebner 
Acked-by: Heiko Stuebner 
Signed-off-by: Linus Walleij

pinctrl: Pass all configs to driver on pin_config_set()

2013-08-28T11:34:41+00:00

When setting pin configuration in the pinctrl framework, pin_config_set() or
pin_config_group_set() is called in a loop to set one configuration at a time
for the specified pin or group.

This patch 1) removes the loop and 2) changes the API to pass the whole pin
config array to the driver.  It is now up to the driver to loop through the
configs.  This allows the driver to potentially combine configs and reduce the
number of writes to pin config registers.

All c files changed have been build-tested to verify the change compiles and
that the corresponding .o is successfully generated.

Signed-off-by: Sherman Yin 
Reviewed-by: Christian Daudt 
Reviewed-by: Matt Porter 
Tested-by: Stephen Warren 
Acked-by: Laurent Pinchart 
Signed-off-by: Linus Walleij

pinctrl: rockchip: Simplify pin_to_bank equation

2013-08-28T11:34:18+00:00

If (b->pin_base + b->nr_pins - 1) < pin is true, pin >= b->pin_base is always
true because b->nr_pins is never less than 0.
Thus this patch simplify the equation.

Signed-off-by: Axel Lin 
Acked-by: Heiko Stuebner 
Signed-off-by: Linus Walleij