linux-toradex.git/drivers/pinctrl/pinctrl-single.c, branch v4.10

pinctrl: single: Fix a couple error codes

2016-11-16T19:56:19+00:00

We should return -ENOMEM instead of success if pcs_add_function() fails.

Signed-off-by: Dan Carpenter 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: search for the bits property when parsing bits

2016-11-11T20:29:37+00:00

The pcs_parse_bits_in_pinctrl_entry function should search
for the "pinctrl-single,bits" and not "pinctrl-single,pins"

Signed-off-by: Axel Haslam 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: check for any error when getting rows

2016-11-11T20:28:07+00:00

pinctrl_count_index_with_args returns -ENOENT not
-EINVAL. The return check would pass, and we would
try to kzalloc with a negative error size throwing
a warning.

Instead of checking for -EINVAL specifically, lets
check for any error and avoid negative size allocations.

Signed-off-by: Axel Haslam 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Use generic parser and #pinctrl-cells for pinctrl-single,bits

2016-11-04T21:53:06+00:00

We can now use generic parser and keep things compatible with the
old binding.

Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Use generic parser and #pinctrl-cells for pinctrl-single,pins

2016-11-04T21:51:50+00:00

We can now use generic parser. To support the legacy binding without
#pinctrl-cells, add pcs_quirk_missing_pinctrl_cells() and warn about
missing #pinctrl-cells.

Let's also update the documentation for struct pcs_soc_data while at it
as that seems to be out of date.

Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Drop pointless macro

2016-10-28T11:54:00+00:00

This is left over from initial experiments with more properties.
It's only used in one place, so let's just get rid of it to make
the code more readable.

Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Drop custom names

2016-10-28T11:31:50+00:00

>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren 
Date: Tue, 25 Oct 2016 08:33:34 -0700
Subject: [PATCHv2] pinctrl: single: Drop custom names

We no longer need to allocate custom names as those are dynamically
generated in pinctrl_register_one_pin() if no name is passed to
pinctrl_register_pins().

Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Fix missing flush of posted write for a wakeirq

2016-06-22T15:58:07+00:00

With many repeated suspend resume cycles, the pin specific wakeirq
may not always work on omaps. This is because the write to enable the
pin interrupt may not have reached the device over the interconnect
before suspend happens.

Let's fix the issue with a flush of posted write with a readback.

Cc: stable@vger.kernel.org
Reported-by: Nishanth Menon 
Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Fix pcs_parse_bits_in_pinctrl_entry to use __ffs than ffs

2016-04-15T09:26:55+00:00

pcs_parse_bits_in_pinctrl_entry uses ffs which gives bit indices
ranging from 1 to MAX. This leads to a corner case where we try to request
the pin number = MAX and fails.

bit_pos value is being calculted using ffs. pin_num_from_lsb uses
bit_pos value. pins array is populated with:

pin + pin_num_from_lsb.

The above is 1 more than usual bit indices as bit_pos uses ffs to compute
first set bit. Hence the last of the pins array is populated with the MAX
value and not MAX - 1 which causes error when we call pin_request.

mask_pos is rightly calculated as ((pcs->fmask) << (bit_pos - 1))
Consequently val_pos and submask are correct.

Hence use __ffs which gives (ffs(x) - 1) as the first bit set.

fixes: 4e7e8017a8 ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules")
Signed-off-by: Keerthy 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Use a separate lockdep class

2016-03-11T16:03:06+00:00

The single pinmux controller can be cascaded to the other interrupt
controllers. Hence when propagating wake-up settings to its parent
interrupt controller, there's possiblity of detecting possible recursive
locking and getting lockdep warning.

This patch avoids this false positive by using a separate lockdep class
for this single pinctrl interrupts.

Cc: linux-gpio@vger.kernel.org
Suggested-by: Thomas Gleixner 
Signed-off-by: Sudeep Holla 
Reviewed-by: Grygorii Strashko 
Signed-off-by: Linus Walleij