linux-toradex.git/drivers/pinctrl/vt8500, branch v4.12-rc1

pinctrl: Widen the generic pinconf argument from 16 to 24 bits

2017-01-26T14:22:32+00:00

The current pinconf packed format allows only 16-bit argument limiting
the maximum value 65535. For most types this is enough. However,
debounce time can be in range of hundreths of milliseconds in case of
mechanical switches so we cannot represent the worst case using the
current format.

In order to support larger values change the packed format so that the
lower 8 bits are used as type which leaves 24 bits for the argument.
This allows representing values up to 16777215 and debounce times up to
16 seconds.

We also convert the existing users to use 32-bit integer when extracting
argument from the packed configuration value.

Signed-off-by: Mika Westerberg 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Linus Walleij

pinctrl: vt8500: make bool drivers explicitly non-modular

2016-11-15T09:04:20+00:00

None of the Kconfigs for any of these drivers are tristate, meaning
that they currently are not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the drivers there is no doubt they are builtin-only.  All
drivers get the exact same change, so they are handled in batch.

Changes are (1) use builtin_platform_driver, (2) use init.h header
(3) delete module_exit related code, (4) delete MODULE_DEVICE_TABLE,
(5) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags and (6)
drop ".remove" code and prevent sysfs unbind attempts to call ".remove".

Once this is done, the shared remove function in wmt.[ch] is no longer
used and hence it is removed as well.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE etc. tags since all that information
is already contained at the top of each file in the comments.

Cc: Tony Prisk 
Cc: Linus Walleij 
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker 
Signed-off-by: Linus Walleij

pinctrl: vt8500: Use devm_pinctrl_register() for pinctrl registration

2016-04-21T07:23:20+00:00

Use devm_pinctrl_register() for pin control registration and clean
the error path.

Signed-off-by: Laxman Dewangan 
Cc: Lee Jones 
Cc: Heiko Stuebner 
Cc: Mika Westerberg 
Cc: Hongzhou Yang 
Signed-off-by: Linus Walleij

pinctrl: vt8500-wmt: use gpiochip data pointer

2016-01-05T13:15:08+00:00

This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().

Cc: Heiko Stuebner 
Signed-off-by: Linus Walleij

gpio: change member .dev to .parent

2015-11-19T08:24:35+00:00

The name .dev in a struct is normally reserved for a struct device
that is let us say a superclass to the thing described by the struct.
struct gpio_chip stands out by confusingly using a struct device *dev
to point to the parent device (such as a platform_device) that
represents the hardware. As we want to give gpio_chip:s real devices,
this is not working. We need to rename this member to parent.

This was done by two coccinelle scripts, I guess it is possible to
combine them into one, but I don't know such stuff. They look like
this:

@@
struct gpio_chip *var;
@@
-var->dev
+var->parent

and:

@@
struct gpio_chip var;
@@
-var.dev
+var.parent

and:

@@
struct bgpio_chip *var;
@@
-var->gc.dev
+var->gc.parent

Plus a few instances of bgpio that I couldn't figure out how
to teach Coccinelle to rewrite.

This patch hits all over the place, but I *strongly* prefer this
solution to any piecemal approaches that just exercise patch
mechanics all over the place. It mainly hits drivers/gpio and
drivers/pinctrl which is my own backyard anyway.

Cc: Haavard Skinnemoen 
Cc: Rafał Miłecki 
Cc: Richard Purdie 
Cc: Mauro Carvalho Chehab 
Cc: Alek Du 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Acked-by: Dmitry Torokhov 
Acked-by: Greg Kroah-Hartman 
Acked-by: Lee Jones 
Acked-by: Jiri Kosina 
Acked-by: Hans-Christian Egtvedt 
Acked-by: Jacek Anaszewski 
Signed-off-by: Linus Walleij

pinctrl: replace trivial implementations of gpio_chip request/free

2015-10-16T20:20:21+00:00

Replace all trivial request/free callbacks that do nothing but call into
pinctrl code with the generic versions.

Signed-off-by: Jonas Gorski 
Acked-by: Bjorn Andersson 
Acked-by: Heiko Stuebner 
Acked-by: Eric Anholt 
Acked-by: Mika Westerberg 
Acked-by: Andrew Bresticker 
Acked-by: Baruch Siach 
Acked-by: Matthias Brugger 
Acked-by: Lee Jones 
Acked-by: Laxman Dewangan 
Acked-by: Maxime Ripard 
Signed-off-by: Linus Walleij

pinctrl: make pinctrl_register() return proper error code

2015-06-10T12:49:52+00:00

Currently, pinctrl_register() just returns NULL on error, so the
callers can not know the exact reason of the failure.

Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some
-ENOMEM on error of pinctrl_register(), although the error code
might be different from the real cause of the error.

This commit reworks pinctrl_register() to return the appropriate
error code and modifies all of the pinctrl drivers to use IS_ERR()
for the error checking and PTR_ERR() for getting the error code.

Signed-off-by: Masahiro Yamada 
Acked-by: Patrice Chotard 
Acked-by: Thierry Reding 
Acked-by: Heiko Stuebner 
Tested-by: Mika Westerberg 
Acked-by: Mika Westerberg 
Acked-by: Lee Jones 
Acked-by: Sören Brinkmann 
Acked-by: Laurent Pinchart 
Acked-by: Ray Jui 
Acked-by: Antoine Tenart 
Acked-by: Hongzhou Yang 
Acked-by: Wei Chen 
Signed-off-by: Linus Walleij

pinctrl: constify of_device_id array

2015-03-27T08:58:35+00:00

of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)

Signed-off-by: Fabian Frederick 
Acked-by: Jean-Christophe PLAGNIOL-VILLARD 
Acked-by: Patrice Chotard 
Acked-by: Maxime Coquelin 
Acked-by: Hongzhou Yang 
Acked-by: Lee Jones 
Signed-off-by: Linus Walleij

pinctrl: vt8500: drop owner assignment from platform_drivers

2014-10-20T14:21:26+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

pinctrl: clean up after enable refactoring

2014-09-04T08:05:07+00:00

commit 2243a87d90b42eb38bc281957df3e57c712b5e56
"pinctrl: avoid duplicated calling enable_pinmux_setting for a pin"
removed the .disable callback from the struct pinmux_ops,
making the .enable() callback the only remaining callback.

However .enable() is a bad name as it seems to imply that a
muxing can also be disabled. Rename the callback to .set_mux()
and also take this opportunity to clean out any remaining
mentions of .disable() from the documentation.

Acked-by: Stephen Warren 
Acked-by: Bjorn Andersson 
Acked-by: Fan Wu 
Signed-off-by: Linus Walleij