linux-toradex.git/drivers/platform/chrome/cros_ec_sysfs.c, branch v4.20-rc6

platform/chrome: Use to_cros_ec_dev more broadly

2018-05-30T18:53:40+00:00

Move to_cros_ec_dev macro to cros_ec.h and use it when the private ec
object is needed from device object.

Signed-off-by: Gwendal Grignou 
Reviewed-by: Enric Balletbo i Serra 
Signed-off-by: Benson Leung

platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle

2018-04-11T05:25:07+00:00

This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle)
used to set and get the keyboard wake lid angle. This attribute is
present only if 2 accelerometers are controlled by the EC.

This patch also moves the cros_ec features check before the device is
added so the features map obtained from the EC is ready on time.

Signed-off-by: Gwendal Grignou 
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Andy Shevchenko 
Acked-by: Lee Jones 
Signed-off-by: Benson Leung

platform/chrome: cros_ec_sysfs: use permission-specific DEVICE_ATTR variants

2018-04-11T05:23:48+00:00

Use DEVICE_ATTR variants for read/write attributes. This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.

Suggested-by: Andy Shevchenko 
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Benson Leung

platform/chrome: cros_ec_sysfs: introduce to_cros_ec_dev define.

2018-04-11T05:22:49+00:00

Add a define to get the cros_ec_dev from device and use it.

Suggested-by: Andy Shevchenko 
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Benson Leung

platform/chrome: cros_ec_sysfs: Modify error handling

2018-04-11T05:22:34+00:00

When accessing a sysfs attribute, if the EC command fails, -EPROTO is
now returned instead of an error message as it is unlikely an app is
parsing the error message to do something meaningful.
Also, this patch makes use of cros_ec_cmd_xfer_status() instead of
cros_ec_cmd_xfer() so an error message is printed in the syslog.

Signed-off-by: Gwendal Grignou 
Signed-off-by: Enric Balletbo i Serra 
Signed-off-by: Benson Leung

cros_ec: fix nul-termination for firmware build info

2017-12-16T05:07:17+00:00

As gcc-8 reports, we zero out the wrong byte:

drivers/platform/chrome/cros_ec_sysfs.c: In function 'show_ec_version':
drivers/platform/chrome/cros_ec_sysfs.c:190:12: error: array subscript 4294967295 is above array bounds of 'uint8_t[]' [-Werror=array-bounds]

This changes the code back to what it did before changing to a
zero-length array structure.

Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command data")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Benson Leung

cros_ec: Move cros_ec_dev module to drivers/mfd

2017-12-15T10:46:06+00:00

The cros_ec_dev module is responsible for registering the MFD devices
attached to the ChromeOS EC. This patch moves this module to drivers/mfd
so calls to mfd_add_devices() are not done from outside the MFD subtree
anymore.

Signed-off-by: Thierry Escande 
Reviewed-by: Gwendal Grignou 
Tested-by: Guenter Roeck 
Signed-off-by: Lee Jones

cros_ec: Split cros_ec_devs module

2017-12-15T10:45:11+00:00

This patch splits the cros_ec_devs module in two parts with a
cros_ec_dev module responsible for handling MFD devices registration and
a cros_ec_ctl module responsible for handling the various user-space
interfaces.

For consistency purpose, the driver name for the cros_ec_dev module is
now cros-ec-dev instead of cros-ec-ctl.

In the next commit, the new cros_ec_dev module will be moved to the MFD
subtree so mfd_add_devices() calls are not done from outside MFD.

Signed-off-by: Thierry Escande 
Reviewed-by: Gwendal Grignou 
Tested-by: Guenter Roeck 
Signed-off-by: Lee Jones

mfd: cros_ec: Support multiple EC in a system

2015-06-15T12:18:23+00:00

Chromebooks can have more than one Embedded Controller so the
cros_ec device id has to be incremented for each EC registered.

Add a new structure to represent multiple EC as different char
devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to
cros_ec_device and allows sysfs inferface for cros_pd.

Also reduce number of allocated objects, make chromeos sysfs
class object a static and add refcounting to prevent object
deletion while command is in progress.

Signed-off-by: Gwendal Grignou 
Reviewed-by: Dmitry Torokhov 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones

mfd: cros_ec: Use a zero-length array for command data

2015-06-15T12:18:19+00:00

Commit 1b84f2a4cd4a ("mfd: cros_ec: Use fixed size arrays to transfer
data with the EC") modified the struct cros_ec_command fields to not
use pointers for the input and output buffers and use fixed length
arrays instead.

This change was made because the cros_ec ioctl API uses that struct
cros_ec_command to allow user-space to send commands to the EC and
to get data from the EC. So using pointers made the API not 64-bit
safe. Unfortunately this approach was not flexible enough for all
the use-cases since there may be a need to send larger commands
on newer versions of the EC command protocol.

So to avoid to choose a constant length that it may be too big for
most commands and thus wasting memory and CPU cycles on copy from
and to user-space or having a size that is too small for some big
commands, use a zero-length array that is both 64-bit safe and
flexible. The same buffer is used for both output and input data
so the maximum of these values should be used to allocate it.

Suggested-by: Gwendal Grignou 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones