linux-toradex.git/drivers/platform/x86/intel_pmic_gpio.c, branch v3.4.23

intel_pmic_gpio: Convert printks to pr_

2011-05-27T16:35:50+00:00

Add #define pr_fmt(fmt) "%s: " fmt, __func__
to prefix function name to each output message.
Convert printks to pr_.

Signed-off-by: Joe Perches 
Signed-off-by: Matthew Garrett

x86 platform drivers: Build fix for intel_pmic_gpio

2011-04-13T15:52:16+00:00

Fix an incorrect function name so the driver builds.

Signed-off-by: Matthew Garrett

platform-drivers: x86: pmic: Restore the dropped buslock/unlock

2011-04-04T16:51:16+00:00

When I added the buslock/unlock mechanism to the pmic code in order to
get rid of the horrible work queue stuff, stupid me missed to add the
new callbacks to the irq_chip.

In consequence Andrew removed the unused functions, but I missed that.

Add them back and hook them up proper.

Signed-off-by: Thomas Gleixner 
Cc: Matthew Garrett 
Cc: Andrew Morton 
Signed-off-by: Matthew Garrett

drivers: Final irq namespace conversion

2011-03-29T12:48:19+00:00

Scripted with coccinelle.

Signed-off-by: Thomas Gleixner

platform-drivers: x86: pmic: Use request_irq instead of chained handler

2011-02-21T22:06:11+00:00

There is no need to install a chained handler for this hardware. This
is a plain x86 IOAPIC interrupt which is handled by the core code
perfectly fine. There is nothing special about demultiplexing these
gpio interrupts which justifies a custom hack. Replace it by a plain
old interrupt handler installed with request_irq. That makes the code
agnostic about the underlying primary interrupt hardware. The overhead
for this is minimal, but it gives us the advantage of accounting,
balancing and to detect interrupt storms. gpio interrupts are not
really that performance critical.

Patch fixups from akpm

Signed-off-by: Thomas Gleixner 
Signed-off-by: Matthew Garrett 
Signed-off-by: Andrew Morton

platform-drivers: x86: pmic: Use irq_chip buslock mechanism

2011-02-07T21:52:28+00:00

The set_type function of the pmic irq chip is a horrible hack. It
schedules work because it cannot access the scu chip from the set_type
function. That breaks the assumption, that the type is set after
set_type has returned.

irq_chips provide buslock functions to avoid the above. Convert the
driver to use the proper model.

Signed-off-by: Thomas Gleixner 
Cc: Feng Tang 
Cc: Matthew Garrett 
Cc: Alan Cox 
Cc: Alek Du 
Signed-off-by: Matthew Garrett

platform-drivers: x86: Convert pmic to new irq_chip functions

2011-02-07T21:52:22+00:00

Old functions will go away soon. Remove the stray semicolons while at
it.

Signed-off-by: Thomas Gleixner 
Cc: Feng Tang 
Cc: Matthew Garrett 
Cc: Alan Cox 
Cc: Alek Du 
Signed-off-by: Matthew Garrett

platform-drivers: x86: pmic: Fix up bogus irq hackery

2011-02-07T21:52:16+00:00

commit 456dc301([PATCH] intel_pmic_gpio: modify EOI handling following
change of kernel irq subsystem) changes

-	desc->chip->eoi(irq);
+
+	if (desc->chip->irq_eoi)
+		desc->chip->irq_eoi(irq_get_irq_data(irq));
+	else
+		dev_warn(pg->chip.dev, "missing EOI handler for irq %d\n", irq);

With the following explanation:

 "Latest kernel has many changes in IRQ subsystem and its interfaces,
  like adding irq_eoi" for struct irq_chip, this patch will make it
  support both the new and old interface."

This is completely bogus.

#1) The changelog does not match the patch at all

#2) This driver relies on the assumption that it sits behind an eoi
    capable interrupt line. If the implementation of the underlying
    chip changes from eoi to irq_eoi then this driver has to follow
    that change and not add a total bogosity.

Remove the sillyness and retrieve the interrupt data from irq_desc
directly. No need to got through circles to look it up.

Signed-off-by: Thomas Gleixner 
Cc: Feng Tang 
Cc: Matthew Garrett 
Cc: Alan Cox 
Cc: Alek Du 
Signed-off-by: Matthew Garrett

[PATCH] intel_pmic_gpio: modify EOI handling following change of kernel irq subsystem

2011-01-07T22:26:57+00:00

Latest kernel has many changes in IRQ subsystem and its interfaces, like adding
"irq_eoi" for struct irq_chip, this patch will make it support both the new
and old interface.

Cc: Alek Du 
Signed-off-by: Feng Tang 
Signed-off-by: Matthew Garrett

Remove duplicate includes from many files

2010-10-28T01:03:18+00:00

Signed-off-by: Zimny Lech 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds