linux-toradex.git/drivers/platform/x86/pmc_atom.c, branch v6.3-rc3

platform/x86: pmc_atom: Amend comment style and grammar

2022-08-25T14:23:52+00:00

The style of the comments is not uniform, make it so and fix
a few grammar issues. While at it, update Copyright years.

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20220801113734.36131-4-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Make terminator entry uniform

2022-08-25T14:23:52+00:00

Make terminator entry uniform by dropping:
 - trailing commas
 - anything inside curly braces

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20220801113734.36131-3-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Improve quirk message to be less cryptic

2022-08-25T14:23:52+00:00

Not everyone can get what "critclks" means in the message, improve
it to make less cryptic.

Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20220801113734.36131-2-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Fix SLP_TYPx bitfield mask

2022-08-25T14:23:52+00:00

On Intel hardware the SLP_TYPx bitfield occupies bits 10-12 as per ACPI
specification (see Table 4.13 "PM1 Control Registers Fixed Hardware
Feature Control Bits" for the details).

Fix the mask and other related definitions accordingly.

Fixes: 93e5eadd1f6e ("x86/platform: New Intel Atom SOC power management controller driver")
Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20220801113734.36131-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Match all Lex BayTrail boards with critclk_systems DMI table

2022-07-28T18:32:00+00:00

The critclk_systems[] DMI match table already contains 2 Lex BayTrail
boards and patches were just submitted to add 3 more entries for the
following models: 3I380NX, 3I380A, 3I380CW.

Looking at: https://www.lex.com.tw/products/embedded-ipc-board/
we can see that Lex BayTrail makes many embedded boards with
multiple ethernet boards and none of their products are battery
powered so we don't need to worry (too much) about power consumption
when suspended.

Add a new DMI match which simply matches all Lex BayTrail boards and drop
the 2 existing board specific quirks.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Reported-by: Michael Schöne 
Reported-by: Paul Spooren 
Reported-by: Matwey V. Kornilov 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: dont export pmc_atom_read - no modular users

2022-05-06T11:02:56+00:00

There is only one user of pmc_atom_read in tree, and that is in
drivers/acpi/acpi_lpss.c -- which can't be anything but built-in.

As such there is no point in adding this function to the global symbol
list exported to modules.

Note that there is no  include removal since the code
was getting that header implicitly.

Cc: Andy Shevchenko 
Cc: Aubrey Li 
Cc: Hans de Goede 
Cc: Mark Gross 
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Paul Gortmaker 
Link: https://lore.kernel.org/r/20220428062430.31010-4-paul.gortmaker@windriver.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: remove unused pmc_atom_write()

2022-05-06T11:02:56+00:00

This function isn't used anywhere in the driver or anywhere in tree.
So remove it.  It can always be re-added if/when a use arises.

Cc: Andy Shevchenko 
Cc: Aubrey Li 
Cc: Hans de Goede 
Cc: Mark Gross 
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Paul Gortmaker 
Link: https://lore.kernel.org/r/20220428062430.31010-2-paul.gortmaker@windriver.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-12-23T17:09:41+00:00

Siemens industrial PCs unfortunately can not always be properly
identified the way we used to. An earlier commit introduced code that
allows proper identification without looking at DMI strings that could
differ based on product branding.
Switch over to that proper way and revert commits that used to collect
the machines based on unstable strings.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Fixes: e8796c6c69d1 ("platform/x86: pmc_atom: Add Siemens CONNECT ...")
Fixes: f110d252ae79 ("platform/x86: pmc_atom: Add Siemens SIMATIC ...")
Fixes: ad0d315b4d4e ("platform/x86: pmc_atom: Add Siemens SIMATIC ...")
Tested-by: Michael Haener 
Signed-off-by: Henning Schild 
Link: https://lore.kernel.org/r/20211213120502.20661-5-henning.schild@siemens.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Match all Beckhoff Automation baytrail boards with critclk_systems DMI table

2021-04-14T13:52:37+00:00

pmc_plt_clk* clocks are used for ethernet controllers, so need to stay
turned on. This adds the affected board family to critclk_systems DMI
table, so the clocks are marked as CLK_CRITICAL and not turned off.

This replaces the previously listed boards with a match for the whole
device family CBxx63. CBxx63 matches only baytrail devices.
There are new affected boards that would otherwise need to be listed.
There are unaffected boards in the family, but having the clocks
turned on is not an issue.

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Reviewed-by: Andy Shevchenko 
Signed-off-by: Steffen Dirkwinkel 
Link: https://lore.kernel.org/r/20210412133006.397679-1-linux-kernel-dev@beckhoff.com
Signed-off-by: Hans de Goede

platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table

2020-02-10T15:47:38+00:00

The Lex 2I385SW board has two Intel I211 ethernet controllers. Without
this patch, only the first port is usable. The second port fails to
start with the following message:

    igb: probe of 0000:02:00.0 failed with error -2

Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
Tested-by: Georg Müller 
Signed-off-by: Georg Müller 
Reviewed-by: Hans de Goede 
Signed-off-by: Andy Shevchenko