linux-toradex.git/drivers/platform/x86/surface3_power.c, branch master Linux kernel for Apalis and Colibri modules platform/surface: Move Surface 3 Power OpRegion driver to platform/surface 2020-10-27T11:51:24+00:00 Maximilian Luz luzmaximilian@gmail.com 2020-10-09T14:11:27+00:00 85f7582cd484dbf491b6d9bb2af6ef1467a024d2 Move the Surface 3 Power operation region driver from platform/x86 to the newly created platform/surface directory. Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Link: https://lore.kernel.org/r/20201009141128.683254-5-luzmaximilian@gmail.com Signed-off-by: Hans de Goede <hdegoede@redhat.com> 
Move the Surface 3 Power operation region driver from platform/x86 to
the newly created platform/surface directory.

Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20201009141128.683254-5-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
platform/x86: surface3_power: Fix a NULL vs IS_ERR() check in probe 2020-04-17T13:47:26+00:00 Dan Carpenter dan.carpenter@oracle.com 2020-04-07T09:30:52+00:00 4dbccb873f2b35ad1b26419ff88c80509e2d4cbb The i2c_acpi_new_device() function never returns NULL, it returns error pointers. Fixes: b1f81b496b0d ("platform/x86: surface3_power: MSHW0011 rev-eng implementation") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
The i2c_acpi_new_device() function never returns NULL, it returns error
pointers.

Fixes: b1f81b496b0d ("platform/x86: surface3_power: MSHW0011 rev-eng implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Fix always true condition in mshw0011_space_handler() 2020-03-30T10:26:50+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-30T10:26:50+00:00 d878bdfba8ffda64265c921cf7497934a607f83a smatch warnings: .../surface3_power.c:417 mshw0011_space_handler() warn: always true condition '(ret >= 0) => +(0-u32max >= 0)' Refactor error handling returned by mshw0011_adp_psr() to avoid always true condition. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
smatch warnings:
.../surface3_power.c:417 mshw0011_space_handler() warn: always true condition '(ret >= 0) => +(0-u32max >= 0)'

Refactor error handling returned by mshw0011_adp_psr() to avoid always
true condition.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Add missed headers 2020-03-28T20:37:30+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-26T12:28:25+00:00 dd4a93569bd3656ec9fac364a28a61dde9f162a9 We obviously are users of bits.h and types.h. Add them to the list. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
We obviously are users of bits.h and types.h. Add them to the list.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Reformat GUID assignment 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-26T12:21:15+00:00 3d8fc115a3493ef782a2864c6a42b165cefb9871 For better readability reformat GUID assignment. While here, add the comment how this GUID looks in a string representation. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
For better readability reformat GUID assignment.
While here, add the comment how this GUID looks in a string representation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Drop useless macro ACPI_PTR() 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-26T12:13:19+00:00 f1f25fc89a28863766a9827907189ea75ef9215c Driver depends to ACPI, this marco always is evaluated to the parameter, thus useless. Drop it for good. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
Driver depends to ACPI, this marco always is evaluated to the parameter,
thus useless. Drop it for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Prefix POLL_INTERVAL with SURFACE_3 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-27T10:48:47+00:00 fcbb1142fea32fed1d944992f57033cf90d0fb4a For better namespace maintenance prefix POLL_INTERVAL macro with SURFACE_3. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
For better namespace maintenance prefix POLL_INTERVAL macro with SURFACE_3.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Simplify mshw0011_adp_psr() to one liner 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-26T14:05:56+00:00 48978995950b2ebbebdc47623fe55c75f1633e40 Refactor mshw0011_adp_psr() to be one liner. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
Refactor mshw0011_adp_psr() to be one liner.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Use dev_err() instead of pr_err() 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-26T12:19:45+00:00 74bef188eac103ecfeaf9cd48b86e12f2a2492af We have device and we may use it to print messages. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
We have device and we may use it to print messages.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
platform/x86: surface3_power: Drop unused structure definition 2020-03-28T20:37:29+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2020-03-27T10:45:34+00:00 c9c10913ea00111b7ce3304634e8131ec073495e As reported by kbuild bot the struct mshw0011_lookup in never used. Drop its definition for good. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
As reported by kbuild bot the struct mshw0011_lookup in never used.
Drop its definition for good.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>