<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux-toradex.git/drivers/platform, branch v2.6.29</title>
<subtitle>Linux kernel for Apalis and Colibri modules</subtitle>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/'/>
<entry>
<title>acpi-wmi: unsigned cannot be less than 0</title>
<updated>2009-03-16T04:38:24+00:00</updated>
<author>
<name>Roel Kluin</name>
<email>roel.kluin@gmail.com</email>
</author>
<published>2009-03-04T19:55:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=da511997d2bbc09f5e39385e0ed209578db07c91'/>
<id>da511997d2bbc09f5e39385e0ed209578db07c91</id>
<content type='text'>
include/linux/pci-acpi.h:74:

typedef u32                 acpi_status;

result is unsigned, so an error returned by acpi_bus_register_driver()
will not be noticed.

Signed-off-by: Roel Kluin &lt;roel.kluin@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
include/linux/pci-acpi.h:74:

typedef u32                 acpi_status;

result is unsigned, so an error returned by acpi_bus_register_driver()
will not be noticed.

Signed-off-by: Roel Kluin &lt;roel.kluin@gmail.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>thinkpad-acpi: fix module autoloading for older models</title>
<updated>2009-03-16T04:38:24+00:00</updated>
<author>
<name>Mathieu Chouquet-Stringer</name>
<email>mchouque@free.fr</email>
</author>
<published>2009-03-14T15:35:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=b36a50f92d1c4300a88f606b4d2bbdc4f442a2d7'/>
<id>b36a50f92d1c4300a88f606b4d2bbdc4f442a2d7</id>
<content type='text'>
Looking at the source, there seems to be a missing * to match my DMI
string.  I mean for newer IBM and Lenovo's laptops you match either one
of the following:
MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");

While for older Thinkpads, you do this (for instance):
IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");

with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")

Note there's no * terminating the string.  As result, udev doesn't load
anything because modprobe cannot find anything matching this (my
machine actually):

udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAv

Signed-off-by: Mathieu Chouquet-Stringer &lt;mchouque@free.fr&gt;
Acked-by: Henrique de Moraes Holschuh &lt;hmh@hmh.eng.br&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Looking at the source, there seems to be a missing * to match my DMI
string.  I mean for newer IBM and Lenovo's laptops you match either one
of the following:
MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*");
MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*");

While for older Thinkpads, you do this (for instance):
IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]");

with IBM_BIOS_MODULE_ALIAS being MODULE_ALIAS("dmi:bvnIBM:bvr" __type "ET??WW")

Note there's no * terminating the string.  As result, udev doesn't load
anything because modprobe cannot find anything matching this (my
machine actually):

udevtest: run: '/sbin/modprobe dmi:bvnIBM:bvr1IET71WW(2.10):bd06/16/2006:svnIBM:pn236621U:pvrNotAv

Signed-off-by: Mathieu Chouquet-Stringer &lt;mchouque@free.fr&gt;
Acked-by: Henrique de Moraes Holschuh &lt;hmh@hmh.eng.br&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>acer-wmi: Unmark as 'experimental'</title>
<updated>2009-03-16T04:38:23+00:00</updated>
<author>
<name>Carlos Corbacho</name>
<email>carlos@strangeworlds.co.uk</email>
</author>
<published>2009-02-14T09:53:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=54b1ec893e869c815d390afa42aacf1499858112'/>
<id>54b1ec893e869c815d390afa42aacf1499858112</id>
<content type='text'>
This driver has been around and used long enough that we can drop the
'experimental'.

Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This driver has been around and used long enough that we can drop the
'experimental'.

Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>acpi-wmi: Unmark as 'experimental'</title>
<updated>2009-03-16T04:38:08+00:00</updated>
<author>
<name>Carlos Corbacho</name>
<email>carlos@strangeworlds.co.uk</email>
</author>
<published>2009-02-14T09:53:53+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=5fcdd177d063f1d8d569d746ab1bf206b0dfb2e8'/>
<id>5fcdd177d063f1d8d569d746ab1bf206b0dfb2e8</id>
<content type='text'>
ACPI-WMI isn't experimental anymore, and there are other drivers that now
depend on it that aren't either.

Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
ACPI-WMI isn't experimental anymore, and there are other drivers that now
depend on it that aren't either.

Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>acer-wmi: double free in acer_rfkill_exit()</title>
<updated>2009-03-16T04:37:33+00:00</updated>
<author>
<name>Dan Carpenter</name>
<email>error27@gmail.com</email>
</author>
<published>2009-02-14T09:53:48+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=013d67fd4f0da8f6af60a376f1a254266ab658ef'/>
<id>013d67fd4f0da8f6af60a376f1a254266ab658ef</id>
<content type='text'>
This is acer_rfkill_exit() from drivers/platform/x86/acer-wmi.c.

The code frees wireless_rfkill-&gt;data again instead of
bluetooth_rfkill-&gt;data.

This was found using a code checker (http://repo.or.cz/w/smatch.git/).

Signed-off-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is acer_rfkill_exit() from drivers/platform/x86/acer-wmi.c.

The code frees wireless_rfkill-&gt;data again instead of
bluetooth_rfkill-&gt;data.

This was found using a code checker (http://repo.or.cz/w/smatch.git/).

Signed-off-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>platform/x86: depends instead of select for laptop platform drivers</title>
<updated>2009-03-16T04:37:32+00:00</updated>
<author>
<name>Corentin Chary</name>
<email>corentincj@iksaif.net</email>
</author>
<published>2009-02-25T08:37:09+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=d263da311ab403e3a84fa24920edc826147a550c'/>
<id>d263da311ab403e3a84fa24920edc826147a550c</id>
<content type='text'>
"I hate `select' and will gleefully leap on any s/select/depends/ patch,
whether it works or not :)"
  Andrew Morton

select INPUT is not needed here, because if someone doesn't want INPUT,
he won't want these drivers either.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"I hate `select' and will gleefully leap on any s/select/depends/ patch,
whether it works or not :)"
  Andrew Morton

select INPUT is not needed here, because if someone doesn't want INPUT,
he won't want these drivers either.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>asus-laptop: use select instead of depends on</title>
<updated>2009-03-16T04:37:32+00:00</updated>
<author>
<name>Corentin Chary</name>
<email>corentincj@iksaif.net</email>
</author>
<published>2009-02-15T18:30:21+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=e73e2c62f7646d54e30ef8863ac0be0b8e4ef0eb'/>
<id>e73e2c62f7646d54e30ef8863ac0be0b8e4ef0eb</id>
<content type='text'>
Like thinkpad_acpi or eeepc-laptop, asus-laptop will
now use "select" instead of "depends on"
for LEDS_CLASS, NEW_LEDS and BACKLIGHT_CLASS_DEVICE

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Like thinkpad_acpi or eeepc-laptop, asus-laptop will
now use "select" instead of "depends on"
for LEDS_CLASS, NEW_LEDS and BACKLIGHT_CLASS_DEVICE

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>eeepc-laptop: restore acpi_generate_proc_event()</title>
<updated>2009-03-16T04:37:31+00:00</updated>
<author>
<name>Corentin Chary</name>
<email>corentincj@iksaif.net</email>
</author>
<published>2009-02-15T18:30:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=7950b71c3bd7b27b2874088a6c4efe3e13579f8b'/>
<id>7950b71c3bd7b27b2874088a6c4efe3e13579f8b</id>
<content type='text'>
Restore acpi_generate_proc_event() for backward
compatibility with old acpi scripts.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Restore acpi_generate_proc_event() for backward
compatibility with old acpi scripts.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>asus-laptop: restore acpi_generate_proc_event()</title>
<updated>2009-03-16T04:37:31+00:00</updated>
<author>
<name>Corentin Chary</name>
<email>corentincj@iksaif.net</email>
</author>
<published>2009-02-15T18:30:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=6050c8dd70b21a9d927983aeb6357fecffa7fb23'/>
<id>6050c8dd70b21a9d927983aeb6357fecffa7fb23</id>
<content type='text'>
Restore acpi_generate_proc_event() for backward
compatibility with old acpi scripts.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Restore acpi_generate_proc_event() for backward
compatibility with old acpi scripts.

Signed-off-by: Corentin Chary &lt;corentincj@iksaif.net&gt;
Signed-off-by: Len Brown &lt;len.brown@intel.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>acer-wmi: fix regression in backlight detection</title>
<updated>2009-03-12T23:20:24+00:00</updated>
<author>
<name>Michael Spang</name>
<email>mspang@csclub.uwaterloo.ca</email>
</author>
<published>2009-03-12T21:31:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.toradex.cn/cgit/linux-toradex.git/commit/?id=1ba869ec581fd9078b684c56c399ffe3d2345e27'/>
<id>1ba869ec581fd9078b684c56c399ffe3d2345e27</id>
<content type='text'>
Currently we disable the Acer WMI backlight device if there is no ACPI
backlight device.  As a result, we end up with no backlight device at all.
 We should instead disable it if there is an ACPI device, as the other
laptop drivers do.  This regression was introduced in febf2d9 ("Acer-WMI:
fingers off backlight if video.ko is serving this functionality").

Each laptop driver with backlight support got a similar change around
febf2d9.  The changes to the other drivers look correct; see e.g.
a598c82f for a similar but correct change.  The regression is also in
2.6.28.

Signed-off-by: Michael Spang &lt;mspang@csclub.uwaterloo.ca&gt;
Acked-by: Thomas Renninger &lt;trenn@suse.de&gt;
Cc: Zhang Rui &lt;rui.zhang@intel.com&gt;
Cc: Andi Kleen &lt;ak@linux.intel.com&gt;
Cc: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Cc: Len Brown &lt;len.brown@intel.com&gt;
Cc: "Rafael J. Wysocki" &lt;rjw@sisk.pl&gt;
Cc: &lt;stable@kernel.org&gt;		[2.6.28.x]
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently we disable the Acer WMI backlight device if there is no ACPI
backlight device.  As a result, we end up with no backlight device at all.
 We should instead disable it if there is an ACPI device, as the other
laptop drivers do.  This regression was introduced in febf2d9 ("Acer-WMI:
fingers off backlight if video.ko is serving this functionality").

Each laptop driver with backlight support got a similar change around
febf2d9.  The changes to the other drivers look correct; see e.g.
a598c82f for a similar but correct change.  The regression is also in
2.6.28.

Signed-off-by: Michael Spang &lt;mspang@csclub.uwaterloo.ca&gt;
Acked-by: Thomas Renninger &lt;trenn@suse.de&gt;
Cc: Zhang Rui &lt;rui.zhang@intel.com&gt;
Cc: Andi Kleen &lt;ak@linux.intel.com&gt;
Cc: Carlos Corbacho &lt;carlos@strangeworlds.co.uk&gt;
Cc: Len Brown &lt;len.brown@intel.com&gt;
Cc: "Rafael J. Wysocki" &lt;rjw@sisk.pl&gt;
Cc: &lt;stable@kernel.org&gt;		[2.6.28.x]
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
