linux-toradex.git/drivers/pmdomain/rockchip, branch master

pmdomain: rockchip: drop duplicated errno from supply failure message

2026-09-28T13:38:26+00:00

dev_err_probe() already appends the error code.

Signed-off-by: Shawn Lin 
Reviewed-by: Sebastian Reichel 
Signed-off-by: Ulf Hansson

pmdomain: Merge branch fixes into next

2026-09-28T13:37:31+00:00

Merge the pmdomain fixes for v7.3-rc[n] into the next branch, to allow
them to get tested together with the pmdomain changes that are targeted
for the next release.

Signed-off-by: Ulf Hansson

pmdomain: rockchip: don't ignore clock lookup errors on attach

2026-09-28T13:36:50+00:00

rockchip_pd_attach_dev() treated every of_clk_get() error as the end
of the clock list, so a clock that exists but is not available yet
(e.g. -EPROBE_DEFER) was silently skipped and the device ended up
without pm_clk management.  Only -ENOENT means there are no more
clocks.

Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver")
Signed-off-by: Shawn Lin 
Reviewed-by: Sebastian Reichel 
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson

pmdomain: rockchip: fix clock leak on domain probe failure

2026-09-28T13:36:05+00:00

When of_clk_get() failed in the middle of the loop, the references of
the clocks acquired so far were leaked instead of being released by
the error path.

Fixes: d909072d0521 ("soc: rockchip: power-domain: use clk_bulk APIs")
Signed-off-by: Shawn Lin 
Reviewed-by: Sebastian Reichel 
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson

pmdomain: rockchip: propagate subdomain add errors

2026-09-28T13:35:21+00:00

rockchip_pm_add_subdomain() ignored the return value of its recursive
call, so a failure deeper in the hierarchy was silently dropped and
probe still succeeded with an incomplete domain tree.

Fixes: 6be05b5ec161 ("soc: rockchip: power-domain: add support for sub-power domains")
Signed-off-by: Shawn Lin 
Reviewed-by: Sebastian Reichel 
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson

pmdomain: rockchip: Fix domain check in rockchip_pm_add_one_domain()

2026-09-23T11:32:20+00:00

In rockchip_pm_add_one_domain(), there's the check (most probably for the
case where the "reg" prop has an unexpected value?) which doesn't make much
sense as the variable pd_info will be NULL iff pmu->info-> domain_info is
NULL and the variable id is 0.  What does make sense there is checking
pd_info->pwr_mask and pd_info->req_mask which can't both be 0 for a valid
domain.

Found by Linux Verification Center (linuxtesting.org) with the Svace
static analysis tool.

Signed-off-by: Sergey Shtylyov 
Reviewed-by: Shawn Lin 
Signed-off-by: Ulf Hansson

pmdomain: rockchip: Add a regulator to the RK3568 NPU power domain

2026-07-24T14:31:02+00:00

The RK3568 NPU rail (vdd_npu) needs to be enabled before the domain is
powered on and disabled after it is powered off. Give DOMAIN_RK3568 a
regulator parameter (like DOMAIN_RK3588 already has) so the NPU domain
can set need_regulator, letting genpd manage the rail wired up as the
domain's domain-supply instead of marking it always-on in DT.

Suggested-by: Chaoyi Chen 
Signed-off-by: Midgy BALON 
Reviewed-by: Sebastian Reichel 
Reviewed-by: Heiko Stuebner 
Signed-off-by: Ulf Hansson

pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER

2026-04-01T11:12:11+00:00

Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
to prevent errors early in the boot process when the requested
regulator is not yet available. This converts errors like the following
to debug messages:

rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517

Signed-off-by: Chris Morgan 
Tested-by: Diederik de Haas 
Reviewed-by: Anand Moon 
Reviewed-by: Shawn Lin 
Signed-off-by: Ulf Hansson

pmdomain: rockchip: Fix PD_VCODEC for RK3588

2026-03-04T10:22:36+00:00

>From the RK3588 TRM Table 7-1 RK3588 Voltage Domain and Power Domain Summary,
PD_RKVDEC0/1 and PD_VENC0/1 rely on VD_VCODEC which require extra voltages to
be applied, otherwise it breaks RK3588-evb1-v10 board after vdec support landed[1].
The panic looks like below:

  rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'rkvdec0' on, val=0
  rockchip-pm-domain fd8d8000.power-management:power-controller: failed to set domain 'rkvdec1' on, val=0
  ...
  Hardware name: Rockchip RK3588S EVB1 V10 Board (DT)
  Workqueue: pm genpd_power_off_work_fn
  Call trace:
  show_stack+0x18/0x24 (C)
  dump_stack_lvl+0x40/0x84
  dump_stack+0x18/0x24
  vpanic+0x1ec/0x4fc
  vpanic+0x0/0x4fc
  check_panic_on_warn+0x0/0x94
  arm64_serror_panic+0x6c/0x78
  do_serror+0xc4/0xcc
  el1h_64_error_handler+0x3c/0x5c
  el1h_64_error+0x6c/0x70
  regmap_mmio_read32le+0x18/0x24 (P)
  regmap_bus_reg_read+0xfc/0x130
  regmap_read+0x188/0x1ac
  regmap_read+0x54/0x78
  rockchip_pd_power+0xcc/0x5f0
  rockchip_pd_power_off+0x1c/0x4c
  genpd_power_off+0x84/0x120
  genpd_power_off+0x1b4/0x260
  genpd_power_off_work_fn+0x38/0x58
  process_scheduled_works+0x194/0x2c4
  worker_thread+0x2ac/0x3d8
  kthread+0x104/0x124
  ret_from_fork+0x10/0x20
  SMP: stopping secondary CPUs
  Kernel Offset: disabled
  CPU features: 0x3000000,000e0005,40230521,0400720b
  Memory Limit: none
  ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]---

Chaoyi pointed out the PD_VCODEC is the parent of PD_RKVDEC0/1 and PD_VENC0/1, so checking
the PD_VCODEC is enough.

[1] https://lore.kernel.org/linux-rockchip/20251020212009.8852-2-detlev.casanova@collabora.com/

Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Cc: stable@vger.kernel.org
Suggested-by: Chaoyi Chen 
Signed-off-by: Shawn Lin 
Reviewed-by: Chaoyi Chen 
Reviewed-by: Sebastian Reichel 
Signed-off-by: Ulf Hansson

pmdomain:rockchip: Fix init genpd as GENPD_STATE_ON before regulator ready

2026-01-15T12:39:16+00:00

RK3588_PD_NPU initialize as GENPD_STATE_ON before regulator ready.
rknn_iommu initlized success and suspend RK3588_PD_NPU. When rocket
driver register, it will resume rknn_iommu.

If regulator is still not ready at this point, rknn_iommu resume fail,
pm runtime status will be error: -EPROBE_DEFER.

This patch set pmdomain to off if it need regulator during probe,
consumer device can power on pmdomain after regulator ready.

Signed-off-by: Frank Zhang 
Tested-by: Chaoyi Chen 
Tested-by: Quentin Schulz 
Reviewed-by: Sebastian Reichel 
Fixes: db6df2e3fc16 ("pmdomain: rockchip: add regulator support")
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson