linux-toradex.git/drivers/rapidio/rio-scan.c, branch v3.4.1

RapidIO: fix potential null deref in rio_setup_device()

2011-11-02T23:07:01+00:00

The "goto cleanup" path can deference "rswitch" when it is NULL.

Reported-by: Dan Carpenter 
Signed-off-by: Alexandre Bounine 
Cc: Dan Carpenter 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Chul Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rapidio/rio-scan.c: use discovered bit to test if enumeration is complete

2011-11-02T23:07:01+00:00

The discovered bit in PGCCSR register indicates if the device has been
discovered by system host.  In Rapidio systems, some agent devices can also
be master devices.  They can issue requests into the system.

Signed-off-by: Liu Gang 
Acked-by: Alexandre Bounine 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: fix use of non-compatible registers

2011-08-25T23:25:34+00:00

Replace/remove use of RIO v.1.2 registers/bits that are not
forward-compatible with newer versions of RapidIO specification.

RapidIO specification v.1.3 removed Write Port CSR, Doorbell CSR,
Mailbox CSR and Mailbox and Doorbell bits of the PEF CAR.

Use of removed (since RIO v.1.3) register bits affects users of
currently available 1.3 and 2.x compliant devices who may use not so
recent kernel versions.

Removing checks for unsupported bits makes corresponding routines
compatible with all versions of RapidIO specification.  Therefore,
backporting makes stable kernel versions compliant with RIO v.1.3 and
later as well.

Signed-off-by: Alexandre Bounine 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Thomas Moll 
Cc: Chul Kim 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

rapidio: fix potential null deref on failure path

2011-03-24T02:46:44+00:00

If rio is not a switch then "rswitch" is null.

Signed-off-by: Dan Carpenter 
Cc: Matt Porter 
Cc: Kumar Gala 
Signed-off-by: Alexandre Bounine 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: fix new kernel-doc warnings

2011-01-23T04:32:37+00:00

Fix new rapidio kernel-doc warnings:

  Warning(drivers/rapidio/rio-scan.c:953): No description found for parameter 'prev'
  Warning(drivers/rapidio/rio-scan.c:953): No description found for parameter 'prev_port'

Signed-off-by: Randy Dunlap 
Cc: Alexandre Bounine 
Cc: Matt Porter 
Signed-off-by: Linus Torvalds

rapidio: use Component Tag for unified switch identification

2011-01-13T16:03:18+00:00

Change the way how switchid value is set.  Local counter variable does not
provide unified way to identify switch devices in a system with multiple
processors.  Using local counter leads to the situation when the same RIO
switch has different switch ID for each processor.  Replacing local
counter with unique portion of the Component Tag provides unified
reference to the switch by every processor in the system.

Signed-off-by: Alexandre Bounine 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Thomas Moll 
Cc: Micha Nelissen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: add device object linking into discovery

2011-01-13T16:03:18+00:00

Add setting links between rio_dev objects into the discovery process.
This needed to report device connections on agent (non-host) processors
that perform RIO discovery.  Originally, these links have been introduced
for enumerating host only to support error management.

Signed-off-by: Alexandre Bounine 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Thomas Moll 
Cc: Micha Nelissen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: integrate rio_switch into rio_dev

2011-01-13T16:03:17+00:00

Convert RIO switches device structures (rio_dev + rio_switch) into a
single allocation unit.

This change is based on the fact that RIO switches are using common RIO
device objects anyway.  Allocating RIO switch objects as RIO devices with
added space for switch information simplifies handling of RIO switch
devices.

Signed-off-by: Alexandre Bounine 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Thomas Moll 
Cc: Micha Nelissen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: use common destid storage for endpoints and switches

2011-01-13T16:03:17+00:00

Change code to use one storage location common for switches and endpoints.
This eliminates unnecessary device type checks during basic access
operations.  Logic that assigns destid to RIO devices stays unchanged - as
before, switches use an associated destid because they do not have their
own.

Signed-off-by: Alexandre Bounine 
Cc: Kumar Gala 
Cc: Matt Porter 
Cc: Li Yang 
Cc: Thomas Moll 
Cc: Micha Nelissen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds