linux-toradex.git/drivers/rapidio, branch v5.14

rapidio: handle create_workqueue() failure

2021-05-13T16:32:19+00:00

In case create_workqueue() fails, release all resources and return -ENOMEM
to caller to avoid potential NULL pointer deref later. Move up the
create_workequeue() call to return early and avoid unwinding the call to
riocm_rx_fill().

Cc: Alexandre Bounine 
Cc: Matt Porter 
Cc: Andrew Morton 
Cc: Linus Torvalds 
Cc: stable 
Signed-off-by: Anirudh Rayabharam 
Link: https://lore.kernel.org/r/20210503115736.2104747-46-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

Revert "rapidio: fix a NULL pointer dereference when create_workqueue() fails"

2021-05-13T16:32:17+00:00

This reverts commit 23015b22e47c5409620b1726a677d69e5cd032ba.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit has a memory leak on the error path here, it does
not clean up everything properly.

Cc: Kangjie Lu 
Cc: Alexandre Bounine 
Cc: Matt Porter 
Cc: Andrew Morton 
Cc: Linus Torvalds 
Fixes: 23015b22e47c ("rapidio: fix a NULL pointer dereference when create_workqueue() fails")
Cc: stable 
Link: https://lore.kernel.org/r/20210503115736.2104747-45-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

rapidio: fix kernel-doc a markup

2021-01-21T21:06:00+00:00

Probaly this was due to a cut and paste issue.

Signed-off-by: Mauro Carvalho Chehab 
Link: https://lore.kernel.org/r/e23e64983788a51dd9099e2b0d881e1f64ecbc5b.1610610937.git.mchehab+huawei@kernel.org
Signed-off-by: Jonathan Corbet

rapidio: remove unused rio_get_asm() and rio_get_device()

2020-12-16T06:46:18+00:00

The functions rio_get_asm() and rio_get_device() are globally exported
but have almost no users in tree. The only user is rio_init_mports()
which invokes it via rio_init().

rio_init() iterates over every registered device and invokes
rio_fixup_device().  It looks like a fixup function which should perform a
"change" to the device but does nothing.  It has been like this since its
introduction in commit 394b701ce4fbf ("[PATCH] RapidIO support: core
base") which was merged into v2.6.15-rc1.

Remove rio_init() because the performed fixup function
(rio_fixup_device()) does nothing.  Remove rio_get_asm() and
rio_get_device() which have no callers now.

Link: https://lkml.kernel.org/r/20201116170004.420143-1-bigeasy@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rapidio: fix the missed put_device() for rio_mport_add_riodev

2020-10-16T18:11:22+00:00

rio_mport_add_riodev() misses to call put_device() when the device already
exists.  Add the missed function call to fix it.

Fixes: e8de370188d0 ("rapidio: add mport char device driver")
Signed-off-by: Jing Xiangfeng 
Signed-off-by: Andrew Morton 
Reviewed-by: Dan Carpenter 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Cc: Gustavo A. R. Silva 
Cc: John Hubbard 
Cc: Kees Cook 
Cc: Madhuparna Bhowmik 
Link: https://lkml.kernel.org/r/20200922072525.42330-1-jingxiangfeng@huawei.com
Signed-off-by: Linus Torvalds

rapidio: fix error handling path

2020-10-16T18:11:22+00:00

rio_dma_transfer() attempts to clamp the return value of
pin_user_pages_fast() to be >= 0.  However, the attempt fails because
nr_pages is overridden a few lines later, and restored to the undesirable
-ERRNO value.

The return value is ultimately stored in nr_pages, which in turn is passed
to unpin_user_pages(), which expects nr_pages >= 0, else, disaster.

Fix this by fixing the nesting of the assignment to nr_pages: nr_pages
should be clamped to zero if pin_user_pages_fast() returns -ERRNO, or set
to the return value of pin_user_pages_fast(), otherwise.

[jhubbard@nvidia.com: new changelog]

Fixes: e8de370188d09 ("rapidio: add mport char device driver")
Signed-off-by: Souptick Joarder 
Signed-off-by: Andrew Morton 
Reviewed-by: Ira Weiny 
Reviewed-by: John Hubbard 
Cc: Matthew Wilcox 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Cc: Gustavo A. R. Silva 
Cc: Madhuparna Bhowmik 
Cc: Dan Carpenter 
Link: https://lkml.kernel.org/r/1600227737-20785-1-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Linus Torvalds

rapidio: Replace 'select' DMAENGINES 'with depends on'

2020-09-05T16:52:54+00:00

Enabling a whole subsystem from a single driver 'select' is frowned
upon and won't be accepted in new drivers, that need to use 'depends on'
instead. Existing selection of DMAENGINES will then cause circular
dependencies. Replace them with a dependency.

Signed-off-by: Laurent Pinchart 
Acked-by: Randy Dunlap

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

rapidio/rio_mport_cdev: use array_size() helper in copy_{from,to}_user()

2020-08-12T17:58:01+00:00

Use array_size() helper instead of the open-coded version in
copy_{from,to}_user().  These sorts of multiplication factors need to be
wrapped in array_size().

This issue was found with the help of Coccinelle and, audited and fixed
manually.

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Andrew Morton 
Reviewed-by: Kees Cook 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Link: http://lkml.kernel.org/r/20200616183050.GA31840@embeddedor
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by: Linus Torvalds

drivers/rapidio/rio-scan.c: use struct_size() helper

2020-08-12T17:58:01+00:00

Make use of the struct_size() helper instead of an open-coded version in
order to avoid any potential type mistakes.

Also, while there, use the preferred form for passing a size of a struct.
The alternative form where struct name is spelled out hurts readability
and introduces an opportunity for a bug when the pointer variable type is
changed but the corresponding sizeof that is passed as argument is not.

This issue was found with the help of Coccinelle and, audited and fixed
manually.

Addresses KSPP ID: https://github.com/KSPP/linux/issues/83

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Andrew Morton 
Cc: Matt Porter 
Cc: Alexandre Bounine 
Link: http://lkml.kernel.org/r/20200619170445.GA22641@embeddedor
Signed-off-by: Linus Torvalds