linux-toradex.git/drivers/ras, branch toradex_5.3.y

RAS: Build debugfs.o only when enabled in Kconfig

2019-10-05T13:11:37+00:00

[ Upstream commit b6ff24f7b5101101ff897dfdde3f37924e676bc2 ]

In addition, the 0day bot reported this build error:

  >> drivers/ras/debugfs.c:10:5: error: redefinition of 'ras_userspace_consumers'
      int ras_userspace_consumers(void)
          ^~~~~~~~~~~~~~~~~~~~~~~
     In file included from drivers/ras/debugfs.c:3:0:
     include/linux/ras.h:14:19: note: previous definition of 'ras_userspace_consumers' was here
      static inline int ras_userspace_consumers(void) { return 0; }
                      ^~~~~~~~~~~~~~~~~~~~~~~

for a riscv-specific .config where CONFIG_DEBUG_FS is not set. Fix all
that by making debugfs.o depend on that define.

 [ bp: Rewrite commit message. ]

Reported-by: kbuild test robot 
Signed-off-by: Valdis Kletnieks 
Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac@vger.kernel.org
Cc: x86@kernel.org
Link: http://lkml.kernel.org/r/7053.1565218556@turing-police
Signed-off-by: Sasha Levin

RAS/CEC: Add copyright

2019-06-08T15:40:28+00:00

Signed-off-by: Borislav Petkov

RAS/CEC: Add CONFIG_RAS_CEC_DEBUG and move CEC debug features there

2019-06-08T15:39:24+00:00

The pfn and array files in (debugfs)/ras/cec are intended for debugging
the CEC code itself. They are not needed on production systems, so the
default setting for this CONFIG option is "n".

 [ bp: Have it with less ifdeffery by using IS_ENABLED(). ]

Signed-off-by: Tony Luck 
Signed-off-by: Borislav Petkov

RAS/CEC: Dump the different array element sections

2019-06-08T15:39:11+00:00

When dumping the array elements, print them in the following format:

  [ PFN | generation in binary | count ]

to be perfectly clear what all those sections are.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac

RAS/CEC: Rename count_threshold to action_threshold

2019-06-08T15:38:17+00:00

... which is the better, more-fitting name anyway.

Tony:
 - make action_threshold u64 due to debugfs accessors expecting u64.
 - rename the remaining: s/count_threshold/action_threshold/g

Co-developed-by: Tony Luck 
Signed-off-by: Tony Luck 
Signed-off-by: Borislav Petkov 
Cc: linux-edac

RAS/CEC: Sanity-check array on every insertion

2019-06-08T15:35:34+00:00

Check the elements order in the array after every insertion.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac

RAS/CEC: Fix potential memory leak

2019-06-08T15:35:04+00:00

Free the array page if a failure is encountered while creating the
debugfs nodes.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac

RAS/CEC: Do not set decay value on error

2019-06-08T15:34:36+00:00

When the value requested doesn't match the allowed (min,max) range,
the @data buffer should not be modified with the invalid value because
reading "decay_interval" shows it otherwise as if the previous write
succeeded.

Move the data write after the check.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac

RAS/CEC: Check count_threshold unconditionally

2019-06-08T15:33:10+00:00

The count_threshold should be checked unconditionally, after insertion
too, so that a count_threshold value of 1 can cause an immediate
offlining. I.e., offline the page on the *first* error encountered.

Add comments to make it clear what cec_add_elem() does, while at it.

Reported-by: WANG Chao 
Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac@vger.kernel.org
Link: https://lkml.kernel.org/r/20190418034115.75954-3-chao.wang@ucloud.cn

RAS/CEC: Fix pfn insertion

2019-06-08T15:32:00+00:00

When inserting random PFNs for debugging the CEC through
(debugfs)/ras/cec/pfn, depending on the return value of pfn_set(),
multiple values get inserted per a single write.

That is because simple_attr_write() interprets a retval of 0 as
success and claims the whole input. However, pfn_set() returns the
cec_add_elem() value, which, if > 0 and smaller than the whole input
length, makes glibc continue issuing the write syscall until there's
input left:

  pfn_set
  simple_attr_write
  debugfs_attr_write
  full_proxy_write
  vfs_write
  ksys_write
  do_syscall_64
  entry_SYSCALL_64_after_hwframe

leading to those repeated calls.

Return 0 to fix that.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac