linux-toradex.git/drivers/regulator/ab8500.c, branch v3.10.11

regulator: ab8500: Get rid of voltage_shift field from struct ab8500_regulator_info

2013-04-18T17:26:35+00:00

The voltage_shift can be calculated from voltage_mask.
Let's remove voltage_shift fied from struct ab8500_regulator_info, this change
can prevent missing voltage_shift setting issue.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Remove unused voltage_shift field from struct expand_register

2013-04-18T17:26:30+00:00

The voltage_shift field of struct expand_register is not used now, remove it.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Fix set voltage for AB8540_LDO_AUX3

2013-04-17T14:09:27+00:00

When setting voltage for AB8540_LDO_AUX3, current code only updates one of
info->voltage_reg and info->expand_register registers which is wrong.
To ensure we set to correct voltage, it always needs to clear or set
expand_register.voltage_mask bit of expand_register.

The function of the expand register bit is the following (from the user manual):
0: VAUX3 output voltage is determined by Vaux3Sel bit settings in register
   VldoCVaux3Sel
1: VAUX3 output voltage is set to 3.05V regardless of Vaux3Sel settings in
   register VldoCVaux3Sel (VldoCVaux3Sel is the register at 0x0421)

So when going to 3.05V, set the expand register bit.
When leaving 3.05V for another voltage, set the target voltage before clearing
the expand register bit.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Don't update lp_mode_req flag in set_mode() error paths

2013-04-17T14:08:27+00:00

Currently, set invalid mode setting for shared mode regulators may change
sm->lp_mode_req flag. This patch ensures we don't set lp_mode_req flag to wrong
status if set_mode() fails.

This patch includes some clean up, and these changes makes this patch looks like
code refactor. The clean up is mainly to avoid adding ugly code to handle
failure paths.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Don't update info->update_val if write to register fails

2013-04-17T14:08:22+00:00

This patch ensures info->update_val is consistent with current register value.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Optimize ab8540_aux3_regulator_get_voltage_sel

2013-04-16T11:23:27+00:00

We can save a register read operation in some case if read
expand_register first.
If info->expand_register.voltage_mask bit is set, no need to read
voltage_reg.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15T15:54:25+00:00

The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct
selector in get_voltage_sel and set_voltage_sel.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO

2013-04-12T12:29:33+00:00

The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched.
It looks like a typo in the voltage_mask settings.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500: Unregister ab8500-ext regulators in probe() failure path

2013-04-11T16:43:56+00:00

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown

regulator: ab8500-ext: Make the return type of ab8500_ext_regulator_exit() void

2013-04-11T16:43:50+00:00

ab8500_ext_regulator_exit() never fails.

Signed-off-by: Axel Lin 
Acked-by: Bengt Jonsson 
Signed-off-by: Mark Brown