linux-toradex.git/drivers/regulator/core.c, branch v3.5.7

regulator: Fix recursive mutex lockdep warning

2012-07-03T19:25:58+00:00

A recursive lockdep warning occurs if you call
regulator_set_optimum_mode() on a regulator with a supply because
there is no nesting annotation for the rdev->mutex. To avoid this
warning, get the supply's load before locking the regulator's
mutex to avoid grabbing the same class of lock twice.

=============================================
[ INFO: possible recursive locking detected ]
3.4.0 #3257 Tainted: G        W
---------------------------------------------
swapper/0/1 is trying to acquire lock:
 (&rdev->mutex){+.+.+.}, at: [] regulator_get_voltage+0x18/0x38

but task is already holding lock:
 (&rdev->mutex){+.+.+.}, at: [] regulator_set_optimum_mode+0x24/0x224

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&rdev->mutex);
  lock(&rdev->mutex);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

3 locks held by swapper/0/1:
 #0:  (&__lockdep_no_validate__){......}, at: [] __driver_attach+0x40/0x8c
 #1:  (&__lockdep_no_validate__){......}, at: [] __driver_attach+0x50/0x8c
 #2:  (&rdev->mutex){+.+.+.}, at: [] regulator_set_optimum_mode+0x24/0x224

stack backtrace:
[] (unwind_backtrace+0x0/0x12c) from [] (validate_chain+0x760/0x1080)
[] (validate_chain+0x760/0x1080) from [] (__lock_acquire+0x950/0xa10)
[] (__lock_acquire+0x950/0xa10) from [] (lock_acquire+0x18c/0x1e8)
[] (lock_acquire+0x18c/0x1e8) from [] (mutex_lock_nested+0x68/0x3c4)
[] (mutex_lock_nested+0x68/0x3c4) from [] (regulator_get_voltage+0x18/0x38)
[] (regulator_get_voltage+0x18/0x38) from [] (regulator_set_optimum_mode+0xa4/0x224)
...

Signed-off-by: Stephen Boyd 
Signed-off-by: Mark Brown

regulator: core: Properly handle the case min_uV < rdev->desc->min_uV in map_voltage_linear

2012-06-07T23:15:55+00:00

Properly handle the case if the specified min_uV is less than the voltage given
by the lowest selector.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown

Merge tag 'regulator-3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator

2012-05-21T23:49:16+00:00

Pull regulator updates from Mark Brown:
 "The major thing here is the addition of some helpers to factor code
  out of drivers, making a fair proportion of regulators much more just
  data rather than code which is nice.

  - Helpers in the core for regulators using regmap, providing generic
    implementations of the enable and voltage selection operations which
    just need data to describe them in the drivers.
  - Split out voltage mapping and voltage setting, allowing many more
    drivers to take advantage of the infrastructure for selectors.
  - Loads and loads of cleanups from Axel Lin once again, including many
    changes to take advantage of the above new framework features
  - New drivers for Ricoh RC5T583, TI TPS62362, TI TPS62363, TI
    TPS65913, TI TWL6035 and TI TWL6037.

  Some of the registration changes to support the core refactoring
  caused so many conflicts that eventually topic branches were abandoned
  for this release."

* tag 'regulator-3.5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator: (227 commits)
  regulator: tps65910: use of_node of matched regulator being register
  regulator: tps65910: dt: support when "regulators" node found
  regulator: tps65910: add error message in case of failure
  regulator: tps62360: dt: initialize of_node param for regulator register.
  regulator: tps65910: use devm_* for memory allocation
  regulator: tps65910: use small letter for regulator names
  mfd: tpx6586x:  Depend on regulator
  regulator: regulator for Palmas Kconfig
  regulator: regulator driver for Palmas series chips
  regulator: Enable Device Tree for the db8500-prcmu regulator driver
  regulator: db8500-prcmu: Separate regulator registration from probe
  regulator: ab3100: Use regulator_map_voltage_iterate()
  regulator: tps65217: Convert to set_voltage_sel and map_voltage
  regulator: Enable the ab8500 for Device Tree
  regulator: ab8500: Split up probe() into manageable pieces
  regulator: max8925: Remove check_range function and max_uV from struct rc5t583_regulator_info
  regulator: max8649: Remove unused check_range() function
  regulator: rc5t583: Remove max_uV from struct rc5t583_regulator_info
  regulator: da9052: Convert to set_voltage_sel and map_voltage
  regulator: max8952: Use devm_kzalloc
  ...

regulator: core: Don't open code _regulator_is_enabled()

2012-05-14T14:25:19+00:00

Signed-off-by: Mark Brown 
Acked-by: Liam Girdwood

regulator: core: Release regulator-regulator supplies on error

2012-05-14T08:31:35+00:00

If we fail while registering a regulator make sure we release the supply
for the regulator if there is one.

Signed-off-by: Mark Brown 
Acked-by: Liam Girdwood 
Cc: stable@vger.kernel.org

regulator: core: Ensure simple linear voltage mappings falls within the specified range

2012-05-14T08:11:34+00:00

Integer division may truncate the result.
Use DIV_ROUND_UP to ensure simple linear voltage mappings falls within the
specified range.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown

regulator: core: Allow drivers to set simple linear voltage maps as data

2012-05-12T10:11:32+00:00

A lot of regulator hardware maps selectors on to voltages with a simple
linear mapping function

    selector = base + (selector * step size)

Provide off the shelf list_voltage() and map_voltage() operations which
use new min_uV and uV_step members in the regulator_desc to implement
this function.

Signed-off-by: Mark Brown 
Acked-by: Liam Girdwood

regulator: core: Allow regulators to provide a voltage to selector mapping

2012-05-12T10:11:23+00:00

In order to allow more drivers to factor things out into data allow
drivers to provide a mapping function to convert voltages into selectors.
This allows any driver to use set_voltage_sel(). The existing mapping
based on iterating over list_voltage() is provided as an operation which
can be assigned to the new map_voltage() function though for ease of
transition it is treated as the default.

Signed-off-by: Mark Brown 
Acked-by: Liam Girdwood

Merge remote-tracking branches 'regulator/topic/core', 'regulator/topic/regmap' and 'regulator/topic/register' into regulator-next

2012-05-12T10:09:47+00:00

regulator: core: Warn on missing struct device

2012-05-10T09:48:37+00:00

The core really wants a struct device to be supplied for regulators and
there's no reason this should be impossible so provide one so complain
if we didn't get one.

Signed-off-by: Mark Brown 
Acked-by: Liam Girdwood