linux-toradex.git/drivers/regulator/max8907-regulator.c, branch v3.10.69

regulator: Add missing of_node_put()

2013-01-30T10:50:27+00:00

of_find_node_by_name() returns a node pointer with refcount incremented, use
of_node_put() on it when done.

of_find_node_by_name() will call of_node_put() against from parameter,
thus we also need to call of_node_get(from) before calling
of_find_node_by_name().

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown

regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-27T02:53:03+00:00

The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin 
Reviewed-by: Stephen Warren 
Signed-off-by: Mark Brown

regulator: remove use of __devexit

2012-11-20T01:53:38+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Mark Brown

regulator: remove use of __devinit

2012-11-20T01:31:26+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Mark Brown

regulator: remove use of __devexit_p

2012-11-20T01:31:19+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Signed-off-by: Mark Brown

regulator: max8907: Add MODULE_ALIAS

2012-08-28T18:00:30+00:00

This driver can be built as a module, add MODULE_ALIAS for it.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown

regulator: max8907: fix use of possibly NULL idata

2012-08-28T18:00:30+00:00

If a regulator is not used by a board, it's quite legitimate not to
provide platform data or a device tree node to configure it (i.e.
regulator_init_data). In that case, during MAX8907 regulator's
probe(), the idata variable will be NULL for that regulator. Prevent
dereferincing it.

If the MBATT regulator's init_data is not specified, or no name was
specified in the constraints, the regulator will be named based on
the regulator descriptor, so initialize mbatt_rail_name from there.

Signed-off-by: Stephen Warren 
Signed-off-by: Mark Brown

regulator: max8907: fix compile error when !CONFIG_OF

2012-08-28T18:00:29+00:00

Fix the following:

  CC [M]  drivers/regulator/max8907-regulator.o
drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_probe':
drivers/regulator/max8907-regulator.c:297:12: error: 'max8907_matches' undeclared (first use in this function)

by removing direct references to max8907_matches[], which only exists when
CONFIG_OF is defined.

Signed-off-by: Stephen Warren 
Signed-off-by: Mark Brown

regulator: max8907: Properly set pmic pointer in max8907_regulator_remove()

2012-08-28T18:00:29+00:00

Add missing platform_get_drvdata() call in max8907_regulator_remove(), this
fixes below build warning:

  CC [M]  drivers/regulator/max8907-regulator.o
drivers/regulator/max8907-regulator.c: In function 'max8907_regulator_remove':
drivers/regulator/max8907-regulator.c:353:23: warning: 'pmic' is used uninitialized in this function [-Wuninitialized]

Signed-off-by: Axel Lin 
Acked-by: Stephen Warren 
Signed-off-by: Mark Brown

regulator: max8907: Fix n_voltages for MAX8907B SD1

2012-08-28T18:00:28+00:00

For linear voltage mapping, the n_voltages is (max - min) / step + 1

Signed-off-by: Axel Lin 
Acked-by: Stephen Warren 
Signed-off-by: Mark Brown