linux-toradex.git/drivers/regulator/max8907-regulator.c, branch v4.1.18 Linux kernel for Apalis and Colibri modules regulator: drop owner assignment from platform_drivers 2014-10-20T14:21:29+00:00 Wolfram Sang wsa@the-dreams.de 2014-10-20T14:21:29+00:00 6c794b2654555d6af7572e3a8f13b2b39126df0c A platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> 
A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
regulator: remove unnecessary of_node_get() to parent 2014-09-10T10:35:02+00:00 Guodong Xu guodong.xu@linaro.org 2014-09-10T03:50:39+00:00 b8b27a44ddf1987e9bae84b99741b0a61192e017 These of_node_get() were added to balance refcount decrements inside of of_find_node_by_name(). See: commit c92f5dd2c42f ("regulator: Add missing of_node_put()") However of_find_node_by_name() was then replaced by of_get_child_by_name(), which doesn't call of_node_put() against its input parameter. So, need to remove these unnecessary of_node_get() calls. Signed-off-by: Guodong Xu <guodong.xu@linaro.org> Reviewed-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
These of_node_get() were added to balance refcount decrements inside of
of_find_node_by_name().
See: commit c92f5dd2c42f ("regulator: Add missing of_node_put()")

However of_find_node_by_name() was then replaced by of_get_child_by_name(),
which doesn't call of_node_put() against its input parameter.

So, need to remove these unnecessary of_node_get() calls.

Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: max8907: Remove regulator_dev array from state container 2014-03-10T09:34:59+00:00 Krzysztof Kozlowski k.kozlowski@samsung.com 2014-03-10T08:32:48+00:00 f991525a1acc641a21ece236649ceebfdf2c294d Don't store array of regulator_dev returned by devm_regulator_register() in state container. It isn't used anywhere outside of max8907_regulator_probe() function. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org> 
Don't store array of regulator_dev returned by devm_regulator_register()
in state container. It isn't used anywhere outside of
max8907_regulator_probe() function.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8907: Remove redundant error message 2014-02-20T11:23:18+00:00 Sachin Kamat sachin.kamat@linaro.org 2014-02-20T08:53:07+00:00 d016bdc7f4e8b2848d8992f99e226f03abe53716 kzalloc prints its own OOM message upon failure. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
kzalloc prints its own OOM message upon failure.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8907: Use of_get_child_by_name 2014-02-14T21:10:05+00:00 Sachin Kamat sachin.kamat@linaro.org 2014-02-14T11:49:50+00:00 c61f1401391c4735490ebc04a07d1386787bbf49 of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8907-regulator: Use devm_regulator_register 2013-09-16T23:28:41+00:00 Sachin Kamat sachin.kamat@linaro.org 2013-09-04T05:37:59+00:00 5ecdf140f21c50c08be34a83b44f28722813366c devm_* simplifies the code. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
devm_* simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: Add missing of_node_put() 2013-01-30T10:50:27+00:00 Axel Lin axel.lin@ingics.com 2013-01-27T13:16:56+00:00 c92f5dd2c42fa61e0ef810fad4584b184ea2d50e of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. of_find_node_by_name() will call of_node_put() against from parameter, thus we also need to call of_node_get(from) before calling of_find_node_by_name(). Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
of_find_node_by_name() returns a node pointer with refcount incremented, use
of_node_put() on it when done.

of_find_node_by_name() will call of_node_put() against from parameter,
thus we also need to call of_node_get(from) before calling
of_find_node_by_name().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
regulator: max8907: Fix using wrong dev argument for calling of_regulator_match 2013-01-27T02:53:03+00:00 Axel Lin axel.lin@ingics.com 2013-01-25T02:20:29+00:00 f40cbcb933367aa79fa881baff276b3a4566b563 The dev parameter is the device requesting the data. In this case it should be &pdev->dev rather than pdev->dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
regulator: remove use of __devexit 2012-11-20T01:53:38+00:00 Bill Pemberton wfp5p@virginia.edu 2012-11-19T18:26:10+00:00 8dc995f56ef7aedb41873fdeaa1971f3aa166ebd CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
regulator: remove use of __devinit 2012-11-20T01:31:26+00:00 Bill Pemberton wfp5p@virginia.edu 2012-11-19T18:22:22+00:00 a5023574d120ca3b9337cedd4e27de90cae9aff7 CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>