linux-toradex.git/drivers/regulator/max8925-regulator.c, branch v3.17.2 Linux kernel for Apalis and Colibri modules regulator: remove unnecessary of_node_get() to parent 2014-09-10T10:35:02+00:00 Guodong Xu guodong.xu@linaro.org 2014-09-10T03:50:39+00:00 b8b27a44ddf1987e9bae84b99741b0a61192e017 These of_node_get() were added to balance refcount decrements inside of of_find_node_by_name(). See: commit c92f5dd2c42f ("regulator: Add missing of_node_put()") However of_find_node_by_name() was then replaced by of_get_child_by_name(), which doesn't call of_node_put() against its input parameter. So, need to remove these unnecessary of_node_get() calls. Signed-off-by: Guodong Xu <guodong.xu@linaro.org> Reviewed-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
These of_node_get() were added to balance refcount decrements inside of
of_find_node_by_name().
See: commit c92f5dd2c42f ("regulator: Add missing of_node_put()")

However of_find_node_by_name() was then replaced by of_get_child_by_name(),
which doesn't call of_node_put() against its input parameter.

So, need to remove these unnecessary of_node_get() calls.

Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: max8925: Silence checkpatch warning 2014-03-18T12:40:19+00:00 Sachin Kamat sachin.kamat@linaro.org 2014-03-18T10:23:03+00:00 c74c76e8503e3f23f848a8bdf335b82bdf827d5a Silences the following type of checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
Silences the following type of checkpatch warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8925: Remove unused state container fields 2014-03-10T09:35:35+00:00 Krzysztof Kozlowski k.kozlowski@samsung.com 2014-03-10T08:32:49+00:00 15af45d1522af87bb5914e3c137b0b80bbca5931 Remove fields from 'struct max8925_regulator' which are not used anywhere in the driver. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org> 
Remove fields from 'struct max8925_regulator' which are not used
anywhere in the driver.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8925: Do not hardcode return value 2014-02-19T13:08:35+00:00 Sachin Kamat sachin.kamat@linaro.org 2014-02-18T10:41:01+00:00 e9fa1a3ac62d5103fe2b8b54968f5d0fe9cf7fdf Propagate the error value returned by the function instead. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
Propagate the error value returned by the function instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8925: Use of_get_child_by_name 2014-02-14T21:10:50+00:00 Sachin Kamat sachin.kamat@linaro.org 2014-02-14T11:49:51+00:00 1f4f88c0aef7e52bb3ae067ae802b64fc8312188 of_find_node_by_name walks the allnodes list, and can thus walk outside of the parent node. Use of_get_child_by_name instead. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Mark Brown <broonie@linaro.org> 
of_find_node_by_name walks the allnodes list, and can thus walk
outside of the parent node. Use of_get_child_by_name instead.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: max8925: use devm_regulator_register() 2013-09-30T17:10:59+00:00 Jingoo Han jg1.han@samsung.com 2013-09-30T00:56:24+00:00 58765e24bec8940082068829a9d2c3a4431d60c0 Use devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove(). Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org> 
Use devm_regulator_register() to make cleanup paths simpler,
and remove unnecessary remove().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: use dev_get_platdata() 2013-07-30T11:24:20+00:00 Jingoo Han jg1.han@samsung.com 2013-07-30T08:20:47+00:00 dff91d0b721bf8f036c1071a8f16a7effaa87514 Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Mark Brown <broonie@linaro.org> 
Use the wrapper function for retrieving the platform data instead of
accessing dev->platform_data directly.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers 2013-05-12T14:34:12+00:00 Axel Lin axel.lin@ingics.com 2013-05-03T12:46:10+00:00 405c54009c85cf03d459f5880744b0d4ebb892e4 Since 0998d06310 "device-core: Ensure drvdata = NULL when no driver is bound", this is done by driver core after device_release or on probe failure. Thus we can remove all platform_set_drvdata(pdev, NULL) in drivers. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
Since 0998d06310 "device-core: Ensure drvdata = NULL when no driver is bound",
this is done by driver core after device_release or on probe failure.
Thus we can remove all platform_set_drvdata(pdev, NULL) in drivers.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
regulator: max8925: Remove unused parameter from max8925_regulator_dt_init 2013-03-04T02:49:21+00:00 Axel Lin axel.lin@ingics.com 2013-02-15T12:36:06+00:00 ad4928f1dc695ea822c4daaafa5e3b2db7b17964 The info parameter is not used at all, remove it. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
The info parameter is not used at all, remove it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
regulator: Add missing of_node_put() 2013-01-30T10:50:27+00:00 Axel Lin axel.lin@ingics.com 2013-01-27T13:16:56+00:00 c92f5dd2c42fa61e0ef810fad4584b184ea2d50e of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. of_find_node_by_name() will call of_node_put() against from parameter, thus we also need to call of_node_get(from) before calling of_find_node_by_name(). Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> 
of_find_node_by_name() returns a node pointer with refcount incremented, use
of_node_put() on it when done.

of_find_node_by_name() will call of_node_put() against from parameter,
thus we also need to call of_node_get(from) before calling
of_find_node_by_name().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>