linux-toradex.git/drivers/regulator/max8997.c, branch v3.2.68

regulator: max8997: Use uV in voltage_map_desc

2013-02-06T04:33:26+00:00

commit bc3b7756b5ff66828acf7bc24f148d28b8d61108 upstream.

Current code does integer division (min_vol = min_uV / 1000) before pass
min_vol to max8997_get_voltage_proper_val().
So it is possible min_vol is truncated to a smaller value.

For example, if the request min_uV is 800900 for ldo.
min_vol = 800900 / 1000 = 800 (mV)
Then max8997_get_voltage_proper_val returns 800 mV for this case which is lower
than the requested voltage.

Use uV rather than mV in voltage_map_desc to prevent truncation by integer
division.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown 
[bwh: Backported to 3.2:
 - Adjust context
 - voltage_map_desc also has an n_bits field]
Signed-off-by: Ben Hutchings

regulator: Fix the logic to ensure new voltage setting in valid range

2012-05-20T21:56:29+00:00

commit f55205f4d4a8823a11bb8b37ef2ecbd78fb09463 upstream.

I think this is a typo.
To ensure new voltage setting won't greater than desc->max,
the equation should be desc->min + desc->step * new_val <= desc->max.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown 
Signed-off-by: Ben Hutchings

regulator: Add module.h to drivers/regulator users as required

2011-10-31T23:32:15+00:00

Another group of drivers that are taking advantage of the implicit
presence of module.h -- and will break when we pull the carpet out
from under them during a cleanup.  Fix 'em now.

Signed-off-by: Paul Gortmaker

regulator: max8997: Fix setting inappropriate value for ramp_delay variable

2011-07-08T18:14:58+00:00

The ramp_delay variable can be set lower than the desired value.
This patch fixes it.

Signed-off-by: Donggeun Kim 
Signed-off-by: MyungJoo Ham 
Signed-off-by: KyungMin Park 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: max8997: remove dependency on platform_data pointer

2011-07-08T18:14:57+00:00

The platform_data (pdata) may be pointing to __initdata section, which
may be free'd from the memory. The dependency on pdata in non-init
functions is removed in this patch to allow platform to declare
__initdata for platform data.

Signed-off-by: MyungJoo Ham 
Signed-off-by: Kyungmin Park 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: MAX8997: Fix for divide by zero error

2011-07-08T18:14:57+00:00

Currently, ramp_delay variable is used uninitialzed in
max8997_set_voltage_ldobuck which gets called through
regulator_register calls.

To fix the problem, in max8997_pmic_probe, ramp_delay initialization
code is moved before calls to regulator_register.

Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Samuel Ortiz 
Signed-off-by: Tushar Behera 
Acked-by: MyungJoo Ham 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: Remove MAX8997_REG_BUCK1DVS/MAX8997_REG_BUCK2DVS/MAX8997_REG_BUCK5DVS macros

2011-05-27T09:49:10+00:00

In current implementation, the original macro implementation assumes the caller
pass the parameter starting from 1 (to match the register names in datasheet).
Thus we have unneeded plus one then minus one operations
when using MAX8997_REG_BUCK1DVS/MAX8997_REG_BUCK2DVS/MAX8997_REG_BUCK5DVS macros.

This patch removes these macros to avoid unneeded plus one then minus one operations
without reducing readability.

Signed-off-by: Axel Lin 
Acked-by: Kyungmin Park 
Acked-by: MyungJoo Ham 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: max8997: remove useless code

2011-05-27T09:49:09+00:00

fix unreachable code.

Signed-off-by: Jonghwan Choi 
Signed-off-by: MyungJoo Ham 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: Add MODULE_DEVICE_TABLE to max8997 and max8998

2011-03-27T10:47:25+00:00

The device table is required to load modules based on modaliases.

Signed-off-by: Axel Lin 
Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Marek Szyprowski 
Acked-by: Mark Brown 
Signed-off-by: Liam Girdwood

regulator: MAX8997/8966 support

2011-03-23T09:42:07+00:00

This patch supports PMIC/Regulator part of MAX8997/MAX8966 MFD.
In this initial release, selecting voltages or current-limit
and switching on/off the regulators are supported.

Controlling voltages for DVS with GPIOs is not implemented fully
and requires more considerations: it controls multiple bucks (selection
of 1, 2, and 5) at the same time with SET1~3 gpios. Thus, when DVS-GPIO
is activated, we lose the ability to control the voltage of a single
buck regulator independently; i.e., contolling a buck affects other two
bucks. Therefore, using the conventional regulator framework directly
might be problematic. However, in this driver, we try to choose
a setting without such side effect of affecting other regulators and
then try to choose a setting with the minimum side effect (the sum of
voltage changes in other regulators).

On the other hand, controlling all the three bucks simultenously based
on the voltage set table may help build cpufreq and similar system
more robust; i.e., all the three voltages are consistent every time
without glitches during transition.

Signed-off-by: MyungJoo Ham 
Signed-off-by: Kyungmin Park 
Acked-by: Mark Brown 
Signed-off-by: Samuel Ortiz