linux-toradex.git/drivers/rpmsg, branch v4.14-rc7

rpmsg: glink: Fix memory leak in qcom_glink_alloc_intent()

2017-10-10T18:22:09+00:00

We need to free "intent" and "intent->data" on a couple error paths.

Fixes: 933b45da5d1d ("rpmsg: glink: Add support for TX intents")
Acked-by: Sricharan R 
Signed-off-by: Dan Carpenter 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Unlock on error in qcom_glink_request_intent()

2017-10-10T18:22:09+00:00

If qcom_glink_tx() fails, then we need to unlock before returning the
error code.

Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable")
Acked-by: Sricharan R 
Signed-off-by: Dan Carpenter 
Signed-off-by: Bjorn Andersson

rpmsg: glink: initialize ret to zero to ensure error status check is correct

2017-09-04T17:52:30+00:00

The new switch cases for RPM_CMD_RX_DONE, RPM_CMD_RX_DONE_W_REUSE,
RPM_CMD_RX_INTENT_REQ_ACK, RPM_CMD_INTENT and RPM_CMD_RX_INTENT_REQ from
4 recent commits are not setting ret and so a later non-zero check on ret
is testing on a garbage value in ret. Fix this by initializing ret to zero.

Detected by CoverityScan CID#1455249 ("Uninitialized scalar variable")

Fixes: 933b45da5d1d ("rpmsg: glink: Add support for TX intents)
Fixes: dacbb35e930f ("glink: Receive and store the remote intent buffers")
Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable")
Fixes: 88c6060f5a7f ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: Colin Ian King 
Signed-off-by: Bjorn Andersson

rpmsg: glink: fix null pointer dereference on a null intent

2017-09-04T17:51:49+00:00

In the case where glink->intentless is true and the call
to qcom_glink_tx fails then we have a condition where ret is
non-zero and intent is null, causing a null pointer deference
when setting intent->in_use to false.  Add an extra check to
only dereference intent if intent is non-null.

Detected by: CoverityScan CID#1455247 ("Explicit null dereferenced")

Fixes: 88c6060f5a7f ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: Colin Ian King 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Export symbols from common code

2017-09-01T00:10:40+00:00

The common code needs to export the probe and remove symbols in order
for the SMEM and RPM drivers to access them when compiled as a module.

Signed-off-by: Bjorn Andersson

rpmsg: glink: Release idr lock before returning on error

2017-08-30T23:26:23+00:00

The idr_lock should be released in the case that we don't find the given
channel.

Fixes: 44f6df922a26 ("rpmsg: glink: Fix idr_lock from mutex to spinlock")
Reported-by: Julia Lawall 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Handle remote rx done command

2017-08-30T03:34:16+00:00

Once the remote side sends a rx done ack, check for the intent reuse
information from it and suitably discard or reuse the remote passed
intent buffers.

Acked-by: Arun Kumar Neelakantam 
Signed-off-by: Sricharan R 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Request for intents when unavailable

2017-08-30T03:34:15+00:00

While sending data, we search for suitable sized intent to map and
simply fail if a intent is not found. Instead request for a intent of
required size and wait till one is alloted.

Acked-by: Arun Kumar Neelakantam 
Signed-off-by: Sricharan R 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Use the intents passed by remote

2017-08-30T03:34:15+00:00

While sending data, use the remote intent id buffer of suitable size
that was passed by remote previously.

Acked-by: Arun Kumar Neelakantam 
Signed-off-by: Sricharan R 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Receive and store the remote intent buffers

2017-08-30T03:34:15+00:00

Just like we allocating and sending intent ids to remote, remote side
allocates and sends us the intents as well.  So save the intent ids and
use it later while sending data targeting the appropriate intents based
on the size.

Acked-by: Arun Kumar Neelakantam 
Signed-off-by: Sricharan R 
Signed-off-by: Bjorn Andersson