linux-toradex.git/drivers/rtc/interface.c, branch v4.4-rc6

rtc: Drop (un)likely before IS_ERR(_OR_NULL)

2015-09-05T11:19:09+00:00

IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.

gemini driver was using likely() for a failure case while the rtc driver
is getting registered. That looks wrong and it should really be
unlikely. But because we are killing all the unlikely() flags, lets kill
that too.

Signed-off-by: Viresh Kumar 
Acked-by: Hans Ulli Kroll 
Signed-off-by: Alexandre Belloni

rtc: interface: Remove rtc_set_mmss()

2015-06-24T23:13:43+00:00

Now rtc_set_mmss() has no users, just remove it.

We still have rtc_set_time() doing similar things.

Signed-off-by: Xunlei Pang 
Signed-off-by: Alexandre Belloni

rtc: interface: Remove unused return value from rtc_timer_cancel()

2015-06-19T18:03:20+00:00

The rtc_timer_cancel() always returns 0 and cannot fail (calls only
other void-returning functions).

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

drivers/rtc/interface.c: __rtc_read_time: reduce log level

2015-04-17T13:04:01+00:00

__rtc_read_time logs should be debug logs instead of error logs.

For example, when the RTC clock is not set, it's not really useful
to print a kernel error log every time someone tries to read the clock:

	~ # hwclock -r
	[  604.508263] rtc rtc0: read_time: fail to read
	hwclock: RTC_RD_TIME: Invalid argument

If there's a real error, it's likely that lower level or higher level
code will tell it anyway. Make these logs debug logs, and also print
the error code for the read failure.

Signed-off-by: Aaro Koskinen 
Acked-by: Alexandre Belloni 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-04-03T06:18:24+00:00

Currently the rtc_class_op's set_mmss() function takes a 32-bit
second value (on 32-bit systems), which is problematic for dates
past y2038.

This patch provides a safe version named set_mmss64() using
y2038 safe time64_t.

After this patch, set_mmss() is deprecated and all its users
will be fixed to use set_mmss64(), it can be removed when having
no users.

Signed-off-by: Xunlei Pang 
[jstultz: Add whitespace fix for checkpatch]
Signed-off-by: John Stultz 
Acked-by: Alessandro Zummo 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Link: http://lkml.kernel.org/r/1427945681-29972-8-git-send-email-john.stultz@linaro.org
Signed-off-by: Ingo Molnar

rtc: Update interface.c to use y2038-safe time interfaces

2015-01-24T01:21:55+00:00

Currently, interface.c uses y2038 problematic rtc_tm_to_time()
and rtc_time_to_tm(). So replace them with their corresponding
y2038-safe versions: rtc_tm_to_time64() and rtc_time64_to_tm().

Cc: pang.xunlei 
Cc: Arnd Bergmann 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Signed-off-by: Xunlei Pang 
Signed-off-by: John Stultz

rtc: refine rtc_timer_do_work() to consider other set alarm failures

2014-12-11T01:41:16+00:00

rtc_timer_do_work() only judges -ETIME failure of__rtc_set_alarm(), but
doesn't handle other failures like -EIO, -EBUSY, etc.

If there is a failure other than -ETIME, the next rtc_timer will stay in
the timerqueue.  Then later rtc_timers will be enqueued directly because
they have a later expires time, so the alarm irq will never be programmed.

When such failures happen, this patch will retry __rtc_set_alarm(), if
still can't program the alarm time, it will remove current rtc_timer from
timerqueue and fetch next one, thus preventing it from affecting other rtc
timers.

Signed-off-by: Xunlei Pang 
Cc: Alessandro Zummo 
Cc: John Stultz 
Cc: Arnd Bergmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time

2014-12-11T01:41:13+00:00

Some rtc devices always return '0' when rtc_class_ops.read_time is
called.  So if rtc_time isn't verified in callback, rtc interface cannot
know whether rtc_time is valid.

Check rtc_time by using 'rtc_valid_tm' in '__rtc_read_time'.  And add
the message for debugging.

Signed-off-by: Hyogi Gim 
Cc: Alessandro Zummo 
Cc: John Stultz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-08-08T22:57:19+00:00

In __rtc_set_alarm(), the error after __rtc_read_time() is not checked.
If rtc device fail to read time, we cannot guarantee the following
process.

Add the verification code for returned __rtc_read_time() error.

Signed-off-by: Hyogi Gim 
Acked-by: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/interface.c: fix infinite loop in initializing the alarm

2014-06-06T23:08:06+00:00

In __rtc_read_alarm(), if the alarm time retrieved by
rtc_read_alarm_internal() from the device contains invalid values (e.g.
month=2,mday=31) and the year not set (=-1), the initialization will
loop infinitely because the year-fixing loop expects the time being
invalid due to leap year.

Fix reduces the loop to the leap years and adds final validity check.

Signed-off-by: Ales Novak 
Acked-by: Alessandro Zummo 
Reported-by: Jiri Bohac 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds