linux-toradex.git/drivers/rtc/rtc-cmos.c, branch v2.6.34.8

rtc-cmos: do dev_set_drvdata() earlier in the initialization

2010-07-05T18:22:27+00:00

commit 6ba8bcd457d9fc793ac9435aa2e4138f571d4ec5 upstream.

The bug is an oops when dev_get_drvdata() returned null in
cmos_update_irq_enable().  The call tree looks like this:
  rtc_dev_ioctl()
    => rtc_update_irq_enable()
      => cmos_update_irq_enable()

It's caused by a race condition in the module initialization.  It is
rtc_device_register() which makes the ioctl operations live so I moved
the call to dev_set_drvdata() before the call to rtc_device_register().

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=15963

Reported-by: Randy Dunlap 
Signed-off-by: Dan Carpenter 
Tested-by: Randy Dunlap 
Cc: Alessandro Zummo 
Cc: Paul Gortmaker 
Cc: Malte Schroder 
Cc: Ralf Baechle 
Cc: Herton Ronaldo Krzesinski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

rtc_cmos: convert shutdown to new pnp_driver->shutdown

2010-01-11T17:34:07+00:00

commit abd6633c67925f90775bb74755f9c547e30f1f20 ("pnp: add a shutdown
method to pnp drivers") adds shutdown method to bus driver blindly.  With
it, driver->shutdown is no longer valid.

Use pnp_driver->shutdown instead.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14889

Signed-off-by: OGAWA Hirofumi 
Reported-by: Malte Schröder 
Cc: "Rafael J. Wysocki" 
Cc: Bjorn Helgaas 
Cc: David Hardeman 
Cc: Dmitry Torokhov 
Cc: Alessandro Zummo 
Cc: Paul Gortmaker 
Cc: 		[2.6.32.x]
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

RTC: rtc-cmos.c: Fix warning on MIPS

2009-12-17T01:57:37+00:00

This patch fixes the following warning with RTC_LIB on MIPS:

drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of
RTC+NVRAM address space, not 64 bytes.

Signed-off-by: Wu Zhangjin 
Cc: Arnaud Patard 
Cc: linux-mips@linux-mips.org
Cc: rtc-linux@googlegroups.com
Cc: Paul Gortmaker 
Cc: Alessandro Zummo 
Patchwork: http://patchwork.linux-mips.org/patch/570/
Acked-by: Alessandro Zummo 
Signed-off-by: Ralf Baechle

rtc-cmos: convert RTC_AIE/RTC_UIE to rtc irq API

2009-12-16T15:19:58+00:00

Drop ioctl function that handles RTC_AIE/RTC_UIE, and use instead the
rtc subsystem API (alarm_irq_enable/update_irq_enable callbacks).

Signed-off-by: Herton Ronaldo Krzesinski 
Cc: Alessandro Zummo 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: disable hpet emulation on suspend

2009-12-16T15:19:58+00:00

I noticed that rtc wont generate interrupts after a resume from disk.
Here hpet rtc emulation is used.

Problem is that rtc hpet comparator, isn't reinitialized after resume.
Easiest way to solve this, is always mask all hpet interrupts on suspend
This is triggered, when suspending with alarm set.

Otherwise, hpet driver will think it doesn't need to reinitialize
the rtc comparator, thus rtc interrupts won't work.

This emulation isn't need for wakealarm.

Signed-off-by: Maxim Levitsky 
Cc: David Brownell 
Cc: "H. Peter Anvin" 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mark if rtc-cmos drivers were successfully registered

2009-07-30T02:10:35+00:00

rtc-cmos has two drivers, one PNP and one platform.  When PNP has not
succeeded probing, platform is registered.  However, it tries to
unregister both drivers unconditionally, instead of only unregistering
those that were successfully registered.  This causes runtime warnings to
be emitted from the driver core code.

Fix this with a boolean variable for each driver indicating whether
registering was successful.

Signed-off-by: Thadeu Lima de Souza Cascardo 
Cc: David Brownell 
Cc: Bjorn Helgaas 
Cc: Alessandro Zummo 
Cc: Ingo Molnar 
Cc: David Brownell 
Cc: Kay Sievers 
Cc: Greg KH 
Cc: Ozan Caglayan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-cmos: fix printk output

2009-04-21T20:41:50+00:00

With no IRQ available/defined, RTC-CMOS driver prints something like:
	rtc0: alarms up to one no, y3k, 114 bytes nvram
                              ^^^^
I guess the following is a bit easier to understand:
	rtc0: no alarms, y3k, 114 bytes nvram

Signed-off-by: Krzysztof Halasa 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: move power of 2 periodic frequency check down into drivers

2009-01-06T23:59:24+00:00

Move the power of 2 check on frequencies down into individual rtc drivers

This is to allow for non power of 2 real time clock periodic interrupts
such as those on the pxa27x to be found in the new pxa27x-rtc driver

Signed-off-by: Jonathan Cameron 
Signed-off-by: Alessandro Zummo 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: bunch of drivers: fix 'no irq' case handing

2009-01-06T23:59:23+00:00

This patch fixes a bunch of irq checking misuses.  Most drivers were
getting irq via platform_get_irq(), which returns -ENXIO or r->start.

rtc-cmos.c is special.  It is using PNP and platform bindings.  Hopefully
nobody is using PNP IRQ 0 for RTC.  So the changes should be safe.

rtc-sh.c is using platform_get_irq, but was storing a result into an
unsigned type, then was checking for < 0.  This is fixed now.

Signed-off-by: Anton Vorontsov 
Cc: Alessandro Zummo 
Acked-by: David Brownell 
Acked-by: Paul Mundt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: struct device: replace bus_id with dev_name(), dev_set_name()

2009-01-06T23:59:23+00:00

Acked-by: Alessandro Zummo 
Acked-By: Greg Kroah-Hartman 
Signed-off-by: Kay Sievers 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds