linux-toradex.git/drivers/rtc/rtc-da9052.c, branch v4.4.48

drivers/rtc/rtc-da9052.c: register ability of alarm to wake device from suspend

2015-04-17T13:04:00+00:00

Signed-off-by: Adam Ward 
Tested-by: Adam Ward 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-da9052.c: add constraints to set valid year

2015-04-17T13:04:00+00:00

Signed-off-by: Adam Ward 
Tested-by: Adam Ward 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-da9052.c: add extra reads with timeouts to avoid returning partially updated values

2015-04-17T13:04:00+00:00

The RTC is in a different clock domain so a quick read after write
can retrieve a mangled value of the old/new values

Signed-off-by: Adam Ward 
Tested-by: Adam Ward 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

drivers/rtc/rtc-da9052.c: ALARM causes interrupt storm

2014-06-06T23:08:07+00:00

Setting the alarm to a time not on a minute boundary results in repeated
interrupts being generated by the DA9052/3 PMIC device until the kernel
RTC core sees that the alarm has rung.  Sometimes the number and frequency
of interrupts can cause the kernel to disable the IRQ line used by the
DA9052/3 PMIC with disasterous consequences.  This patch fixes the
problem.

Even though the DA9052/3 PMIC is capable generating periodic interrupts,
ie TICKS, the method used to distinguish RTC_AF from RTC_PF events was
flawed and can not work in conjunction with the regmap_irq kernel core.
Thus that flawed detection has also been removed by the DA9052/3 PMIC RTC
driver's irq handler, so that it no longer reports the wrong type of event
to the kernel RTC core.

The internal static functions within the DA9052/3 PMIC RTC driver have
been changed to pass the 'da9052_rtc' structure instead of the 'da9052'
because there is no backwards pointer from the 'da9052' structure.

This patch fixes the three issues described above.  The first is serious
because usiing the RTC alarm set to a non minute boundary will eventually
cause all component drivers that depend on the interrupt line to fail.
The solution adopted is to round up to alarm time to the next highest
minute.

The second bug, reporting a RTC_PF event instead of an RTC_AF event turns
out to not matter with the current implementation of the kernel RTC core
as it seems to ignore the event type.  However, should that change in the
future it is better to fix the issue now and not have 'problems waiting to
happen'

The third set of changes are to make the da9052_rtc structure available to
all the local internal functions in the driver.  This was done during
testing so that diagnostic data could be stored there.  Should the
solution to the first issue be found not acceptable, then the alternative
of using the TICKS interrupt at the fixed one second interval in order to
step to the exact second of the requested alarm requires an extra (alarm
time) piece of data to be stored.  In devices that use the alarm function
to wake up from sleep, accuracy to the second will result in the device
being awake for up to nearly a minute longer than expected.

Signed-off-by: Anthony Olech 
Cc: David Dajun Chen 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-da9052.c: remove redundant private structure field

2014-04-03T23:21:19+00:00

Remove redundant irq field in private rtc structure.

Signed-off-by: Anthony Olech 
Acked-by: David Dajun Chen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: Replace PTR_RET with PTR_ERR_OR_ZERO

2013-07-16T06:36:00+00:00

PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.

Signed-off-by: Sachin Kamat 
Signed-off-by: Rusty Russell

drivers/rtc/rtc-da9052.c: use PTR_RET()

2013-07-03T23:07:59+00:00

Use of PTR_RET() simplifies the code.

Signed-off-by: Sachin Kamat 
Cc: David Dajun Chen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-da9052.c: remove empty function

2013-07-03T23:07:54+00:00

After the switch to devm_ functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Cc: David Dajun Chen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-da9052: remove unnecessary platform_set_drvdata()

2013-07-03T23:07:49+00:00

The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063100 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds