linux-toradex.git/drivers/rtc/rtc-ds1307.c, branch v3.11

rtc: rtc-ds1307: use devm_*() functions

2013-07-03T23:07:54+00:00

Use devm_*() functions to make cleanup paths simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1307.c: change sysfs function pointer assignment

2013-04-30T01:28:34+00:00

The current usage of commas instead of semicolons is not wrong, but
affects the readability of the code.

Also, the code would break, if someone puts something between those two
assignments.

Signed-off-by: Steffen Trumtrar 
Cc: Austin Boyle 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-ds1307: use dev_dbg() instead of pr_debug()

2013-04-30T01:28:28+00:00

dev_dbg() is preferred to pr_debug().

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1307.c: long block operations bugfix

2013-04-30T01:28:28+00:00

The rtc-ds1307 driver does not properly handle block operations bigger
than 32 bytes in either of the two modes supported (SMbus native, or
emulated if not supported by the SMbus platform driver).

It also does not properly handle userland-supplied input (block
operation length) through sysfs and may suffer a type of buffer overrun.

The driver has been modified with proper input validation, buffer sizes,
and now splits block transfers bigger than 32 bytes into separate
transfers.

Explanation : Buffer size allocated is I2C_SMBUS_BLOCK_MAX which equals
to 32 as per the SMbus spec.  Reads and write may be up to 56 bytes (to
the NVRAM).  This patch allocated a 255 byte buffer, the maximum
allowable (address is an u8).  It's not only a buffer problem, SMbus
only supports up to 32 bytes transfer at once, so it's needed to split
bigger transfers.

Patch successfully tested on 3.2.27; cleanly applies on 3.7-rc4.

[akpm@linux-foundation.org: rework code to avoid 80-column overflows]
Signed-off-by: Bertrand Achard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: dump small buffers via %*ph

2013-02-22T01:22:27+00:00

Signed-off-by: Andy Shevchenko 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Drivers: rtc: remove __dev* attributes.

2013-01-03T23:57:02+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Alessandro Zummo 
Cc: Srinidhi Kasagar 
Cc: Linus Walleij 
Cc: Mike Frysinger 
Cc: Wan ZongShun 
Cc: Guan Xuetao 
Cc: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

rtc: ds1307: add trickle charger support

2012-05-29T23:22:33+00:00

Some DS13XX devices have "trickle chargers".  Its configuration register
is at different locations, the setup is the same, though.  Since the
configuration is board specific, introduce a platform_data to this driver.
Tested with a DS1339 on a custom board.

Signed-off-by: Wolfram Sang 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: ds1307: remove superfluous initialization

2012-05-29T23:22:33+00:00

ds1307 was kzalloced, so no need to zero members of the struct.

Signed-off-by: Wolfram Sang 
Acked-by: Joakim Tjernlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1307.c: fix BUG shown with lock debugging enabled

2012-04-26T04:26:34+00:00

Add struct bin_attribute initialization to fix the following bug:

rtc-ds1307 3-0068: rtc core: registered ds1307 as rtc0
BUG: key cfb14fcc not in .data!
------------[ cut here ]------------
WARNING: at kernel/lockdep.c:2986 sysfs_add_file_mode+0x84/0xdc()
Modules linked in:
[] (unwind_backtrace+0x0/0xf8) from [] (warn_slowpath_common+0x4c/0x64)
[] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_null+0x1c/0x24)
[] (warn_slowpath_null+0x1c/0x24) from [] (sysfs_add_file_mode+0x84/0xdc)
[] (sysfs_add_file_mode+0x84/0xdc) from [] (ds1307_probe+0x5e4/0x6ac)
[] (ds1307_probe+0x5e4/0x6ac) from [] (i2c_device_probe+0xdc/0x108)
[] (i2c_device_probe+0xdc/0x108) from [] (driver_probe_device+0x90/0x210)
[] (driver_probe_device+0x90/0x210) from [] (__driver_attach+0x94/0x98)
[] (__driver_attach+0x94/0x98) from [] (bus_for_each_dev+0x50/0x7c)
[] (bus_for_each_dev+0x50/0x7c) from [] (bus_add_driver+0x184/0x244)
[] (bus_add_driver+0x184/0x244) from [] (driver_register+0x78/0x12c)
[] (driver_register+0x78/0x12c) from [] (i2c_register_driver+0x2c/0xb4)
[] (i2c_register_driver+0x2c/0xb4) from [] (do_one_initcall+0x34/0x178)
[] (do_one_initcall+0x34/0x178) from [] (kernel_init+0xdc/0x194)
[] (kernel_init+0xdc/0x194) from [] (kernel_thread_exit+0x0/0x8)

Since commit 6992f5334995af4 ("sysfs: Use one lockdep class per sysfs
attribute") this initialization is required.

Reported-by: Stefano Babic 
Tested-by: Stefano Babic 
Signed-off-by: Anatolij Gustschin 
Cc: Alessandro Zummo 
Cc: Stefano Babic 
Cc: Eric W. Biederman 
Cc: Greg Kroah-Hartman 
Acked-by: Wolfram Sang 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: ds1307: generalise ram size and offset

2012-03-23T23:58:40+00:00

Generalise NVRAM to support RAM with other size and offset, such as the
64 bytes of SRAM on the mcp7941x.

[rdunlap@xenotime.net: fix printk format warning]
Signed-off-by: Austin Boyle 
Signed-off-by: Wolfram Sang 
Signed-off-by: Randy Dunlap 
Cc: David Anders 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds