linux-toradex.git/drivers/rtc/rtc-ds1374.c, branch v4.10

rtc: ds1374: Merge conditional + WARN_ON()

2016-12-07T15:34:43+00:00

WARN_ON does both these things in one statement.
Using a better pattern with WARN_ON().

Signed-off-by: Srikant Ritolia 
Signed-off-by: Alexandre Belloni

rtc: ds1374: Remove unused variable

2015-09-05T17:37:22+00:00

Remove unused variable 'res' and fix the following build warning:

drivers/rtc/rtc-ds1374.c:667:6: warning: unused variable 'res' [-Wunused-variable]

Reported-by: Olof's autobuilder 
Signed-off-by: Fabio Estevam 
Signed-off-by: Alexandre Belloni

rtc: fix drivers that consider 0 as a valid IRQ in client->irq

2015-09-05T11:19:07+00:00

Since dab472eb931b ("i2c / ACPI: Use 0 to indicate that device does not
have interrupt assigned"), 0 is not a valid i2c client irq anymore, so
change all driver's checks accordingly.

The same issue occurs when the device is instantiated via device tree
with no IRQ, or from the i2c sysfs interface, even before the patch
above.

Signed-off-by: Octavian Purdila 
Reviewed-by: Mika Westerberg 
Signed-off-by: Alexandre Belloni

rtc: Drop owner assignment from i2c_driver

2015-09-05T11:19:06+00:00

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

char: make misc_deregister a void function

2015-08-05T17:35:49+00:00

With well over 200+ users of this api, there are a mere 12 users that
actually checked the return value of this function.  And all of them
really didn't do anything with that information as the system or module
was shutting down no matter what.

So stop pretending like it matters, and just return void from
misc_deregister().  If something goes wrong in the call, you will get a
WARNING splat in the syslog so you know how to fix up your driver.
Other than that, there's nothing that can go wrong.

Cc: Alasdair Kergon 
Cc: Neil Brown 
Cc: Oleg Drokin 
Cc: Andreas Dilger 
Cc: "Michael S. Tsirkin" 
Cc: Wim Van Sebroeck 
Cc: Christine Caulfield 
Cc: David Teigland 
Cc: Mark Fasheh 
Acked-by: Joel Becker 
Acked-by: Alexandre Belloni 
Acked-by: Alessandro Zummo 
Acked-by: Mike Snitzer 
Signed-off-by: Greg Kroah-Hartman

rtc: use more standard kernel logging styles

2015-04-17T13:04:02+00:00

Neaten the logging a bit by adding #define pr_fmt

Miscellanea:

o Remove __FILE__/__func__ uses
o Coalesce formats adding missing spaces
o Align arguments
o (rtc-cmos) Integrated 2 consecutive messages

Signed-off-by: Joe Perches 
Acked-by: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Joshua Kinard 
Cc: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Cc: Aaro Koskinen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1374.c: add watchdog support

2014-12-11T01:41:15+00:00

Add support for the watchdog functionality of the DS1374 rtc.  Based on
the m41t80 watchdog functionality Note: watchdog uses the same registers
as alarm.

[akpm@linux-foundation.org: don't forget mutex_unlock() in ds1374_wdt_open() error path]
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Soeren Andersen 
Cc: Alessandro Zummo 
Cc: Dan Carpenter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1374.c: fix spacing related issues

2013-07-03T23:07:46+00:00

Fixes the following types of issues:

  ERROR: code indent should use tabs where possible
  WARNING: please, no spaces at the start of a line

Signed-off-by: Sachin Kamat 
Cc: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1374.c: use devm_* APIs

2013-04-30T01:28:35+00:00

devm_* functions are device managed and make cleanup code simpler.

Signed-off-by: Sachin Kamat 
Cc: Scott Wood 
Cc: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1374.c: add CONFIG_PM_SLEEP to suspend/resume functions

2013-04-30T01:28:33+00:00

Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected.  This is because
sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the
CONFIG_PM_SLEEP is enabled.

  drivers/rtc/rtc-ds1374.c:413:12: warning: 'ds1374_suspend' defined but not used [-Wunused-function]
  drivers/rtc/rtc-ds1374.c:422:12: warning: 'ds1374_resume' defined but not used [-Wunused-function]

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds