linux-toradex.git/drivers/rtc/rtc-ds1672.c, branch v5.10-rc2 Linux kernel for Apalis and Colibri modules rtc: ds1672: remove unnecessary check 2019-08-21T07:57:23+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-08-18T21:52:32+00:00 80ba93639b5dfde6b7897499b69fefc733a94a59 The rtc pointer is already checked earlier, it is not necessary to check it again. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20190818215232.17320-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
The rtc pointer is already checked earlier, it is not necessary to check it
again.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20190818215232.17320-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: switch debug message to %ptR 2019-04-08T12:35:46+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:41+00:00 e3a7691321aee378083b7bc2d7964e49bb940e9d Use %ptR to simplify debug message. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Use %ptR to simplify debug message.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: convert to SPDX identifier 2019-04-08T12:35:40+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:40+00:00 69468320a94d55ec219eaf629d6774d753a9eb99 Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Use SPDX-License-Identifier instead of a verbose license text.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: use .set_time 2019-04-08T12:35:38+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:39+00:00 219219d9b89b4be4cb58c1503393cd715d48933a Use .set_time instead of the deprecated .set_mmss. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Use .set_time instead of the deprecated .set_mmss.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: use rtc_time64_to_tm 2019-04-08T12:35:33+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:38+00:00 520d6516736e1c3f5b7178b2eba13c0b9e172f37 Use the 64bit version of rtc_time_to_tm.rtc_time_to_tm. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Use the 64bit version of rtc_time_to_tm.rtc_time_to_tm.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: remove useless indirection 2019-04-08T12:35:28+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:37+00:00 7a5670c754b81a241c970b383a9af3e1a9fa35c0 ds1672_get_datetime and ds1672_set_mmss are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
ds1672_get_datetime and ds1672_set_mmss are only used after casting dev
to an i2c_client. Remove that useless indirection.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: remove sysfs debug interface 2019-04-08T12:35:24+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:36+00:00 c346065582f80f56005a679c9675ddad77e3e823 Remove the control sysfs file as it is not documented, read only and was only used to provide the oscillator state. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Remove the control sysfs file as it is not documented, read only and was
only used to provide the oscillator state.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: move oscillator handling to .read_time 2019-04-08T12:35:20+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:35+00:00 10e3efc16569a126456c413274b90b00e60454ca Return -EINVAL when trying to read an invalid time instead of just probe because this is a useful information for userspace. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Return -EINVAL when trying to read an invalid time instead of just probe
because this is a useful information for userspace.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: set range 2019-04-08T12:35:12+00:00 Alexandre Belloni alexandre.belloni@bootlin.com 2019-04-07T21:05:34+00:00 d1fbe695d889959e2430379cc989cd399fa9e253 The ds1672 is a 32bit seconds counter. Also remove erroneous comment claiming that epoch is set to 2000, it was not. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
The ds1672 is a 32bit seconds counter.

Also remove erroneous comment claiming that epoch is set to 2000, it was
not.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rtc: ds1672: fix unintended sign extension 2019-02-05T22:11:31+00:00 Colin Ian King colin.king@canonical.com 2019-02-05T18:04:49+00:00 f0c04c276739ed8acbb41b4868e942a55b128dca Shifting a u8 by 24 will cause the value to be promoted to an integer. If the top bit of the u8 is set then the following conversion to an unsigned long will sign extend the value causing the upper 32 bits to be set in the result. Fix this by casting the u8 value to an unsigned long before the shift. Detected by CoverityScan, CID#138801 ("Unintended sign extension") Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> 
Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#138801 ("Unintended sign extension")

Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>