linux-toradex.git/drivers/rtc/rtc-ds1672.c, branch v5.16

rtc: ds1672: quiet maybe-unused variable warning

2021-02-05T23:58:24+00:00

When CONFIG_OF is disabled then the matching table is not referenced.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20210202112219.3610853-7-alexandre.belloni@bootlin.com

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.

This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.

While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: ds1672: remove unnecessary check

2019-08-21T07:57:23+00:00

The rtc pointer is already checked earlier, it is not necessary to check it
again.

Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20190818215232.17320-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: ds1672: switch debug message to %ptR

2019-04-08T12:35:46+00:00

Use %ptR to simplify debug message.

Signed-off-by: Alexandre Belloni

rtc: ds1672: convert to SPDX identifier

2019-04-08T12:35:40+00:00

Use SPDX-License-Identifier instead of a verbose license text.

Signed-off-by: Alexandre Belloni

rtc: ds1672: use .set_time

2019-04-08T12:35:38+00:00

Use .set_time instead of the deprecated .set_mmss.

Signed-off-by: Alexandre Belloni

rtc: ds1672: use rtc_time64_to_tm

2019-04-08T12:35:33+00:00

Use the 64bit version of rtc_time_to_tm.rtc_time_to_tm.

Signed-off-by: Alexandre Belloni

rtc: ds1672: remove useless indirection

2019-04-08T12:35:28+00:00

ds1672_get_datetime and ds1672_set_mmss are only used after casting dev
to an i2c_client. Remove that useless indirection.

Signed-off-by: Alexandre Belloni

rtc: ds1672: remove sysfs debug interface

2019-04-08T12:35:24+00:00

Remove the control sysfs file as it is not documented, read only and was
only used to provide the oscillator state.

Signed-off-by: Alexandre Belloni

rtc: ds1672: move oscillator handling to .read_time

2019-04-08T12:35:20+00:00

Return -EINVAL when trying to read an invalid time instead of just probe
because this is a useful information for userspace.

Signed-off-by: Alexandre Belloni