linux-toradex.git/drivers/rtc/rtc-max6900.c, branch v4.20

rtc: max6900: remove useless indirection

2018-03-17T13:20:46+00:00

max6900_i2c_read_time and max6900_i2c_set_time are only used after casting
dev to an i2c_client. Remove that useless indirection.

Signed-off-by: Alexandre Belloni

rtc: max6900: stop validating rtc_time in .read_time

2018-03-17T13:20:45+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it before returning from the callback.

Signed-off-by: Alexandre Belloni

rtc: constify i2c_device_id

2017-08-31T23:10:11+00:00

i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by  work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav 
Signed-off-by: Alexandre Belloni

rtc: remove useless DRV_VERSION

2016-05-20T10:33:51+00:00

Many drivers are defining a DRV_VERSION. This is often only used for
MODULE_VERSION and sometimes to print an info message at probe time. This
is kind of pointless as they are all versionned with the kernel anyway.
Also the core will print a message when a new rtc is found.

Signed-off-by: Alexandre Belloni

rtc: ds1672, max6900, max8998: Add MODULE_DEVICE_TABLE

2015-06-24T23:13:36+00:00

The device table is required to load modules based on modaliases.
After adding MODULE_DEVICE_TABLE, below entries will be added to
modules.alias:

alias i2c:ds1672 rtc_ds1672
alias i2c:max6900 rtc_max6900
alias platform:lp3974-rtc rtc_max8998
alias platform:max8998-rtc rtc_max8998

Signed-off-by: Axel Lin 
Cc: Alessandro Zummo 
Cc: Dale Farnsworth 
Cc: Minkyu Kang 
Cc: Joonyoung Shim 
Signed-off-by: Alexandre Belloni

drivers/rtc/rtc-max6900.c: remove redundant checks

2013-11-13T03:09:27+00:00

i2c_smbus_write_byte_data() returns negative errno on failure or 0 on
success.  Return the value obtained from it directly.

Signed-off-by: Sachin Kamat 
Cc: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-max6900.c: remove empty function

2013-07-03T23:07:57+00:00

After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Cc: Dale Farnsworth 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-max6900: use devm_rtc_device_register()

2013-04-30T01:28:30+00:00

devm_rtc_device_register() is device managed and makes cleanup paths
simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: convert rtc i2c drivers to module_i2c_driver

2012-03-23T23:58:39+00:00

Factor out some boilerplate code for i2c driver registration into
module_i2c_driver.

Signed-off-by: Axel Lin 
Cc: Piotr Ziecik 
Cc: Alessandro Zummo 
Cc: Scott Wood 
Cc: Srikanth Srinivasan 
Cc: Mike Rapoport 
Cc: Sergey Lapin 
Cc: Roman Fietze 
Cc: Herbert Valerio Riedel 
Cc: Alexander Bigga 
Cc: Dale Farnsworth 
Cc: Gregory Hermant 
Cc: Wolfgang Grandegger 
Cc: Martyn Welch 
Cc: Byron Bradley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc/max6900: use rtc_valid_tm() to check returning tm

2010-08-11T15:59:07+00:00

Use rtc_valid_tm() to check returning tm for max6900, it can avoid
returning wrong tm value.

Signed-off-by: Wan ZongShun 
Acked-by: Dale Farnsworth 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds