linux-toradex.git/drivers/rtc/rtc-max77686.c, branch v4.1.10

rtc: use more standard kernel logging styles

2015-04-17T13:04:02+00:00

Neaten the logging a bit by adding #define pr_fmt

Miscellanea:

o Remove __FILE__/__func__ uses
o Coalesce formats adding missing spaces
o Align arguments
o (rtc-cmos) Integrated 2 consecutive messages

Signed-off-by: Joe Perches 
Acked-by: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Joshua Kinard 
Cc: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Cc: Aaro Koskinen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

rtc: max77686: Use ffs() to calculate tm_wday

2014-10-14T00:18:19+00:00

max77686_rtc_calculate_wday() is used to calculate the day of the week
to be filled in struct rtc_time but that function only calculates the
number of bits shifted.  So the ffs() function can be used to find the
first bit set instead of a special function.

[akpm@linux-foundation.org: add comment clarifying ffs() use]
Signed-off-by: Javier Martinez Canillas 
Cc: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: max77686: remove unneeded info log

2014-10-14T00:18:19+00:00

If devm_rtc_device_register() fails a dev_err() is already reported so
there is no need to do an additional dev_info().

Signed-off-by: Javier Martinez Canillas 
Cc: Doug Anderson 
Cc: Krzysztof Kozlowski 
Cc: Alessandro Zummo 
Cc: Olof Johansson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: max77686: fail to probe if no RTC regmap irqchip is set

2014-10-14T00:18:19+00:00

The max77686 mfd driver adds a regmap IRQ chip which creates an IRQ
domain that is used to map the virtual RTC alarm1 interrupt.

The RTC driver assumes that this will always be true since the PMIC IRQ
is a required property according to the max77686 DT binding doc.  If an
"interrupts" property is not defined for a max77686 PMIC, then the mfd
probe function will fail and the RTC platform driver will never be
probed.

But even when it is not possible to probe the rtc-max77686 driver
without a regmap IRQ chip, it's better to explicitly check if the IRQ
chip data is not NULL and gracefully fail instead of getting an OOPS.

Signed-off-by: Javier Martinez Canillas 
Reported-by: Krzysztof Kozlowski 
Cc: Doug Anderson 
Cc: Alessandro Zummo 
Cc: Olof Johansson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: max77686: remove dead code for SMPL and WTSR

2014-10-14T00:18:18+00:00

The MAX77686 RTC chip has two features called SMPL (Sudden Momentary
Power Loss) and WTSR (Watchdog Timeout and Software Resets).  Support
for these features seems to be implemented in the driver but compilation
is disabled using a C pre-processor conditional.

This code has been disabled since the driver was original merged in
commit fca1dd031a28 ("rtc: max77686: add Maxim 77686 driver").

So, since this code has never been built, let's just remove it.

Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Krzysztof Kozlowski 
Cc: Doug Anderson 
Cc: Alessandro Zummo 
Cc: Olof Johansson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: max77686: Allow the max77686 rtc to wakeup the system

2014-10-14T00:18:18+00:00

This series add support for the Real Time clock present in the Maxim 77802
Power Managment IC.  The version number is quite high because it
previously was part of a bigger series [0] that aimed to add support for
all the devices in the max77802 PMIC.  But now that the max77802
dependencies were already merged for 3.17, the series were split but I
kept the version numbering.

While working on the max77802 rtc support a lot of feedback was given and
the issues pointed out also apply to a driver for a similar PMIC RTC
(max77686).  So patches 01/06 to 05/06 in the series are cleanups for the
max77686 driver and patch 06/06 adds the support for the max77802 RTC.

The series were tested on an Exynos5250 Snow (max77686) and
Exynos5420 Peach Pit (max77802) machines.

This patch (of 6):

The max77686 includes an RTC that keeps power during suspend.  It's
convenient to be able to use it as a wakeup source.

Signed-off-by: Doug Anderson 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Krzysztof Kozlowski 
Cc: Alessandro Zummo 
Cc: Olof Johansson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd: max77686: Convert to use regmap_irq

2014-07-21T15:54:26+00:00

By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.

Suggested-by: Krzysztof Kozlowski 
Signed-off-by: Javier Martinez Canillas 
Reviewed-by: Doug Anderson 
Tested-by: Doug Anderson 
Signed-off-by: Lee Jones

drivers/rtc/rtc-max77686.c: Fix wrong register

2013-09-11T22:58:56+00:00

Fix a read of the wrong register when checking whether the RTC timer has
reached the alarm time.

Signed-off-by: Sangjung Woo 
Signed-off-by: Myugnjoo Ham 
Reviewed-by: Jonghwa Lee 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-max77686.c: remove empty function

2013-07-03T23:07:57+00:00

After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Cc: Chiwoong Byun 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds