linux-toradex.git/drivers/rtc/rtc-mc13xxx.c, branch v4.4.74

rtc: mc13xxx: fix obfuscated and wrong format string

2015-06-24T23:13:35+00:00

According to C99, %2.s means 'print two spaces' (a precision of
. without following digits or * means 0). The kernel's printf
implementation, however, treats that case as if no precision was
given, but relying on that quirk is rather silly. Also, since no -
(aka left-justify) flag is given, the field with of 2 would then cause
the alarm->enabled case to come out as "o n". Deobfuscate it.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Alexandre Belloni

drivers/rtc/mc13xxx: Update driver to address y2038/y2106 issues

2015-04-03T06:18:26+00:00

This driver has a number of y2038/y2106 issues.

This patch resolves them by:

  - Replacing rtc_time_to_tm() with rtc_time64_to_tm()
  - Changing mc13xxx_rtc_set_mmss() to use rtc_class_ops's set_mmss64()

After this patch, the driver should not have any remaining
y2038/y2106 issues.

Signed-off-by: Xunlei Pang 
Signed-off-by: John Stultz 
Acked-by: Alessandro Zummo 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Link: http://lkml.kernel.org/r/1427945681-29972-11-git-send-email-john.stultz@linaro.org
Signed-off-by: Ingo Molnar

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

drivers/rtc/rtc-mc13xxx.c: fix potential race condition

2014-04-03T23:21:23+00:00

RTC drivers must not return an error after device registration.  This
patch makes RTC registration as the last action.

Signed-off-by: Alexander Shiyan 
Acked-by: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: make rtc_read_time() more readable

2014-04-03T23:21:21+00:00

Remove unnecessary locks when reading the time and make the read
operation until the values of day matched between reading the seconds,
it will make the mc13xxx_rtc_read_time() procedure more readable.
Additionally, patch introduced a "seconds in a day" definition.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: change RTC validation scheme

2014-04-03T23:21:21+00:00

Datasheet says: "When the VSRTC voltage drops to the range of 0.9 - 0.8V,
the RTCPORB reset signal is generated and the contents of the RTC will
be reset.  .  To inform the processor that the contents of the RTC
are no longer valid due to the reset, a timer reset interrupt function
is implemented with the RTCRSTI bit." This patch makes the RTC valid by
default until RTCRST interrupt occurs.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: fix 1Hz interrupt

2014-04-03T23:21:20+00:00

1Hz interrupt is never unmasked, so no interrupts appears.  This patch
fix this issue.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: simplify alarm_irq_enable()

2014-04-03T23:21:20+00:00

This patch removes excess layer for alarm_irq_enable() function.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: request IRQs after RTC registration

2014-04-03T23:21:20+00:00

Interrupts can appear after request_irq and interrupt handlers can use
the RTC device, but currently we register RTC after IRQs.  This patch
changes this order and simplify error path a bit.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: mc13xxx: remove __exit_p()

2014-04-03T23:21:20+00:00

Since we no longer allow building without hotplug, the
mc13xxx_rtc_remove() function is always present and we should not use
__exit_p() to refer to it.

Signed-off-by: Alexander Shiyan 
Cc: Uwe Kleine-König 
Cc: Sascha Hauer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds