linux-toradex.git/drivers/rtc/rtc-omap.c, branch v4.12

rtc: omap: mark PM methods as __maybe_unused

2017-03-09T00:32:32+00:00

Instead of using #ifdef guards around PM methods, let's annotate
them as __maybe_unused, as it provides better compile coverage.

Also drop empty stub for omap_rtc_runtime_resume().

Signed-off-by: Dmitry Torokhov 
Signed-off-by: Alexandre Belloni

rtc: omap: remove incorrect __exit markups

2017-03-09T00:32:31+00:00

Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe(), which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov 
Reviewed-By: Sebastian Reichel 
Signed-off-by: Alexandre Belloni

pinctrl: Widen the generic pinconf argument from 16 to 24 bits

2017-01-26T14:22:32+00:00

The current pinconf packed format allows only 16-bit argument limiting
the maximum value 65535. For most types this is enough. However,
debounce time can be in range of hundreths of milliseconds in case of
mechanical switches so we cannot represent the worst case using the
current format.

In order to support larger values change the packed format so that the
lower 8 bits are used as type which leaves 24 bits for the argument.
This allows representing values up to 16777215 and debounce times up to
16 seconds.

We also convert the existing users to use 32-bit integer when extracting
argument from the packed configuration value.

Signed-off-by: Mika Westerberg 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Linus Walleij

rtc: omap: prevent disabling of clock/module during suspend

2016-11-04T22:11:39+00:00

If RTC is running from an internal clock source, the RTC module can't
be disabled; otherwise it stops ticking completely. Current suspend
handler implementation disables the clock/module unconditionally,
instead fix this by disabling the clock only if we are running on
external clock source, which is not affected by suspend.

The prevention of disabling the clock must be done via implementing
the runtime_pm handlers for the device, and returning an error code
from the runtime suspend handler; otherwise OMAP core PM will disable
the clocks for the driver.

Signed-off-by: Tero Kristo 
Signed-off-by: Keerthy 
Signed-off-by: Alexandre Belloni

rtc: omap: Fix selecting external osc

2016-11-04T22:11:37+00:00

RTC can be clocked from an external 32KHz oscillator, or from the
Peripheral PLL. The RTC has an internal oscillator buffer to support
direct operation with a crystal.

            ----------------------------------------
            |       Device          ---------       |
            |                       |       |       |
            |                       | RTCSS |       |
            |       ---------       |       |       |
    OSC     |<------| RTC   |       |       |       |
            |------>| OSC   |---    |       |       |
            |       --------   |    |       |       |
            |                   ----|clk    |       |
            |       --------   |    |       |       |
            |       | PRCM  |---    |       |       |
            |       --------        --------        |
            ----------------------------------------

The RTC functional clock is sourced by default from the clock derived
from the Peripheral PLL. In order to select source as external osc clk
the following changes needs to be done:
- Enable the RTC OSC (RTC_OSC_REG[4]OSC32K_GZ = 0)
- Enable the clock mux(RTC_OSC_REG[6]K32CLK_EN = 1)
- Select the external clock source (RTC_OSC_REG[3]32KCLK_SEL = 1)

Fixes: 399cf0f63f6f2 ("rtc: omap: Add external clock enabling support")
Signed-off-by: Keerthy 
Signed-off-by: Lokesh Vutla 
Signed-off-by: Dave Gerlach 
Signed-off-by: Alexandre Belloni

rtc: omap: Support ext_wakeup configuration

2016-09-21T19:46:04+00:00

Support configuration of ext_wakeup sources. This patch makes it
possible to enable ext_wakeup and set it's polarity, depending on board
configuration. AM335x's dedicated PMIC (tps65217) uses ext_wakeup to
notify about power-button presses. Handling power-button presses enables
to recover from RTC-only power states correctly.

Signed-off-by: Marcin Niestroj 
Acked-by: Tony Lindgren 
Acked-by: Rob Herring 
Signed-off-by: Alexandre Belloni

rtc: constify rtc_class_ops structures

2016-09-01T23:24:06+00:00

Check for rtc_class_ops structures that are only passed to
devm_rtc_device_register, rtc_device_register,
platform_device_register_data, all of which declare the corresponding
parameter as const.  Declare rtc_class_ops structures that have these
properties as const.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct rtc_class_ops i@p = { ... };

@ok@
identifier r.i;
expression e1,e2,e3,e4;
position p;
@@
(
devm_rtc_device_register(e1,e2,&i@p,e3)
|
rtc_device_register(e1,e2,&i@p,e3)
|
platform_device_register_data(e1,e2,e3,&i@p,e4)
)

@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct rtc_class_ops i = { ... };
// 

Signed-off-by: Julia Lawall 
Acked-by: Baruch Siach 
Acked-by: Hans Ulli Kroll 
Acked-by: Linus Walleij 
Acked-by: Thierry Reding 
Signed-off-by: Alexandre Belloni

rtc: omap: Add external clock enabling support

2015-09-05T17:37:21+00:00

Configure the clock source to external clock if available.
External clock is preferred as it can be ticking during suspend.

Signed-off-by: Keerthy 
Acked-by: Tony Lindgren 
Signed-off-by: Alexandre Belloni

rtc: omap: Add internal clock enabling support

2015-09-05T17:37:20+00:00

The rtc can be clocked by an internal 32K clock. Adding the support
to enable the same.

Signed-off-by: Keerthy 
Acked-by: Tony Lindgren 
Signed-off-by: Alexandre Belloni

drivers/rtc/rtc-omap.c: use module_platform_driver

2015-04-17T13:04:02+00:00

module_platform_driver_probe() prevents driver from requesting probe
deferral.  So using module_platform_drive() to support probe deferral.

Signed-off-by: Lokesh Vutla 
Acked-by: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Paul Walmsley 
Cc: Tero Kristo 
Cc: Sekhar Nori 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds