linux-toradex.git/drivers/rtc/rtc-pm8xxx.c, branch v5.17-rc3

rtc: pm8xxx: Add RTC support for PMIC PMK8350

2021-04-16T22:20:01+00:00

Add the comaptible string for PMIC PMK8350.

Signed-off-by: satya priya 
Reviewed-by: Bjorn Andersson 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/1617976766-7852-2-git-send-email-skakit@codeaurora.org

rtc: pm8xxx: Replace spin_lock_irqsave with spin_lock in hard IRQ

2021-02-05T23:50:47+00:00

It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/1612355981-6764-3-git-send-email-tanxiaofei@huawei.com

rtc: pm8xxx: Read ALARM_EN and update to alarm enabled status

2021-01-12T22:46:46+00:00

ALARM_EN status is retained in PMIC register after device shutdown
if poweron_alarm is enabled. Read it to make sure the driver has
consistent value with the register status.

Signed-off-by: Guixiong Wei 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/1608809337-18852-1-git-send-email-guixiong@codeaurora.org

rtc: rework rtc_register_device() resource management

2020-11-19T11:50:12+00:00

rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.

This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.

While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Alexandre Belloni 
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl

rtc: pm8xxx: clear alarm register when alarm is not enabled

2020-03-23T08:27:17+00:00

Clear alarm register when alarm is not enabled otherwise the consumer
may still start alarm timer if it find the alarm register is not zero.

Signed-off-by: hankecai 
Link: https://lore.kernel.org/r/APoAZgAaCEiRpKG6PlzreaqE.1.1584791417367.Hmail.hankecai@vivo.com
Signed-off-by: Alexandre Belloni

rtc: pm8xxx: stop validating valid alarm time

2020-03-16T10:12:10+00:00

rtc_time64_to_tm never generates an invalid rtc_tm, stop validating it.

Link: https://lore.kernel.org/r/20200306073758.58050-4-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: pm8xxx: : switch to rtc_time64_to_tm/rtc_tm_to_time64

2020-03-16T10:12:10+00:00

Call the 64bit versions of rtc_tm time conversion.

Link: https://lore.kernel.org/r/20200306073758.58050-3-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: pm8xxx: set range

2020-03-16T10:12:10+00:00

The pm8xxx are 32bit seconds counter.

Link: https://lore.kernel.org/r/20200306073758.58050-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: pm8xxx: convert to devm_rtc_allocate_device

2020-03-16T10:12:10+00:00

This allows further improvement of the driver. Also remove the unnecessary
error string as the core will already display error messages.

Link: https://lore.kernel.org/r/20200306073758.58050-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni

rtc: pm8xxx: update kerneldoc for struct pm8xxx_rtc

2019-11-27T08:31:13+00:00

The change from u8 ctrl_reg to const struct pm8xxx_rtc_regs *regs; did not
properly update the kerneldoc comment. Fixes:

drivers/rtc/rtc-pm8xxx.c:64: warning: Function parameter or member 'regs' not described in 'pm8xxx_rtc'

Fixes: c8d523a4b053 ("drivers/rtc/rtc-pm8xxx.c: rework to support pm8941 rtc")
Link: https://lore.kernel.org/r/20191122102212.400158-7-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni