linux-toradex.git/drivers/rtc/rtc-rv8803.c, branch v4.19-rc3

rtc: rv8803: fix possible race condition

2018-03-01T09:49:23+00:00

The probe function is not allowed to fail after registering the RTC. Call
rtc_register_device() at the end.

Signed-off-by: Alexandre Belloni

rtc: rv8803: put struct nvmem_config on the stack

2018-03-01T09:49:22+00:00

Avoid allocating memory for struct nvmem_config.

Signed-off-by: Alexandre Belloni

rtc: rv8803: call rtc_nvmem_register()

2018-03-01T09:49:22+00:00

Call rtc_nvmem_register instead of letting the core do it and stop using
the nvmem_config member of struct rtc_device.

Signed-off-by: Alexandre Belloni

rtc: rv8803: remove rv8803_remove

2017-07-07T11:14:19+00:00

rv8803_remove() is now empty, remove it.

Signed-off-by: Alexandre Belloni

rtc: rv8803: use generic nvmem support

2017-07-07T11:14:18+00:00

Instead of adding a binary sysfs attribute from the driver (which suffers
from a race condition as the attribute appears after the device), use the
core to register an nvmem device.

Signed-off-by: Alexandre Belloni

rtc: rv8803: switch to rtc_register_device

2017-07-07T11:14:16+00:00

This removes a possible race condition and allows for further improvement
of the driver.

Signed-off-by: Alexandre Belloni

rtc: rv8803: Add OF device ID table

2017-03-09T00:29:14+00:00

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Alexandre Belloni

rtc: rv8803: set VDETOFF and SWOFF via device tree

2016-10-12T11:24:39+00:00

There might be designs where the power supply circuit is designed
in a way that VDETOFF and SWOFF is required to be set. Otherwise the
RTC detects a power loss. Add a device tree interface for this.

Signed-off-by: Carsten Resch 
Signed-off-by: Dirk Behme 
Signed-off-by: Oleksij Rempel 
Signed-off-by: Alexandre Belloni

rtc: rv8803: Clear V1F when setting the time

2016-07-28T07:59:43+00:00

V1F indicates that the time accuracy may have been compromised because
of a voltage drop (possibly only temporary) below VLOW1, which stops the
temperature compensation. When the time is set, the accuracy is
restored, so V1F should be cleared in order to indicate this and to be
able to detect the next temperature compensation loss. This is the same
principle as for V2F, which is cleared when the time is set to indicate
that the time is no longer invalid and to be able to detect the next
data loss.

Signed-off-by: Benoît Thébaudeau 
Signed-off-by: Alexandre Belloni

rtc: rv8803: Stop the clock while setting the time

2016-07-28T07:59:41+00:00

According to the application manual of the RX8900, the RESET bit must be
set to 1 to prevent a timer update while setting the time. This also
resets the subsecond counter. The application manual of the RV-8803 does
not mention such a requirement, and it says that the 100th Seconds
register is cleared when writing to the Seconds register, but using the
RESET bit for the RV-8803 too should not be an issue and is probably
safer.

This change also ensures that the RESET bit is initialized properly in
all cases. Indeed, all the registers must be initialized if the voltage
has been lower than VLOW2 (triggering V2F), but not low enough to
trigger a POR.

Signed-off-by: Benoît Thébaudeau 
Signed-off-by: Alexandre Belloni