linux-toradex.git/drivers/rtc/rtc-s3c.c, branch v3.0.26

drivers/rtc/rtc-s3c.c: fixup wake support for rtc

2011-05-12T01:50:44+00:00

The driver is not balancing set_irq and disable_irq_wake() calls, so
ensure that it keeps track of whether the wake is enabled.

The fixes the following error on S3C6410 devices:

  WARNING: at kernel/irq/manage.c:382 set_irq_wake+0x84/0xec()
  Unbalanced IRQ 92 wake disable

Signed-off-by: Ben Dooks 
Signed-off-by: Mark Brown 
Cc: Alessandro Zummo 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

RTC: Fix s3c compile error due to missing s3c_rtc_setpie

2011-03-30T01:46:26+00:00

s3c_rtc_setpie was removed, and it resulted in compiler error:

drivers/rtc/rtc-s3c.c: In function s3c_rtc_release
drivers/rtc/rtc-s3c.c:339:2: error: implicit declaration of function
s3c_rtc_setpie

Fix it by removing s3c_rtc_release calls.

[jstultz: An identical fix was also sent in by Jiri Pinkava
 ]

CC: Thomas Gleixner 
CC: Alessandro Zummo 
Signed-off-by: Vasily Khoruzhick 
Signed-off-by: John Stultz

RTC: Cleanup rtc_class_ops->irq_set_freq()

2011-03-09T19:23:35+00:00

With the generic rtc code now emulating PIE mode irqs via an
hrtimer, no one calls the rtc_class_ops->irq_set_freq call.

This patch removes the hook and deletes the driver functions
if no one else calls them.

CC: Thomas Gleixner 
CC: Alessandro Zummo 
CC: Marcelo Roberto Jimenez 
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz

RTC: Cleanup rtc_class_ops->irq_set_state

2011-03-09T19:23:34+00:00

With PIE mode interrupts now emulated in generic code via an hrtimer,
no one calls rtc_class_ops->irq_set_state(), so this patch removes it
along with driver implementations.

CC: Thomas Gleixner 
CC: Alessandro Zummo 
CC: Marcelo Roberto Jimenez 
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz

drivers/rtc/rtc-s3c.c: fix prototype for s3c_rtc_setaie()

2011-03-05T01:53:38+00:00

Fix s3c_rtc_setaie() prototype to eliminate the following compile
warning:

  drivers/rtc/rtc-s3c.c:383: warning: initialization from incompatible pointer type

(akpm: the rtc_class_ops.alarm_irq_enable() handler is being passed two
arguments where it expects just one, presumably with undesired effects)

Signed-off-by: Axel Lin 
Cc: Alessandro Zummo 
Cc: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: add rtc_valid_tm in s3c_rtc_gettime()

2010-10-28T01:03:06+00:00

Add "rtc_valid_tm" in s3c_rtc_gettime() as per Wan ZongShun's suggestion.

Suggested-by: Wan ZongShun 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix RTC initialization method

2010-10-28T01:03:06+00:00

Change RTC initialization method in probe().  The 'rtc_valid_tm(tm)' can
check whether RTC BCD is valid or not.  And change the method of checking
because the previous method cannot validate RTC BCD registers properly.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: Fix debug message format on RTC

2010-10-28T01:03:06+00:00

Fix debug message format.

Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix on support RTC Alarm

2010-10-28T01:03:06+00:00

The alarm_irq_enable function should be implemented to support RTC alarm.
And fix tabs instead of white space around the proc field.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix setting missing field of getalarm

2010-10-28T01:03:06+00:00

Current s3c_rtc_getalarm() sets missing field of alarm time with 0xff.
But this value should be -1 according to drivers/rtc/interface.c.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds