linux-toradex.git/drivers/rtc/rtc-s3c.c, branch v4.1.10

rtc: s3c: fix disabled clocks for alarm

2015-09-29T17:26:11+00:00

commit 1fb1c35f56bb6ab4a65920c648154b0f78f634a5 upstream.

The clock enable/disable codes for alarm have been removed from
commit 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock
control") and the clocks are disabled even if alarm is set, so alarm
interrupt can't happen.

The s3c_rtc_setaie function can be called several times with 'enabled'
argument having same value, so it needs to check whether clocks are
enabled or not.

Signed-off-by: Joonyoung Shim 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Greg Kroah-Hartman

drivers/rtc/rtc-s3c.c: remove one superfluous rtc_valid_tm() check

2015-04-17T13:04:02+00:00

s3c_rtc_gettime() already returns the result of rtc_valid_tm() on the
obtained time so get rid of another call to rtc_valid_tm().

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Chanwoo Choi 
Cc: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Marek Szyprowski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: fix failed first read of RTC time

2015-04-17T13:04:02+00:00

Initialize the device time (if it is wrong) before registering RTC device
to fix following error message during rtc-s3c probe:

[    2.215414] rtc (null): read_time: fail to read
[    2.216322] s3c-rtc 10070000.rtc: rtc core: registered s3c as rtc1

Signed-off-by: Krzysztof Kozlowski 
Cc: Alessandro Zummo 
Cc: Alexandre Belloni 
Cc: Marek Szyprowski 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: delete duplicate clock control

2015-04-17T13:04:00+00:00

The current functions in s3c-rtc driver execute clk_enable/disable() to
control clocks and some functions execute s3c_rtc_alarm_clk_enable()
unnecessarily.  So this patch deletes the duplicate clock control and
spilts s3c_rtc_alarm_clk_enable() out as
s3c_rtc_enable_clk()/s3c_rtc_disable_clk() to improve readability.

Signed-off-by: Chanwoo Choi 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Cc: Inki Dae 
Cc: Kyungmin Park 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data

2015-03-13T01:46:07+00:00

Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
added an "rtc_src" DT property to specify the clock used as a source to
the S3C real-time clock.

Not all SoCs needs this so commit eaf3a659086e ("drivers/rtc/rtc-s3c.c:
fix initialization failure without rtc source clock") changed to check
the struct s3c_rtc_data .needs_src_clk to conditionally grab the clock.

But that commit didn't update the data for each IP version so the RTC
broke on the boards that needs a source clock. This is the case of at
least Exynos5250 and Exynos5440 which uses the s3c6410 RTC IP block.

This commit fixes the S3C rtc on the Exynos5250 Snow and Exynos5420
Peach Pit and Pi Chromebooks.

Signed-off-by: Javier Martinez Canillas 
Cc: Marek Szyprowski 
Cc: Chanwoo Choi 
Cc: Doug Anderson 
Cc: Olof Johansson 
Cc: Kevin Hilman 
Cc: Tyler Baker 
Cc: Alessandro Zummo 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'platform/remove_owner' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into driver-core-next

2014-11-04T03:53:56+00:00

Remove all .owner fields from platform drivers

drivers/rtc/rtc-s3c.c: fix initialization failure without rtc source clock

2014-10-29T23:33:14+00:00

Fix unconditional initialization failure on non-exynos3250 SoCs.

Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
introduced rtc source clock support, but also added initialization
failure on SoCs, which doesn't need such clock.

Signed-off-by: Marek Szyprowski 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

rtc: s3c: add support for RTC of Exynos3250 SoC

2014-10-14T00:18:17+00:00

Add support for RTC of Exynos3250 SoC.  The Exynos3250 needs source
clock(32.768KHz) for RTC block.  If source clock of RTC is registerd on
clock list of common clk framework, Exynos RTC drvier have to control
this clock.

Clock list for s3c-rtc device:
- rtc : CLK_RTC of CLK_GATE_IP_PERIR is gate clock for RTC.
- rtc_src : XrtcXTI is 32.768.kHz source clock for RTC.
 (XRTCXTI: Specifies a clock from 32.768 kHz crystal pad with XRTCXTI and
 XRTCXTO pins. RTC uses this clock as the source of a real-time clock.)

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type

2014-10-14T00:18:17+00:00

Add s3c_rtc_data structure to variant data according to SoC type.  The
s3c_rtc_data structure includes some functions to control RTC operation
and specific data dependent on SoC type.

Signed-off-by: Chanwoo Choi 
Acked-by: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds