linux-toradex.git/drivers/rtc/rtc-s3c.c, branch v4.4.151

rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()

2016-08-20T16:09:27+00:00

commit 70c96dfac0e231424e17743bd52f6cd2ff1f2439 upstream.

As per code flow s3c_rtc_setfreq() will get called with rtc clock disabled
and in set_freq we perform h/w registers read/write, which results in a
kernel crash on exynos7 platform while probing rtc driver.
Below is code flow:
s3c_rtc_probe()
    clk_prepare_enable(info->rtc_clk) // rtc clock enabled
    s3c_rtc_gettime() // will enable clk if not done, and disable it upon exit
    s3c_rtc_setfreq() //then this will be called with clk disabled

This patch take cares of such issue by adding s3c_rtc_{enable/disable}_clk in
s3c_rtc_setfreq().

Fixes: 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock control")
Signed-off-by: Alim Akhtar 
Reviewed-by: Krzysztof Kozlowski 
Reviewed-by: Pankaj Dubey 
Tested-by: Pankaj Dubey 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Greg Kroah-Hartman

rtc: s3c: Set year, month, day value for setting alarm

2015-11-08T13:12:31+00:00

This patch sets year, month, day value for set_alarm function.
The current driver omits to set the values.

This fixes setting wake alarm for dates different than current day.
Without the patch the alarm scheduled for tomorrow would fire today on
chosen time.

Signed-off-by: Donggeun Kim 
Signed-off-by: MyungJoo Ham 
Signed-off-by: KyungMin Park 
[k.kozlowski: Rebase and test the patch, update commit message]
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s3c: remove unnecessary NULL assignment

2015-09-05T11:19:13+00:00

It's unnecessary the code that assigns info->rtc_clk to NULL in
s3c_rtc_remove.

Signed-off-by: Joonyoung Shim 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s3c: add missing clk control

2015-09-05T11:19:13+00:00

It's missed to call clk_unprepare() about info->rtc_src_clk in
s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in
error routine of s3c_rtc_probe.

Signed-off-by: Joonyoung Shim 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s3c: fix disabled clocks for alarm

2015-09-05T11:19:13+00:00

The clock enable/disable codes for alarm have been removed from
commit 24e1455493da ("drivers/rtc/rtc-s3c.c: delete duplicate clock
control") and the clocks are disabled even if alarm is set, so alarm
interrupt can't happen.

The s3c_rtc_setaie function can be called several times with 'enabled'
argument having same value, so it needs to check whether clocks are
enabled or not.

Signed-off-by: Joonyoung Shim 
Cc:  # v4.1
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s3c: Integrate Exynos3250 into S3C6410

2015-06-19T18:03:20+00:00

There are now no differences between RTC on Exynos3250 and S3C6410.
Merge everything into one so duplicated code could be removed.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Chanwoo Choi 
Acked-by: Alexandre Belloni 
Reviewed-by: Javier Martinez Canillas 
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

drivers/rtc/rtc-s3c.c: remove one superfluous rtc_valid_tm() check

2015-04-17T13:04:02+00:00

s3c_rtc_gettime() already returns the result of rtc_valid_tm() on the
obtained time so get rid of another call to rtc_valid_tm().

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Chanwoo Choi 
Cc: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Marek Szyprowski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: fix failed first read of RTC time

2015-04-17T13:04:02+00:00

Initialize the device time (if it is wrong) before registering RTC device
to fix following error message during rtc-s3c probe:

[    2.215414] rtc (null): read_time: fail to read
[    2.216322] s3c-rtc 10070000.rtc: rtc core: registered s3c as rtc1

Signed-off-by: Krzysztof Kozlowski 
Cc: Alessandro Zummo 
Cc: Alexandre Belloni 
Cc: Marek Szyprowski 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: delete duplicate clock control

2015-04-17T13:04:00+00:00

The current functions in s3c-rtc driver execute clk_enable/disable() to
control clocks and some functions execute s3c_rtc_alarm_clk_enable()
unnecessarily.  So this patch deletes the duplicate clock control and
spilts s3c_rtc_alarm_clk_enable() out as
s3c_rtc_enable_clk()/s3c_rtc_disable_clk() to improve readability.

Signed-off-by: Chanwoo Choi 
Cc: Alessandro Zummo 
Cc: Kukjin Kim 
Cc: Inki Dae 
Cc: Kyungmin Park 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data

2015-03-13T01:46:07+00:00

Commit df9e26d093d3 ("rtc: s3c: add support for RTC of Exynos3250 SoC")
added an "rtc_src" DT property to specify the clock used as a source to
the S3C real-time clock.

Not all SoCs needs this so commit eaf3a659086e ("drivers/rtc/rtc-s3c.c:
fix initialization failure without rtc source clock") changed to check
the struct s3c_rtc_data .needs_src_clk to conditionally grab the clock.

But that commit didn't update the data for each IP version so the RTC
broke on the boards that needs a source clock. This is the case of at
least Exynos5250 and Exynos5440 which uses the s3c6410 RTC IP block.

This commit fixes the S3C rtc on the Exynos5250 Snow and Exynos5420
Peach Pit and Pi Chromebooks.

Signed-off-by: Javier Martinez Canillas 
Cc: Marek Szyprowski 
Cc: Chanwoo Choi 
Cc: Doug Anderson 
Cc: Olof Johansson 
Cc: Kevin Hilman 
Cc: Tyler Baker 
Cc: Alessandro Zummo 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds