linux-toradex.git/drivers/rtc/rtc-s5m.c, branch v3.18-rc5

drivers/rtc/rtc-s5m.c: re-add support for devices without irq specified

2014-08-29T23:28:16+00:00

The rtc-s5m driver used to support devices without irq specified in the
past.  Re-add this support.

The patch fixes boot for Insignal's Exynos4412 based Origen board.

Error messages before the patch:

  ...
  Unable to handle kernel NULL pointer dereference at virtual address 00000094
  pgd = c0004000
  [00000094] *pgd=00000000
  Internal error: Oops: 5 [#1] PREEMPT SMP ARM
  Modules linked in:
  CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.16.0-next-20140804-00008-ga59480f-dirty #701
  task: ea80f000 ti: ea882000 task.ti: ea882000
  PC is at regmap_irq_get_virq+0x0/0x28
  LR is at s5m_rtc_probe+0xdc/0x310
  pc : []    lr : []    psr: 80000153
  sp : ea883e48  ip : 00000000  fp : 00000000
  r10: 0000000c  r9 : c05de7ac  r8 : eaabc600
  r7 : eaa6b4d0  r6 : c0439e8c  r5 : eaabc610  r4 : eab30e50
  r3 : 00000000  r2 : 00000000  r1 : 0000000c  r0 : 00000000
  Flags: Nzcv  IRQs on  FIQs off  Mode SVC_32  ISA ARM  Segment kernel
  Control: 10c5387d  Table: 4000404a  DAC: 00000015
  Process swapper/0 (pid: 1, stack limit = 0xea882240)
  Backtrace:
    regmap_irq_get_virq
    s5m_rtc_probe
    platform_drv_probe
    driver_probe_device
    __driver_attach
    bus_for_each_dev
    bus_add_driver
    driver_register
    do_one_initcall
    kernel_init_freeable
    kernel_init
  ---[ end trace a954d7f019122700 ]---
  Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
  ...

Signed-off-by: Bartlomiej Zolnierkiewicz 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Acked-by: Kyungmin Park 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: consolidate two device type switch statements

2014-06-10T22:34:47+00:00

In probe the configuration of driver for different chipsets was done in
two switch (pdata->device_type) statements.  Consolidate them into one
switch statement to increase code readability.

Additionally check the return value of regmap_irq_get_virq and exit
probe on error.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: add support for S2MPS14 RTC

2014-06-10T22:34:47+00:00

Add support for S2MPS14 to the rtc-s5m driver.  Differences in S2MPS14
(in comparison to S5M8767):

 - Layout of registers
 - Lack of century support for time and alarms (7 registers used for
   storing time/alarm)
 - Two buffer control registers: WUDR and RUDR
 - No register for enabling writing time
 - RTC interrupts are reported in main PMIC I2C device

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: support different register layout

2014-06-10T22:34:47+00:00

Prepare for adding support for S2MPS14 RTC device to the rtc-s5m driver:

1. Add a map of registers used by the driver which differ between
   the chipsets (S5M876X and S2MPS14).

2. Move code of checking for alarm pending to separate function.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: use shorter time of register update

2014-06-10T22:34:47+00:00

Set the time needed for updating alarm and time registers to 0.45 ms.
The default is 7.32 ms which is too long and leads to warnings when
setting alarm or time:

	s5m-rtc: waiting for UDR update, reached max number of retries

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s5m: remove undocumented time init on first boot

2014-06-10T22:34:47+00:00

Remove the code for initializing time if this is first boot.

The code for detecting first boot uses undocumented field RTC_TCON in
RTC_UDR_CON register.  According to S5M8767's datasheet this field is
reserved.  On S2MPS14 it is not documented at all.

On device first boot the registers will be initialized with reset value
(2000-01-01 00:00:00).

The code might work on S5M8763 but still this does not look like a task
for RTC driver.

Signed-off-by: Krzysztof Kozlowski 
Cc: Kyungmin Park 
Cc: Lee Jones 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd/rtc: sec/s5m: rename SEC* symbols to S5M

2014-06-10T22:34:46+00:00

Prepare for adding support for S2MPS14 RTC device to the rtc-s5m driver:

1. Rename SEC* symbols to S5M.
2. Add S5M prefix to some of defines which are different between S5M876X
   and S2MPS14.

This is only a rename-like patch, new code is not added.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Lee Jones 
Cc: Kyungmin Park 
Cc: Alessandro Zummo 
Cc: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Marek Szyprowski 
Cc: Bartlomiej Zolnierkiewicz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-06-03T07:11:16+00:00

The rtc-s5m driver does not support all of S2M and S5M chipsets
supported by main MFD sec-core driver. For such chipsets unsupported by
rtc-s5m, the MFD sec-core driver initialized regmap with default config.
This config in such cases wouldn't work at all.

The main MFD sec-core driver shouldn't initialize regmap for child
drivers which is not used by them and even not valid.

Move the allocation of RTC I2C dummy device and initialization of RTC
regmap from main MFD sec-core driver to the rtc-s5m driver. The rtc-s5m
driver will use proper regmap config for supported devices.

Signed-off-by: Krzysztof Kozlowski 
Acked-by: Alessandro Zummo 
Signed-off-by: Lee Jones

drivers/rtc/rtc-s5m.c: s5m_rtc_{suspend,resume}() should depend on CONFIG_PM_SLEEP

2014-01-24T00:37:00+00:00

If CONFIG_PM_SLEEP=n:

drivers/rtc/rtc-s5m.c:643: warning: `s5m_rtc_resume' defined but not used
drivers/rtc/rtc-s5m.c:654: warning: `s5m_rtc_suspend' defined but not used

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mfd/rtc: s5m: fix register updating by adding regmap for RTC

2013-12-13T02:19:26+00:00

Rename old regmap field of "struct sec_pmic_dev" to "regmap_pmic" and
add new regmap for RTC.

On S5M8767A registers were not properly updated and read due to usage of
the same regmap as the PMIC.  This could be observed in various hangs,
e.g.  in infinite loop during waiting for UDR field change.

On this chip family the RTC has different I2C address than PMIC so
additional regmap is needed.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Kyungmin Park 
Reviewed-by: Mark Brown 
Acked-by: Sangbeom Kim 
Cc: Samuel Ortiz 
Cc: Lee Jones 
Cc: Liam Girdwood 
Cc: Alessandro Zummo 
Cc: Marek Szyprowski 
Cc: Geert Uytterhoeven 
Cc: Kyungmin Park 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds