linux-toradex.git/drivers/rtc/rtc-s5m.c, branch v5.5

rtc: s5m: convert to i2c_new_dummy_device

2019-07-23T18:34:31+00:00

Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.

Signed-off-by: Wolfram Sang 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20190722172618.4061-5-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni

rtc: s5m: Switch to use %ptR

2018-12-10T21:40:10+00:00

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Cc: Bartlomiej Zolnierkiewicz 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Alexandre Belloni

rtc: s5m: Add SPDX license identifier

2018-08-14T21:38:47+00:00

Replace GPL v2.0+ license statement with SPDX license
identifier.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s5m: Remove VLA usage

2018-03-17T13:20:57+00:00

In preparation to enabling -Wvla, remove VLAs and replace them
with fixed-length arrays instead.

>From a security viewpoint, the use of Variable Length Arrays can be
a vector for stack overflow attacks. Also, in general, as the code
evolves it is easy to lose track of how big a VLA can get. Thus, we
can end up having segfaults that are hard to debug.

Also, fixed as part of the directive to remove all VLAs from
the kernel: https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Alexandre Belloni

rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-17T13:20:56+00:00

Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].

[1] https://marc.info/?l=linux-rtc&m=152060068925948&w=2

Suggested-by: Krzysztof Kozlowski 
Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Krzysztof Kozlowski 
Acked-by: Lee Jones 
Signed-off-by: Alexandre Belloni

rtc: stop validating rtc_time in .read_time

2018-03-02T09:09:58+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni

rtc: s5m: De-inline large functions to save space

2016-03-14T16:08:18+00:00

Few functions were marked inline even though they were relatively large
and sometimes used in multiple places. De-inline them to let the
compiler decide whether optimization makes sense. This fixes inline_hunt
report:
drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes
drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes

Reported-by: Denys Vlasenko 
Cc: Denys Vlasenko 
Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Javier Martinez Canillas 
Signed-off-by: Alexandre Belloni

rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2016-01-11T19:21:55+00:00

Before updating time and alarm the driver must set appropriate mask in
UDR register. For that purpose the driver uses common register
configuration and a lot of exceptions per device in the code. The
exceptions are not obvious, for example except the change in the logic
sometimes the fields are swapped (WUDR and AUDR between S2MPS14 and
S2MPS15). This leads to quite complicated code.

Try to make it more obvious by:
1. Documenting the UDR masks for devices and operations.
2. Adding fields in register configuration structure for each operation
   (read time, write time and alarm).
3. Splitting the configuration per S2MPS13, S2MPS14 and S2MPS15 thus
   removing exceptions for them.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Alim Akhtar 
Tested-by: Alim Akhtar 
Acked-by: Lee Jones 
Signed-off-by: Alexandre Belloni

rtc: s5m: Add separate field for storing auto-cleared mask in register config

2016-01-11T19:21:45+00:00

Some devices from S2M/S5M family use different register update masks for
different operations (alarm and register update). Now the driver uses
common register configuration and a lot of exceptions per device in code.

Before eliminating the exceptions and using specific register
configuration for given device, make the auto-cleared mask a separate
field. This is merely a refactoring.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Alim Akhtar 
Tested-by: Alim Akhtar 
Signed-off-by: Alexandre Belloni

rtc: s5m: Cleanup by removing useless 'rtc' prefix from fields

2016-01-11T19:21:35+00:00

Remove the 'rtc' prefix from some of the fields in struct
s5m_rtc_reg_config because it is obvious - this is a RTC driver. No
functional changes.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Alim Akhtar 
Tested-by: Alim Akhtar 
Signed-off-by: Alexandre Belloni