linux-toradex.git/drivers/rtc/rtc-stm32.c, branch v4.20

rtc: stm32: add stm32mp1 rtc support

2018-05-22T18:10:54+00:00

This patch adds support for stm32mp1 RTC.
Some common registers with previous RTC version have a different offset.
It is the case for Control Register (CR) and ALaRMA Register (ALRMAR).
There are also new registers regarding event flags: now, Alarm event flag
is in Status Register (SR) and write 1 in Status Clear Register (SCR) is
required to clear the event.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: rework register management to prepare other version of RTC

2018-05-22T18:10:52+00:00

This patch reworks register/bits management because next version of RTC
uses the same way of working but with different register's offset or bits
moved in new registers.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: fix misspelling and misalignment issues

2018-05-22T18:10:50+00:00

This patch cleans the following checkpatch complaints:

CHECK: 'initalized' may be misspelled - perhaps 'initialized'?
#644: FILE: drivers/rtc/rtc-stm32.c:644:
+	 * the calendar has been initalized or not. INITS flag is reset by a

CHECK: Alignment should match open parenthesis
#669: FILE: drivers/rtc/rtc-stm32.c:669:
+	rtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name,
+			&stm32_rtc_ops, THIS_MODULE);

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: get DBP register and mask from DT st, syscfg property

2018-05-06T20:22:43+00:00

RTC driver should not be aware of the PWR registers offset and bits
position. Furthermore, we can imagine that DBP relative register and bit
mask could change depending on the SoC.
So this patch introduces 2 parameters, dbp_reg and dbp_mask, allowing to
get PWR_CR and PWR_CR_DBP from device tree. And it prepares next RTC
version, backup domain write protection is disabled only if needed.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: fix alarm interrupt flags by removing IRQF_TRIGGER_RISING

2018-05-06T20:22:40+00:00

RTC alarm interrupt is active high and already configured by device tree.
So remove IRQF_TRIGGER_RISING from driver.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: fix copyright and adopt SPDX identifier

2018-05-06T20:22:39+00:00

Fix copyright by removing "SA" and "for STMicroelectronics", not required.
Adopt SPDX identifier.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: Fix copyright

2017-11-29T21:20:56+00:00

Uniformize STMicroelectronics copyrights header

Signed-off-by: Benjamin Gaignard 
CC: Amelie Delaunay 
Acked-by: Alexandre TORGUE 
Signed-off-by: Alexandre Belloni

rtc: stm32: add STM32H7 RTC support

2017-07-06T20:52:54+00:00

This patch adds support for STM32H7 RTC. On STM32H7, the RTC bus interface
clock (APB clock) needs to be enabled.

Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: fix comparison warnings

2017-01-22T23:47:15+00:00

This patches fixes comparison between signed and unsigned values as it
could produce an incorrect result when the signed value is converted to
unsigned:

drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_valid_alrm':
drivers/rtc/rtc-stm32.c:404:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  if ((((tm->tm_year > cur_year) &&
...

It also fixes comparison always true or false due to the fact that unsigned
value is compared against zero with >= or <:

drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_init':
drivers/rtc/rtc-stm32.c:514:35: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
  for (pred_a = pred_a_max; pred_a >= 0; pred_a-- ) {

drivers/rtc/rtc-stm32.c:530:44: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
     (rate - ((pred_a + 1) * (pred_s + 1)) < 0) ?

Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni

rtc: stm32: use 0 instead of ~PWR_CR_DBP in regmap_update_bits

2017-01-22T23:47:15+00:00

Using the ~ operator on a BIT() constant results in a large 'unsigned long'
constant that won't fit into an 'unsigned int' function argument on 64-bit
architectures, resulting in a harmless build warning in x86 allmodconfig:

drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe':
drivers/rtc/rtc-stm32.c:651:51: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
  regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);

As PWR_CR_DBP mask prevents other bits to be cleared, replace all
~PWR_CR_DBP by 0.

Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
Signed-off-by: Arnd Bergmann 
Signed-off-by: Amelie Delaunay 
Signed-off-by: Alexandre Belloni