linux-toradex.git/drivers/rtc/rtc-sun6i.c, branch toradex_4.20.y

rtc: sun6i: Use struct_size() in kzalloc()

2018-08-27T21:02:18+00:00

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
	int stuff;
        void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

Signed-off-by: Gustavo A. R. Silva 
Reviewed-by: Kees Cook 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Fix bit_idx value for clk_register_gate

2018-05-31T21:02:11+00:00

clk-gate core will take bit_idx through clk_register_gate
and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i
is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx)
which is wrong and eventually external gate clock is not enabling.

This patch fixed by passing bit index and the original change
introduced from below commit.
"rtc: sun6i: Add support for the external oscillator gate"
(sha1: 	17ecd246414b3a0fe0cb248c86977a8bda465b7b)

Signed-off-by: Michael Trimarchi 
Fixes: 17ecd246414b ("rtc: sun6i: Add support for the external oscillator gate")
Cc: stable@vger.kernel.org
Signed-off-by: Jagan Teki 
Acked-by: Maxime Ripard 
Signed-off-by: Alexandre Belloni

rtc: stop validating rtc_time in .read_time

2018-03-02T09:09:58+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni

rtc: sun6i: ensure rtc is kfree'd on error

2017-12-18T22:05:10+00:00

The error return path on clk_data allocation failure does not kfree
the allocated rtc object. Fix this with a kfree of rtc on the error
exit path.

Detected by CoverityScan, CID#1452264 ("Resource Leak")

Signed-off-by: Colin Ian King 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Add support for the external oscillator gate

2017-08-31T23:10:19+00:00

The RTC can output its 32kHz clock outside of the SoC, for example to clock
a WiFi chip.

Create a new clock that other devices will be able to retrieve, while
maintaining the DT stability by providing a default name for that clock if
clock-output-names doesn't list one.

Signed-off-by: Maxime Ripard 
Signed-off-by: Alexandre Belloni

rtc: sun6i: ensure clk_data is kfree'd on error

2017-07-30T22:17:46+00:00

There are two error return paths that do not kfree clk_data and
we end up with a memory leak. Fix these with a kfree error exit
path.

Detected by CoverityScan, CID#1402959 ("Resource Leak")

Signed-off-by: Colin Ian King 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Remove double init of spinlock in sun6i_rtc_clk_init()

2017-07-30T22:17:46+00:00

Remove double init of spinlock in sun6i_rtc_clk_init()

Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
Signed-off-by: Alexey Klimov 
Reviewed-by: Chen-Yu Tsai 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Fix return value check in sun6i_rtc_clk_init()

2017-02-11T23:34:31+00:00

In case of error, the function of_io_request_and_map() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
Signed-off-by: Wei Yongjun 
Acked-by: Maxime Ripard 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Fix compatibility with old DT binding

2017-02-01T11:44:24+00:00

Commit 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") adds
a new clock for the rtc block with a 2 step probe mechanism. To share
the register region between both the clock and rtc instance, a static
pointer is used to keep the related data structure.

To preserve compatibility with the old binding, the data structure
should be saved as soon as the registers are mapped in, regardless
of the presence of the clock bindings, so that the rtc device can
retrieve it when it is probed.

This fixes the rtc device not probing when we use the updated driver
with an old device tree blob.

Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator")
Signed-off-by: Chen-Yu Tsai 
Signed-off-by: Alexandre Belloni

rtc: sun6i: Switch to devm_rtc_device_register

2017-02-01T11:44:23+00:00

Now that we have a devm variant of rtc_device_register, switch to it.

Signed-off-by: Maxime Ripard 
Signed-off-by: Alexandre Belloni