linux-toradex.git/drivers/rtc/rtc-twl.c, branch v3.10.56

drivers/rtc/rtc-twl.c: fix missing device_init_wakeup() when booted with device tree

2013-06-12T23:29:45+00:00

When booted in legacy mode device_init_wakeup() gets called by
drivers/mfd/twl-core.c when the children are initialized.  However, when
booted using device tree, the children are created with
of_platform_populate() instead add_children().

This means that the RTC driver will not have device_init_wakeup() set,
and we need to call it from the driver probe like RTC drivers typically
do.

Without this we cannot test PM wake-up events on omaps for cases where
there may not be any physical wake-up event.

Signed-off-by: Tony Lindgren 
Reported-by: Kevin Hilman 
Cc: Alessandro Zummo 
Cc: Jingoo Han 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-twl: convert twl4030rtc_driver to dev_pm_ops

2013-04-30T01:28:40+00:00

Instead of using legacy suspend/resume methods, using newer dev_pm_ops
structure allows better control over power management.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: use of_match_ptr() macro

2013-02-22T01:22:27+00:00

This eliminates having an #ifdef returning NULL for the case when OF is
disabled.  Maintains consistency in cases where OF is always selected.

Signed-off-by: Sachin Kamat 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Drivers: rtc: remove __dev* attributes.

2013-01-03T23:57:02+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Alessandro Zummo 
Cc: Srinidhi Kasagar 
Cc: Linus Walleij 
Cc: Mike Frysinger 
Cc: Wan ZongShun 
Cc: Guan Xuetao 
Cc: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

mfd/rtc/gpio: twl: No need to allocate bigger buffer for write

2012-11-21T15:08:00+00:00

Since the twl-core has been converted to use regmap it is no longer needed
to allocate bigger buffer for data when writing to twl.

CC: Grant Likely 
CC: Alessandro Zummo 
Acked-by: Linus Walleij 
Acked-by: Tero Kristo 
Signed-off-by: Peter Ujfalusi 
Signed-off-by: Samuel Ortiz

drivers/rtc/rtc-twl.c: ensure all interrupts are disabled during probe

2012-09-17T22:00:38+00:00

On some platforms, bootloaders are known to do some interesting RTC
programming.  Without going into the obscurities as to why this may be
the case, suffice it to say the the driver should not make any
assumptions about the state of the RTC when the driver loads.  In
particular, the driver probe should be sure that all interrupts are
disabled until otherwise programmed.

This was discovered when finding bursty I2C traffic every second on
Overo platforms.  This I2C overhead was keeping the SoC from hitting
deep power states.  The cause was found to be the RTC firing every
second on the I2C-connected TWL PMIC.

Special thanks to Felipe Balbi for suggesting to look for a rogue driver
as the source of the I2C traffic rather than the I2C driver itself.

Special thanks to Steve Sakoman for helping track down the source of the
continuous RTC interrups on the Overo boards.

Signed-off-by: Kevin Hilman 
Cc: Felipe Balbi 
Tested-by: Steve Sakoman 
Cc: Alessandro Zummo 
Tested-by: Shubhrajyoti Datta 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT

2012-07-11T23:04:48+00:00

Requesting a threaded interrupt without a primary handler and without
IRQF_ONESHOT is dangerous, and after commit 1c6c6952 ("genirq: Reject
bogus threaded irq requests"), these requests are rejected.  This causes
->probe() to fail, and the RTC driver not to be availble.

To fix, add IRQF_ONESHOT to the IRQ flags.

Tested on OMAP3730/OveroSTORM and OMAP4430/Panda board using rtcwake to
wake from system suspend multiple times.

Signed-off-by: Kevin Hilman 
Cc: Alessandro Zummo 
Cc: Thomas Gleixner 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: use static register while reading time

2012-04-12T20:12:12+00:00

RTC stores time and date in several registers.  Due to the fact that
these registers can't be read instantaneously, there is a chance that
reading from counting registers gives an error of one minute, one hour,
one day, etc.

To address this issue, the RTC has hardware support to copy the RTC
counting registers to static shadowed registers.  The current
implementation does not use this feature, and in a stress test, we can
reproduce this error at a rate of around two times per 300000 readings.

Fix the implementation to ensure that the right snapshot of time is
captured.

Signed-off-by: Konstantin Shlyakhovoy 
Signed-off-by: Nishanth Menon 
Cc: Alessandro Zummo 
Cc: Benoit Cousson 
Cc: linux-omap 
Acked-by: Mykola Oleksiienko 
Acked-by: Oleksandr Dmytryshyn 
Acked-by: Graeme Gregory 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: return correct RTC event from ISR

2012-03-23T23:58:39+00:00

Following changes are made as part of this change:

1. As TWL RTC supports periodic interrupt, the correct event should be
   RTC_PF instead of RTC_UF.

2. No need to initialize variable "events" to 0 & then OR it with the
   event values.  Hence fixing it.

Signed-off-by: Venu Byravarasu 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: simplify RTC interrupt clearing

2012-03-23T23:58:39+00:00

For clearing RTC interrupt, programming ALARM bit only is sufficient, as
all other bits are any way not affected by writing 0 to them.

Hence removed unwanted OR operation.

Signed-off-by: Venu Byravarasu 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds