linux-toradex.git/drivers/rtc/rtc-twl.c, branch v4.10

rtc: twl: make driver DT only

2016-11-30T20:21:33+00:00

Since there are no platform based users and all users
of this code are TI OMAP-based which is DT only, it makes
sense to remove unused code.

Signed-off-by: Nicolae Rosia 
Tested-by: Tony Lindgren 
Signed-off-by: Alexandre Belloni

rtc: twl: kill static variables

2016-11-30T20:21:01+00:00

The current code uses static variables which prevent
the use of multiple rtc twl instances.
We also make it clear that this driver supports only
TWL4030 and TWL6030 classes.

Signed-off-by: Nicolae Rosia 
Tested-by: Tony Lindgren 
Signed-off-by: Alexandre Belloni

rtc: constify rtc_class_ops structures

2016-09-01T23:24:06+00:00

Check for rtc_class_ops structures that are only passed to
devm_rtc_device_register, rtc_device_register,
platform_device_register_data, all of which declare the corresponding
parameter as const.  Declare rtc_class_ops structures that have these
properties as const.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct rtc_class_ops i@p = { ... };

@ok@
identifier r.i;
expression e1,e2,e3,e4;
position p;
@@
(
devm_rtc_device_register(e1,e2,&i@p,e3)
|
rtc_device_register(e1,e2,&i@p,e3)
|
platform_device_register_data(e1,e2,e3,&i@p,e4)
)

@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct rtc_class_ops i = { ... };
// 

Signed-off-by: Julia Lawall 
Acked-by: Baruch Siach 
Acked-by: Hans Ulli Kroll 
Acked-by: Linus Walleij 
Acked-by: Thierry Reding 
Signed-off-by: Alexandre Belloni

rtc: use more standard kernel logging styles

2015-04-17T13:04:02+00:00

Neaten the logging a bit by adding #define pr_fmt

Miscellanea:

o Remove __FILE__/__func__ uses
o Coalesce formats adding missing spaces
o Align arguments
o (rtc-cmos) Integrated 2 consecutive messages

Signed-off-by: Joe Perches 
Acked-by: Alexandre Belloni 
Cc: Alessandro Zummo 
Cc: Joshua Kinard 
Cc: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski 
Tested-by: Krzysztof Kozlowski 
Cc: Aaro Koskinen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: drop owner assignment from platform_drivers

2014-10-20T14:21:31+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

drivers/rtc/rtc-twl.c: use devm_*() functions

2014-01-24T00:36:59+00:00

Use devm_*() functions to make cleanup paths simpler, and remove
unnecessary remove().

Signed-off-by: Jingoo Han 
Cc: Yoichi Yuasa 
Cc: Grygorii Strashko 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: fix: rtcX/wakealarm attribute isn't created

2013-07-31T21:41:03+00:00

The device_init_wakeup() should be called before rtc_device_register().
Otherwise, sysfs "sys/class/rtc/rtcX/wakealarm" attribute will not be seen
from User space.

Signed-off-by: Grygorii Strashko 
Cc: Kevin Hilman 
Cc: Tony Lindgren 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: cleanup with module_platform_driver() conversion

2013-07-03T23:08:00+00:00

Use module_platform_driver() to register the platform driver.

Signed-off-by: Peter Ujfalusi 
Acked-by: Kevin Hilman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: fix rtc_reg_map initialization

2013-07-03T23:08:00+00:00

Initialize the rtc_reg_map in platform_driver's probe function instead at
module_init time.  This way we can make sure that the twl-core has been
already probed and initialized (twl_priv->twl_id is valid) since the
platform device for the RTC driver will be created by the twl-core after
it finished its init.

Reported-by: Christoph Fritz 
Signed-off-by: Peter Ujfalusi 
Tested-by: Kevin Hilman 
Tested-by: Grygorii Strashko 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-twl.c: ensure IRQ is wakeup enabled

2013-07-03T23:07:59+00:00

Currently, the RTC IRQ is never wakeup-enabled so is not capable of
bringing the system out of suspend.

On OMAP platforms, we have gotten by without this because the TWL RTC is
on an I2C-connected chip which is capable of waking up the OMAP via the IO
ring when the OMAP is in low-power states.

However, if the OMAP suspends without hitting the low-power states (and
the IO ring is not enabled), RTC wakeups will not work because the IRQ is
not wakeup enabled.

To fix, ensure the RTC IRQ is wakeup enabled whenever the RTC alarm is
set.

Signed-off-by: Kevin Hilman 
Cc: Alessandro Zummo 
Cc: Tony Lindgren 
Cc: Grygorii Strashko 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds