linux-toradex.git/drivers/rtc, branch v3.10.78

rtc: rtc-at91rm9200: fix infinite wait for ACKUPD irq

2014-06-26T19:12:37+00:00

commit 2fe121e1f5aa3bf31b418a9790db6c400e922291 upstream.

The rtc user must wait at least 1 sec between each time/calandar update
(see atmel's datasheet chapter "Updating Time/Calendar").

Use the 1Hz interrupt to update the at91_rtc_upd_rdy flag and wait for
the at91_rtc_wait_upd_rdy event if the rtc is not ready.

This patch fixes a deadlock in an uninterruptible wait when the RTC is
updated more than once every second.  AFAICT the bug is here from the
beginning, but I think we should at least backport this fix to 3.10 and
the following longterm and stable releases.

Signed-off-by: Boris BREZILLON 
Reported-by: Bryan Evenson 
Tested-by: Bryan Evenson 
Cc: Andrew Victor 
Cc: Nicolas Ferre 
Cc: Jean-Christophe Plagniol-Villard 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

rtc-cmos: Add an alarm disable quirk

2014-02-13T21:48:03+00:00

commit d5a1c7e3fc38d9c7d629e1e47f32f863acbdec3d upstream.

41c7f7424259f ("rtc: Disable the alarm in the hardware (v2)") added the
functionality to disable the RTC wake alarm when shutting down the box.

However, there are at least two b0rked BIOSes we know about:

https://bugzilla.novell.com/show_bug.cgi?id=812592
https://bugzilla.novell.com/show_bug.cgi?id=805740

where, when wakeup alarm is enabled in the BIOS, the machine reboots
automatically right after shutdown, regardless of what wakeup time is
programmed.

Bisecting the issue lead to this patch so disable its functionality with
a DMI quirk only for those boxes.

Cc: Brecht Machiels 
Cc: Thomas Gleixner 
Cc: John Stultz 
Cc: Rabin Vincent 
Signed-off-by: Borislav Petkov 
[jstultz: Changed variable name for clarity, added extra dmi entry]
Tested-by: Brecht Machiels 
Tested-by: Borislav Petkov 
Signed-off-by: John Stultz 
Signed-off-by: Greg Kroah-Hartman

rtc: max8907: weekday encoding fixes

2014-02-06T19:08:15+00:00

commit 75ea799df4cb07e505c91b4abaa87bc28aad3e66 upstream.

The current MAX8907 driver has two issues related to weekday value
handling:

1)

The HW WEEKDAY register has range 0..6 rather than 1..7 as documented.
Note that I validated the actual HW range by observing the HW register
roll from 6->0 rather than 6->7->1 as would otherwise be expected.

This matches Linux's tm_wday range of 0..6.

When the CMOS RAM content is lost, the date returned from the device is
2007-01-01 00:00:00, which is a Monday.  The WEEKDAY register reads 1 in
this case.  This matches the numbering in Linux's tm_wday field.

Hence we should write Linux's tm_wday value to the register without
modifying it.  Hence, remove the +1/-1 calculations for WEEKDAY/tm_wday.

2)

There's no need to make alarms match on the WEEKDAY register, since the
other fields together uniquely define the alarm date/time.  Ignoring the
WEEKDAY value in the match isolates the driver from any incorrect value in
the current time copy of the WEEKDAY register.

Each change individually, or both together, solves an issue that I
observed; "hwclock -r" would time out waiting for its alarm to fire if the
CMOS RAM content had been lost, and hence the WEEKDAY register value
mismatched what the driver expected it to be.  "hwclock -w" would solve
this by over-writing the HW default WEEKDAY register value with what the
driver expected.

Signed-off-by: Stephen Warren 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

drivers/rtc/rtc-at91rm9200.c: correct alarm over day/month wrap

2013-12-20T15:45:09+00:00

commit eb3c227289840eed95ddfb0516046f08d8993940 upstream.

Update month and day of month to the alarm month/day instead of current
day/month when setting the RTC alarm mask.

Signed-off-by: Linus Pizunski 
Signed-off-by: Nicolas Ferre 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

drivers/rtc/rtc-max77686.c: Fix wrong register

2013-09-14T13:54:57+00:00

commit 1748cbf7f7c464593232cde914f5a103181a83b5 upstream.

Fix a read of the wrong register when checking whether the RTC timer has
reached the alarm time.

Signed-off-by: Sangjung Woo 
Signed-off-by: Myugnjoo Ham 
Reviewed-by: Jonghwa Lee 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Jonghwan Choi 
Signed-off-by: Greg Kroah-Hartman

drivers/rtc/rtc-rv3029c2.c: fix disabling AIE irq

2013-07-22T01:21:28+00:00

commit 29ecd78c0fd6ee05f2c6b07b23823a6ae43c13ff upstream.

In the disable AIE irq code path, current code passes "1" to enable
parameter of rv3029c2_rtc_i2c_alarm_set_irq().  Thus it does not disable
AIE irq.

Signed-off-by: Axel Lin 
Acked-by: Heiko Schocher 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

rtc-at91rm9200: use shadow IMR on at91sam9x5

2013-06-12T23:29:46+00:00

Add support for the at91sam9x5-family which must use the shadow
interrupt mask due to a hardware issue (causing RTC_IMR to always be
zero).

Signed-off-by: Johan Hovold 
Acked-by: Nicolas Ferre 
Cc: Douglas Gilbert 
Cc: Jean-Christophe PLAGNIOL-VILLARD 
Cc: Ludovic Desroches 
Cc: Robert Nelson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-at91rm9200: add shadow interrupt mask

2013-06-12T23:29:46+00:00

Add shadow interrupt-mask register which can be used on SoCs where the
actual hardware register is broken.

Note that some care needs to be taken to make sure the shadow mask
corresponds to the actual hardware state.  The added overhead is not an
issue for the non-broken SoCs due to the relatively infrequent
interrupt-mask updates.  We do, however, only use the shadow mask value
as a fall-back when it actually needed as there is still a theoretical
possibility that the mask is incorrect (see the code for details).

Signed-off-by: Johan Hovold 
Acked-by: Nicolas Ferre 
Cc: Douglas Gilbert 
Cc: Jean-Christophe PLAGNIOL-VILLARD 
Cc: Ludovic Desroches 
Cc: Robert Nelson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-at91rm9200: refactor interrupt-register handling

2013-06-12T23:29:46+00:00

Add accessors for the interrupt register.

This will allow us to easily add a shadow interrupt-mask register to use
on SoCs where the interrupt-mask register cannot be used.

Signed-off-by: Johan Hovold 
Acked-by: Nicolas Ferre 
Cc: Douglas Gilbert 
Cc: Jean-Christophe PLAGNIOL-VILLARD 
Cc: Ludovic Desroches 
Cc: Robert Nelson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-at91rm9200: add configuration support

2013-06-12T23:29:45+00:00

Add configuration support which can be used to implement SoC-specific
workarounds for broken hardware.

Signed-off-by: Johan Hovold 
Acked-by: Nicolas Ferre 
Cc: Douglas Gilbert 
Cc: Jean-Christophe PLAGNIOL-VILLARD 
Cc: Ludovic Desroches 
Cc: Robert Nelson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds