linux-toradex.git/drivers/s390/block, branch v2.6.27.50

S390: dasd: support DIAG access for read-only devices

2010-01-06T23:17:15+00:00

commit 22825ab7693fd29769518a0d25ba43c01a50092a upstream.

When a DASD device is used with the DIAG discipline, the DIAG
initialization will indicate success or error with a respective
return code. So far we have interpreted a return code of 4 as error,
but it actually means that the initialization was successful, but
the device is read-only. To allow read-only devices to be used with
DIAG we need to accept a return code of 4 as success.

Re-initialization of the DIAG access is also part of the DIAG error
recovery. If we find that the access mode of a device has been
changed from writable to read-only while the device was in use,
we print an error message.

Signed-off-by: Stefan Weinhuber 
Signed-off-by: Martin Schwidefsky 
Cc: Stephen Powell 
Signed-off-by: Greg Kroah-Hartman

[S390] dcss: fix build bug.

2008-08-25T16:15:01+00:00

Fix this compile bug:

  CC      drivers/s390/block/dcssblk.o
drivers/s390/block/dcssblk.c: In function 'dcssblk_add_store':
drivers/s390/block/dcssblk.c:387: error: implicit declaration of function 'dcssblk_get_segment_by_name'
drivers/s390/block/dcssblk.c:389: error: label 'release_gd' used but not defined
make[1]: *** [drivers/s390/block/dcssblk.o] Error 1
make: *** [drivers/s390/block/] Error 2

Cc: Gerald Schaefer 
Signed-off-by: Heiko Carstens 
Signed-off-by: Martin Schwidefsky

[S390] dcssblk: fix race in dcssblk_add_store()

2008-08-21T17:46:42+00:00

Concurrently adding the same segment may lead to duplicate device_register()
calls, which will trigger an error in kobject code:
"... don't try to register things with the same name in the same directory".
This patch adds a check to avoid this.

Signed-off-by: Gerald Schaefer 
Signed-off-by: Martin Schwidefsky

[S390] cio: call ccw driver notify function with lock held

2008-08-21T17:46:41+00:00

Calling a ccw driver's notify function without the ccw device lock
held opens up a race window between discovery and handling of a change
in the device operational state. As a result, the device driver may
encounter unexpected device malfunction, leading to out-of-retry
situations or similar.

Remove race by extending the ccw device lock from state change
discovery to the calling of the notify function.

Signed-off-by: Peter Oberparleiter 
Signed-off-by: Martin Schwidefsky

[S390] dasd: fix data size for PSF/PRSSD command

2008-08-21T17:46:41+00:00

The Perform Subsystem Function/Prepare for Read Subsystem Data
command requires 12 bytes of parameter data, but the respective data
structure dasd_psf_prssd_data has a length of 16 bytes.
Current storage servers ignore the obsolete bytes, but older models
fail to execute the command and report an incorrect length error.
This causes the device initilization for these devices to fail.
To fix this problem we need to correct the dasd_psf_prssd_data
structure and shorten it to the correct length.

Reported-by: Ivan Warren 
Reviewed-by: Ivan Warren 
Tested-by: Ivan Warren 
CC: stable 
Signed-off-by: Stefan Weinhuber

[S390] drivers/s390: Use an IS_ERR test rather than a NULL test

2008-08-21T17:46:39+00:00

In case of error, functions dasd_kmalloc_request and idal_buffer_alloc
return an ERR pointer, but never return the NULL pointer. So after a
call to one of these functions, a NULL test should be replaced by an
IS_ERR test.

A simplified version of the semantic patch that makes this change is
as follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@correct_null_test@
expression x,E;
statement S1, S2;
@@
x =
(
  dasd_kmalloc_request(...)
|
  idal_buffer_alloc(...)
)
<... when != x = E
if (
(
- x@p2 != NULL
+ ! IS_ERR ( x )
|
- x@p2 == NULL
+ IS_ERR( x )
)
 )
S1
else S2
...>
? x = E;
// 

Signed-off-by:  Julien Brunel 
Signed-off-by:  Julia Lawall 
Signed-off-by: Martin Schwidefsky

[S390] dasd: Add support for enhanced VM UID

2008-08-01T14:39:29+00:00

When z/VM provides two virtual devices (minidisks) that reside on the
same real device, both will receive the configuration data from the
real device and thus get the same uid. To fix this problem, z/VM
provides an additional configuration data record that allows to
distinguish between minidisks.
z/VM APAR VM64273 needs be installed so this fix has an effect.

Signed-off-by: Stefan Weinhuber 
Signed-off-by: Martin Schwidefsky

[S390] dasd: use -EOPNOTSUPP instead of -ENOTSUPP

2008-07-17T15:22:10+00:00

return value -ENOTSUPP is not valid in userspace context, use
-EOPNOTSUPP instead

Signed-off-by: Stefan Haberland 
Cc: Martin Schwidefsky 
Signed-off-by: Heiko Carstens

[S390] dasd: Fix cleanup in dasd_{fba,diag}_check_characteristics().

2008-07-17T15:22:08+00:00

Signed-off-by: Cornelia Huck 
Signed-off-by: Heiko Carstens 
Cc: Martin Schwidefsky

[S390] dasd: fix unsolicited SIM handling.

2008-07-17T15:22:08+00:00

Add missing schedule_bh and check that there is 32 bit sense data.

Signed-off-by: Stefan Haberland 
Signed-off-by: Heiko Carstens 
Cc: Martin Schwidefsky