linux-toradex.git/drivers/s390/crypto/pkey_api.c, branch v4.20

s390/pkey: move pckmo subfunction available checks away from module init

2018-10-22T06:37:46+00:00

The init of the pkey module currently fails if the pckmo instruction
or the subfunctions are not available.  However, customers may
restrict their LPAR to switch off exactly these functions and work
with secure key only. So it is a valid case to have the pkey module
active and use it for secure key to protected key transfer only.

This patch moves the pckmo subfunction check from the pkey module init
function into the internal function where the pckmo instruction is
called. So now only on invocation of the pckmo instruction the check
for the required subfunction is done. If not available EOPNOTSUPP is
returned to the caller.

The check for having the pckmo instruction available is still done
during module init. This instruction came in with MSA 3 together with
the basic set of kmc instructions needed to work with protected keys.

Signed-off-by: Harald Freudenberger 
Reviewed-by: Ingo Franzki 
Signed-off-by: Martin Schwidefsky

s390/pkey: Load pkey kernel module automatically

2018-10-19T06:18:18+00:00

With the recent enhancements of the pkey kernel module,
the pkey kernel module should be loaded automatically
during system startup, if MSA is available.

When used for swap device encryption with random protected
keys, pkey must be loaded before /etc/crypttab is processed,
otherwise the sysfs attributes to read the key from are
not available.

Signed-off-by: Ingo Franzki 
Reviewed-by: Hendrik Brueckner 
Reviewed-by: Harald Freudenberger 
Signed-off-by: Martin Schwidefsky

s390/pkey: Introduce new API for transforming key blobs

2018-10-10T05:37:19+00:00

Introduce a new ioctl API and in-kernel API to transform
a variable length key blob of any supported type into a
protected key.

Transforming a secure key blob uses the already existing
function pkey_sec2protk().
Transforming a protected key blob also verifies if the
protected key is still valid. If not, -ENODEV is returned.

Both APIs are described in detail in the header files
arch/s390/include/asm/pkey.h and arch/s390/include/uapi/asm/pkey.h.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/pkey: Introduce new API for random protected key verification

2018-10-10T05:37:18+00:00

Introduce a new ioctl API and in-kernel API to verify if a
random protected key is still valid. A protected key is
invalid when its wrapping key verification pattern does not
match the verification pattern of the LPAR. Each time an LPAR
is activated, a new LPAR wrapping key is generated and the
wrapping key verification pattern is updated.
Both APIs are described in detail in the header files
arch/s390/include/asm/pkey.h and arch/s390/include/uapi/asm/pkey.h.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/pkey: Add sysfs attributes to emit secure key blobs

2018-10-10T05:37:17+00:00

Add binary read-only sysfs attributes for the pkey module
that can be used to read random ccadata secure keys from.
Keys are read from these attributes using a cat-like interface.

A typical use case for those keys is to encrypt a swap device
using the paes cipher. During processing of /etc/crypttab, the
random random ccadata secure key to encrypt the swap device is
read from one of the attributes.

The following attributes are added:
  ccadata/aes_128
  ccadata/aes_192
  ccadata/aes_256
  ccadata/aes_128_xts
  ccadata/aes_256_xts
Each attribute emits a secure key blob for the corresponding
key size and cipher mode.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/pkey: Add sysfs attributes to emit protected key blobs

2018-10-10T05:37:14+00:00

Add binary read-only sysfs attributes for the pkey module
that can be used to read random protected keys from.
Keys are read from these attributes using a cat-like interface.

A typical use case for those keys is to encrypt a swap device
using the paes cipher. During processing of /etc/crypttab, the
random protected key to encrypt the swap device is read from
one of the attributes.

The following attributes are added:
  protkey/aes_128
  protkey/aes_192
  protkey/aes_256
  protkey/aes_128_xts
  protkey/aes_256_xts
Each attribute emits a protected key blob for the corresponding
key size and cipher mode.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/pkey: Define protected key blob format

2018-10-09T09:21:38+00:00

Define a new protected key blob format. Protected key
blobs use a type of 0x00, to be distinguished from other
CCA key blobs. CCA defines type 0x00 as NULL key blob,
but pkey will never use NULL keys anyway, so it is save
to reuse this type. Using another so far undefined type
value would introduce the risk that sometimes in the
future CCA defines this so far unassigned type for a
future key blob.

Also add defines for the key token types and versions,
and use them instead of hard coded hex values.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/pkey: Introduce new API for random protected key generation

2018-10-09T09:21:38+00:00

This patch introduces a new ioctl API and in-kernel API to
generate a random protected key. The protected key is generated
in a way that the effective clear key is never exposed in clear.
Both APIs are described in detail in the header files
arch/s390/include/asm/pkey.h and arch/s390/include/uapi/asm/pkey.h.

Signed-off-by: Ingo Franzki 
Reviewed-by: Harald Freudenberger 
Reviewed-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/zcrypt: code beautify

2018-08-20T14:02:11+00:00

Code beautify by following most of the checkpatch suggestions:
 - SPDX license identifier line complains by checkpatch
 - missing space or newline complains by checkpatch
 - octal numbers for permssions complains by checkpatch
 - renaming of static sysfs functions complains by checkpatch
 - fix of block comment complains by checkpatch
 - fix printf like calls where function name instead of %s __func__
   was used
 - __packed instead of __attribute__((packed))
 - init to zero for static variables removed
 - use of DEVICE_ATTR_RO and DEVICE_ATTR_RW macros

No functional code changes or API changes!

Signed-off-by: Harald Freudenberger 
Signed-off-by: Martin Schwidefsky

s390/crypto: fix gcc 8 stringop-truncation warning

2018-07-16T13:45:36+00:00

Replace strncpy which is used to deliberately avoid string NUL-termination
with memcpy. This allows to get rid of gcc 8 stringop-truncation warning:

    inlined from 'query_crypto_facility.constprop' at
    drivers/s390/crypto/pkey_api.c:702:2:
./include/linux/string.h:246:9: warning: '__builtin_strncpy' output
truncated before terminating nul copying 8 bytes from a string of the
same length [-Wstringop-truncation]

Reviewed-by: Harald Freudenberger 
Signed-off-by: Vasily Gorbik 
Signed-off-by: Martin Schwidefsky