linux-toradex.git/drivers/s390, branch v2.6.28

[SCSI] zfcp: prevent double decrement on host_busy while being busy

2008-12-01T16:18:20+00:00

The zfcp_scsi_queuecommand was not acting according to the standard
when the respective unit was not available. In this case an -EBUSY was
returned, which is not valid in itself, and in addition scsi_done
was called. This combination is not allowed and was leading to a
double finish of the request and therefor double decrement of the
host_busy counter.

Signed-off-by: Swen Schillig 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

[SCSI] zfcp: fix deadlock between wq triggered port scan and ERP

2008-12-01T16:18:04+00:00

Waiting for the ERP to be finished in a task running in the global
kernel work-queue is a bad idea, especially if the ERP needs to run
another job in this work-queue before it can finish. -> deadlock.

This patch removes the necessity to wait for a finished ERP from the
scan task and moves the job scheduling to the end of the ERP.

Signed-off-by: Swen Schillig 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

[SCSI] zfcp: eliminate race between validation and locking

2008-12-01T16:17:50+00:00

The check of having a valid pointer was performed before the
processing was secured by the lock. Between those two steps the
pointer can turn invalid.  During further processing another value is
used (referenced by the pointer described above) as a function pointer
which is never verified to be valid either, resulting under some
circumstances in an invalid function call.  This patch is fixing both
issues.

Signed-off-by: Swen Schillig 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

[SCSI] zfcp: verify for correct rport state before scanning for SCSI devs

2008-12-01T16:17:34+00:00

Prevent a SCSI target scan for a rport which have turned invalid
in the meantime.

Signed-off-by: Swen Schillig 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

[SCSI] zfcp: returning an ERR_PTR where a NULL value is expected

2008-12-01T16:17:14+00:00

Aborting a SCSI cmnd might requrie to send a abort_fsf_cmnd. If the
creation of this fsf_req fails an ERR_PTR is returned where a NULL
value would be expected as an error indicator. This ERR_PTR is
dereferenced as valid fsf_req in succeeding processing leading to
an error.

Signed-off-by: Swen Schillig 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

[SCSI] zfcp: Fix opening of wka ports

2008-12-01T16:16:59+00:00

Running two wka_port_get calls in parallel could issue two open_port
requests, overwriting the port handle. Don't issue an open_port
for the state PORT_OPENING, and only read the data from GOOD
responses.

Signed-off-by: Christof Schmitt 
Acked-by: Swen Schillig 
Signed-off-by: James Bottomley

[SCSI] zfcp: fix remote port status check

2008-12-01T16:16:44+00:00

For an incoming RSCN it was checked by the ZFCP_STATUS_PORT_DID_DID
define to re-open a remote port or to test the connection. Since this
define was re-used it was also necessary to replace that define with
ZFCP_STATUS_PORT_PHYS_OPEN.

Signed-off-by: Martin Petermann 
Signed-off-by: Christof Schmitt 
Signed-off-by: James Bottomley

Merge branch 'for-linus' of git://git390.osdl.marist.edu/pub/scm/linux-2.6

2008-11-15T19:38:02+00:00

* 'for-linus' of git://git390.osdl.marist.edu/pub/scm/linux-2.6:
  [S390] fix s390x_newuname
  [S390] dasd: log sense for fatal errors
  [S390] cpu topology: fix locking
  [S390] cio: Fix refcount after moving devices.
  [S390] ftrace: fix kernel stack backchain walking
  [S390] ftrace: disable tracing on idle psw
  [S390] lockdep: fix compile bug
  [S390] kvm_s390: Fix oops in virtio device detection with "mem="
  [S390] sclp: emit error message if assign storage fails
  [S390] Fix range for add_active_range() in setup_memory()

[S390] dasd: log sense for fatal errors

2008-11-14T17:18:54+00:00

The logging of sense data for fatal errors was accidentally removed
during Hyper PAV implementation.

Signed-off-by: Stefan Haberland 
Signed-off-by: Martin Schwidefsky

[S390] cio: Fix refcount after moving devices.

2008-11-14T17:18:54+00:00

In ccw_device_move_to_orphanage(), a replacing ccw_device
is searched via get_{disc,orphaned}_ccwdev_by_dev_id()
which obtain a reference on the returned ccw_device.
This reference must be given up again after the device
has been moved to its new parent.

Signed-off-by: Cornelia Huck 
Signed-off-by: Martin Schwidefsky