linux-toradex.git/drivers/scsi/53c700.c, branch v5.0

scsi: 53c700: pass correct "dev" to dma_alloc_attrs()

2019-01-29T06:33:00+00:00

The "hostdata->dev" pointer is NULL here.  We set "hostdata->dev = dev;"
later in the function and we also use "hostdata->dev" when we call
dma_free_attrs() in NCR_700_release().

This bug predates git version control.

Signed-off-by: Dan Carpenter 
Signed-off-by: Martin K. Petersen

scsi: flip the default on use_clustering

2018-12-19T04:13:12+00:00

Most SCSI drivers want to enable "clustering", that is merging of
segments so that they might span more than a single page.  Remove the
ENABLE_CLUSTERING define, and require drivers to explicitly set
DISABLE_CLUSTERING to disable this feature.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: 53c700: move bus reset to host reset

2017-08-25T21:21:11+00:00

bus reset always returns SUCCESS, meaning host reset was never
tested. At the same time the only difference to the HBA is a missing
call to NCR_700_chip_reset().  So add the missing call to bus reset,
drop host reset, and move bus reset to host reset.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: 53c700: switch to dma_alloc_attrs

2017-06-26T19:01:05+00:00

Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent
wrapper.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: remove current_cmnd field from struct scsi_device

2016-07-14T02:33:23+00:00

The field is only used by the 53c700 driver, so move it into the
driver-private device data instead of having it in the common structure.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Tomas Henzl 
Reviewed-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen

53c700: Use proper debug printk format specifiers

2016-07-13T03:16:31+00:00

When enabling the debug options NCR_700_DEBUG and NCR_700_TAG_DEBUG
various printk format warnings can be seen like:
drivers/scsi/53c700.c:357:2: warning: format  %p  expects argument of type  void * , but argument 4 has type  dma_addr_t  [-Wformat=]
  script_patch_32(hostdata->dev, script, MessageLocation,

Fix them by using the right printk format specifiers.

Signed-off-by: Helge Deller 
Signed-off-by: Martin K. Petersen

53c700: fix BUG on untagged commands

2016-06-15T01:17:22+00:00

The untagged command case in the 53c700 driver has been broken since
host wide tags were enabled because the replaced scsi_find_tag()
function had a special case for the tag value SCSI_NO_TAG to retrieve
sdev->current_cmnd.  The replacement function scsi_host_find_tag() has
no such special case and returns NULL causing untagged commands to
trigger a BUG() in the driver.  Inspection shows that the 53c700 is the
only driver using this SCSI_NO_TAG case, so a local fix in the driver
suffices to fix this problem globally.

Fixes: 64d513ac31b - "scsi: use host wide tags by default"
Cc: stable@vger.kernel.org	# 4.4+
Reported-by: Helge Deller 
Tested-by: Helge Deller 
Signed-off-by: James Bottomley 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Ewan D. Milne 
Acked-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: use host wide tags by default

2015-11-10T01:11:57+00:00

This patch changes the !blk-mq path to the same defaults as the blk-mq
I/O path by always enabling block tagging, and always using host wide
tags.  We've had blk-mq available for a few releases so bugs with
this mode should have been ironed out, and this ensures we get better
coverage of over tagging setup over different configs.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Reviewed-by: Hannes Reinecke 
Signed-off-by: James Bottomley

[SCSI] Fix printk typos in drivers/scsi

2015-08-07T12:28:45+00:00

This patch fix spme spelling typos in printk within drivers/scsi.

Signed-off-by: Masanari Iida 
Signed-off-by: Jiri Kosina

scsi: remove scsi_set_tag_type

2014-12-04T08:57:13+00:00

There is no benefit over just setting sdev->simple_tags directly.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen