linux-toradex.git/drivers/scsi/advansys.c, branch v4.9.67

Merge branch 'mkp-fixes' into fixes

2015-12-03T17:32:33+00:00

advansys: fix big-endian builds

2015-11-18T15:16:19+00:00

Building the advansys driver in a big-endian configuration such as
ARM allmodconfig shows a warning:

 drivers/scsi/advansys.c: In function 'adv_build_req':
 include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
  #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
 drivers/scsi/advansys.c:7806:22: note: in expansion of macro 'cpu_to_le32'
   scsiqp->sense_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE);

It turns out that the commit that introduced this used the cpu_to_le32()
incorrectly on an 8-bit field, which results in the sense_len to always
be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
byte of the 32-bit intermediate.

This removes the cpu_to_le32() call to restore the original version.

I found this only by looking at the compiler output and have not done a
full review for possible further endianess bugs in the same driver.

Signed-off-by: Arnd Bergmann 
Fixes: 811ddc057aac ("advansys: use DMA-API for mapping sense buffer")
Reviewed-by: Hannes Reinecke 
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Martin K. Petersen

scsi: use host wide tags by default

2015-11-10T01:11:57+00:00

This patch changes the !blk-mq path to the same defaults as the blk-mq
I/O path by always enabling block tagging, and always using host wide
tags.  We've had blk-mq available for a few releases so bugs with
this mode should have been ironed out, and this ensures we get better
coverage of over tagging setup over different configs.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Reviewed-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: fix compilation errors and warnings when CONFIG_PCI is not set

2015-06-13T15:42:36+00:00

Fix compilation errors on forgotten #include  and warnings when
CONFIG_PCI is not set.

Reported-by: Jim Davis 
Signed-off-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: Update to version 3.5 and remove compilation warning

2015-05-26T06:01:34+00:00

The driver has now been converted to DMA-API, so we should
increase the version number and remove the compilation
warning.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: Remove call to dma_cache_sync()

2015-05-26T06:00:59+00:00

Only required if the dma buffer has been allocated via
dma_alloc_noncoherent(), which this one is not.
With that call removed we can now also compile on ARM.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: use spin_lock_irqsave() in interrupt handler

2015-05-26T06:00:13+00:00

We should be using spin_lock_irqsave() when within the
interrupt handler.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: Check for DMA mapping errors

2015-05-26T05:59:42+00:00

DMA mapping might fail, so we need to check for errors here.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: Remove cmd_per_lun setting

2015-05-26T05:59:12+00:00

Ancient, and pretty much obsolete by now.

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley

advansys: Remove obsolete virtual memory mapping comment

2015-05-26T05:58:41+00:00

Signed-off-by: Hannes Reinecke 
Signed-off-by: James Bottomley