linux-toradex.git/drivers/scsi/aha152x.c, branch v7.2-rc5

scsi: Change the return type of the .queuecommand() callback

2026-01-24T02:32:34+00:00

In clang version 21.1 and later the -Wimplicit-enum-enum-cast warning
option has been introduced. This warning is enabled by default and can
be used to catch .queuecommand() implementations that return another
value than 0 or one of the SCSI_MLQUEUE_* constants. Hence this patch
that changes the return type of the .queuecommand() implementations from
'int' into 'enum scsi_qc_status'. No functionality has been changed.

Cc: Damien Le Moal 
Cc: John Garry 
Signed-off-by: Bart Van Assche 
Link: https://patch.msgid.link/20260115210357.2501991-6-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: aha152x: Return SCSI_MLQUEUE_HOST_BUSY instead of 0x2003

2026-01-24T02:32:34+00:00

.queuecommand() implementations are expected to return a SCSI_MLQUEUE_*
value. Return SCSI_MLQUEUE_HOST_BUSY from aha152x_internal_queue()
instead of 0x2003. This patch doesn't change any functionality since
scsi_dispatch_cmd() converts all return values other than SCSI_MLQUEUE_*
into SCSI_MLQUEUE_HOST_BUSY.

Cc: Juergen E. Fischer 
Signed-off-by: Bart Van Assche 
Reviewed-by: John Garry 
Link: https://patch.msgid.link/20260115210357.2501991-2-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: switch ->bios_param() to passing gendisk

2025-08-13T06:59:28+00:00

Instances are passed struct block_device *bdev argument; the only thing
it is used for (if it's used in the first place) is bdev->bd_disk.
Might as well pass that in the first place...

Reviewed-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Signed-off-by: Al Viro

scsi: make aha152x depend on !HIGHMEM

2025-05-05T19:22:39+00:00

This is one of the last drivers depending on the block layer bounce
buffering code.  Restrict it to run on non-highmem configs so that the
bounce buffering code can be removed.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: John Garry 
Reviewed-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/20250505081138.3435992-2-hch@lst.de
Signed-off-by: Jens Axboe

scsi: aha152x: Switch to irq_get_nr_irqs()

2024-10-16T19:56:58+00:00

Use the irq_get_nr_irqs() function instead of the global variable
'nr_irqs'. Prepare for changing 'nr_irqs' from an exported global
variable into a variable with file scope.

Signed-off-by: Bart Van Assche 
Signed-off-by: Thomas Gleixner 
Link: https://lore.kernel.org/all/20241015190953.1266194-12-bvanassche@acm.org

scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion

2024-07-11T02:51:44+00:00

The _ONSTACK variant should be used for on-stack completion, otherwise it
will break lockdep. See also commit 6e9a4738c9fa ("[PATCH] completions:
lockdep annotate on stack completions").

Signed-off-by: Zhongqiu Han 
Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com
Signed-off-by: Martin K. Petersen

scsi: core: Add a no_highmem flag to struct Scsi_Host

2024-04-12T01:37:48+00:00

While we really should be killing the block layer bounce buffering ASAP, I
even more urgently need to stop the drivers to fiddle with the limits from
->slave_configure.  Add a no_highmem flag to the Scsi_Host to centralize
this setting and switch the remaining four drivers that use block layer
bounce buffering to it.

Signed-off-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20240409143748.980206-7-hch@lst.de
Reviewed-by: Bart Van Assche 
Reviewed-by: Damien Le Moal 
Reviewed-by: John Garry 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi: aha152x: Declare SCSI host template const

2023-03-24T23:19:20+00:00

Make it explicit that the SCSI host template is not modified.

Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-19-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

scsi: aha152x: Stop using struct scsi_pointer

2022-03-30T03:42:18+00:00

Remove aha152x_cmd_priv.scsi_pointer by moving the necessary members into
aha152x_cmd_priv proper.

Tested with an Adaptec SlimSCSI APA-1460A card.

Link: https://lore.kernel.org/r/bdc1264b6dd331150bffb737958cab8c9c068fa1.1648070977.git.fthain@linux-m68k.org
Cc: Christoph Hellwig 
Suggested-by: Christoph Hellwig 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Finn Thain 
Signed-off-by: Martin K. Petersen

scsi: aha152x: Fix aha152x_setup() __setup handler return value

2022-02-28T02:39:32+00:00

__setup() handlers should return 1 if the command line option is handled
and 0 if not (or maybe never return 0; doing so just pollutes init's
environment with strings that are not init arguments/parameters).

Return 1 from aha152x_setup() to indicate that the boot option has been
handled.

Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Link: https://lore.kernel.org/r/20220223000623.5920-1-rdunlap@infradead.org
Cc: "Juergen E. Fischer" 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Reported-by: Igor Zhbanov 
Signed-off-by: Randy Dunlap 
Signed-off-by: Martin K. Petersen